Prefer single quotes for strings

Author: Dana Powers

kafka/client.py

@@ -22,7 +22,7 @@
 
 class KafkaClient(object):
 
-    CLIENT_ID = b"kafka-python"
+    CLIENT_ID = b'kafka-python'
 
     # NOTE: The timeout given to the client should always be greater than the
     # one passed to SimpleConsumer.get_message(), otherwise you can get a
@@ -50,7 +50,7 @@ def __init__(self, hosts, client_id=CLIENT_ID,
     ##################
 
     def _get_conn(self, host, port):
-        "Get or create a connection to a broker using host and port"
+        """Get or create a connection to a broker using host and port"""
         host_key = (host, port)
         if host_key not in self.conns:
             self.conns[host_key] = KafkaConnection(
@@ -122,10 +122,10 @@ def _send_broker_unaware_request(self, payloads, encoder_fn, decoder_fn):
                 return decoder_fn(response)
 
             except Exception:
-                log.exception("Could not send request [%r] to server %s:%i, "
-                              "trying next server" % (requestId, host, port))
+                log.exception('Error sending request [%s] to server %s:%s, '
+                              'trying next server', requestId, host, port)
 
-        raise KafkaUnavailableError("All servers failed to process request")
+        raise KafkaUnavailableError('All servers failed to process request')
 
     def _send_broker_aware_request(self, payloads, encoder_fn, decoder_fn):
         """
@@ -180,7 +180,7 @@ def _send_broker_aware_request(self, payloads, encoder_fn, decoder_fn):
 
             except ConnectionError as e:
                 broker_failures.append(broker)
-                log.warning("Could not send request [%s] to server %s: %s",
+                log.warning('Could not send request [%s] to server %s: %s',
                             binascii.b2a_hex(request), broker, e)
 
                 for payload in payloads:
@@ -201,15 +201,14 @@ def _send_broker_aware_request(self, payloads, encoder_fn, decoder_fn):
                     response = conn.recv(requestId)
                 except ConnectionError as e:
                     broker_failures.append(broker)
-                    log.warning("Could not receive response to request [%s] "
-                                "from server %s: %s",
+                    log.warning('Could not receive response to request [%s] '
+                                'from server %s: %s',
                                 binascii.b2a_hex(request), conn, e)
 
                     for payload in payloads:
                         responses_by_broker[broker].append(FailedPayloadsError(payload))
 
                 else:
-
                     for payload_response in decoder_fn(response):
                         responses_by_broker[broker].append(payload_response)
 
@@ -300,7 +299,7 @@ def ensure_topic_exists(self, topic, timeout = 30):
 
         while not self.has_metadata_for_topic(topic):
             if time.time() > start_time + timeout:
-                raise KafkaTimeoutError("Unable to create topic {0}".format(topic))
+                raise KafkaTimeoutError('Unable to create topic {0}'.format(topic))
             try:
                 self.load_metadata_for_topics(topic)
             except LeaderNotAvailableError:
@@ -348,8 +347,8 @@ def load_metadata_for_topics(self, *topics):
 
         resp = self.send_metadata_request(topics)
 
-        log.debug("Received new broker metadata: %s", resp.brokers)
-        log.debug("Received new topic metadata: %s", resp.topics)
+        log.debug('Received new broker metadata: %s', resp.brokers)
+        log.debug('Received new topic metadata: %s', resp.topics)
 
         self.brokers = dict([(broker.nodeId, broker)
                              for broker in resp.brokers])
@@ -368,7 +367,7 @@ def load_metadata_for_topics(self, *topics):
                     raise
 
                 # Otherwise, just log a warning
-                log.error("Error loading topic metadata for %s: %s", topic, type(e))
+                log.error('Error loading topic metadata for %s: %s', topic, type(e))
                 continue
 
             self.topic_partitions[topic] = {}
@@ -409,7 +408,6 @@ def load_metadata_for_topics(self, *topics):
 
     def send_metadata_request(self, payloads=[], fail_on_error=True,
                               callback=None):
-
         encoder = KafkaProtocol.encode_metadata_request
         decoder = KafkaProtocol.decode_metadata_response