Skip to content

Commit d67157c

Browse files
committed
Remove support for api versions as strings from KafkaAdmin
This is a new class, so let's not support the old version strings and saddle ourselves with tech debt right from the get-go.
1 parent 1d44363 commit d67157c

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

kafka/admin/kafka.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -174,16 +174,6 @@ def __init__(self, **configs):
174174
self.config = copy.copy(self.DEFAULT_CONFIG)
175175
self.config.update(configs)
176176

177-
# api_version was previously a str. accept old format for now
178-
if isinstance(self.config['api_version'], str):
179-
deprecated = self.config['api_version']
180-
if deprecated == 'auto':
181-
self.config['api_version'] = None
182-
else:
183-
self.config['api_version'] = tuple(map(int, deprecated.split('.')))
184-
log.warning('use api_version=%s [tuple] -- "%s" as str is deprecated',
185-
str(self.config['api_version']), deprecated)
186-
187177
# Configure metrics
188178
metrics_tags = {'client-id': self.config['client_id']}
189179
metric_config = MetricConfig(samples=self.config['metrics_num_samples'],

0 commit comments

Comments
 (0)