Skip to content

Commit 3e332e8

Browse files
committed
Remove unused fixtures
These fixtures and helper functions were either unused or easily replaced.
1 parent ca00436 commit 3e332e8

File tree

1 file changed

+2
-18
lines changed

1 file changed

+2
-18
lines changed

test/test_consumer_group.py

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import pytest
77
from kafka.vendor import six
88

9-
from kafka import SimpleClient
109
from kafka.conn import ConnectionStates
1110
from kafka.consumer.group import KafkaConsumer
1211
from kafka.coordinator.base import MemberState, Generation
@@ -20,25 +19,10 @@ def get_connect_str(kafka_broker):
2019
return kafka_broker.host + ':' + str(kafka_broker.port)
2120

2221

23-
@pytest.fixture
24-
def simple_client(kafka_broker):
25-
return SimpleClient(get_connect_str(kafka_broker))
26-
27-
28-
@pytest.fixture
29-
def topic(simple_client):
30-
topic = random_string(5)
31-
simple_client.ensure_topic_exists(topic)
32-
return topic
33-
34-
3522
@pytest.mark.skipif(not version(), reason="No KAFKA_VERSION set")
36-
def test_consumer(kafka_broker, version):
37-
23+
def test_consumer(kafka_broker, topic, version):
24+
# The `topic` fixture is included because
3825
# 0.8.2 brokers need a topic to function well
39-
if version >= (0, 8, 2) and version < (0, 9):
40-
topic(simple_client(kafka_broker))
41-
4226
consumer = KafkaConsumer(bootstrap_servers=get_connect_str(kafka_broker))
4327
consumer.poll(500)
4428
assert len(consumer._client._conns) > 0

0 commit comments

Comments
 (0)