-
-
Notifications
You must be signed in to change notification settings - Fork 11
Functional expressions #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rimary key (there is only one)
| var index = indexes.Single(); | ||
|
|
||
| Assert.That(index.Unique, Is.True); | ||
| Assert.That(ex.SqlState, Is.EqualTo("23505")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gibt es hierfür keine Konstanten?
| var ex = Assert.Throws<PostgresException>(() => Provider.Insert(tableName, [columnName, columnName2], [100, "Hello"])); | ||
|
|
||
| Assert.That(index.Unique, Is.True); | ||
| Assert.That(ex.SqlState, Is.EqualTo("23505")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hier wird derselbe wert nochmal verwendet. Keine Magic Strings?
| var index = Provider.GetIndexes(tableName).Single(); | ||
|
|
||
| Assert.That(index.Unique, Is.True); | ||
| Assert.That(sqlException.Number, Is.EqualTo(2601)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Konstante?
| var index = Provider.GetIndexes(tableName).Single(); | ||
|
|
||
| Assert.That(index.Unique, Is.True); | ||
| Assert.That(sqlException.Number, Is.EqualTo(2601)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Konstante?
| return from DataRow row in tables.Rows select (row["TABLE_NAME"] as string); | ||
| } | ||
|
|
||
| protected void ValidateIndex(string tableName, Index index) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wäre der Name ValidateIndexBeforeAdding() besser?
Fixes #122
Fixes #123
Fixes #124
Fixes #125
Fixes #126