Skip to content

Conversation

@JaBistDuNarrisch
Copy link

Fixes #122
Fixes #123
Fixes #124
Fixes #125
Fixes #126

@JaBistDuNarrisch JaBistDuNarrisch self-assigned this Aug 27, 2025
@JaBistDuNarrisch JaBistDuNarrisch merged commit 6709f7f into master Aug 28, 2025
1 check passed
@JaBistDuNarrisch JaBistDuNarrisch deleted the functional-expressions branch August 28, 2025 12:32
var index = indexes.Single();

Assert.That(index.Unique, Is.True);
Assert.That(ex.SqlState, Is.EqualTo("23505"));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gibt es hierfür keine Konstanten?

var ex = Assert.Throws<PostgresException>(() => Provider.Insert(tableName, [columnName, columnName2], [100, "Hello"]));

Assert.That(index.Unique, Is.True);
Assert.That(ex.SqlState, Is.EqualTo("23505"));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hier wird derselbe wert nochmal verwendet. Keine Magic Strings?

var index = Provider.GetIndexes(tableName).Single();

Assert.That(index.Unique, Is.True);
Assert.That(sqlException.Number, Is.EqualTo(2601));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Konstante?

var index = Provider.GetIndexes(tableName).Single();

Assert.That(index.Unique, Is.True);
Assert.That(sqlException.Number, Is.EqualTo(2601));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Konstante?

return from DataRow row in tables.Rows select (row["TABLE_NAME"] as string);
}

protected void ValidateIndex(string tableName, Index index)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wäre der Name ValidateIndexBeforeAdding() besser?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants