override some AddColumn methods in SQLite

Author: JaBistDuNarrisch

src/Migrator.Tests/Providers/Generic/TransformationProviderGenericMiscConstraintBase.cs

@@ -3,7 +3,6 @@
 using System.Linq;
 using DotNetProjects.Migrator.Framework;
 using DotNetProjects.Migrator.Providers.Impl.SQLite;
-using DryIoc;
 using NUnit.Framework;
 
 namespace Migrator.Tests.Providers.Generic;
@@ -35,7 +34,7 @@ public void AddMultipleUniqueConstraint()
         Provider.AddUniqueConstraint("UN_Test_TestTwo", "TestTwo", "Id", "TestId");
     }
 
-    public void AddCheckConstraint()
+    public void AddTestCheckConstraint()
     {
         Provider.AddCheckConstraint("CK_TestTwo_TestId", "TestTwo", "TestId>5");
     }
@@ -91,8 +90,10 @@ public virtual void CanAddMultipleUniqueConstraint()
     [Test]
     public virtual void CanAddCheckConstraint()
     {
-        AddCheckConstraint();
-        Assert.That(Provider.ConstraintExists("TestTwo", "CK_TestTwo_TestId"), Is.True);
+        AddTestCheckConstraint();
+        var constraintExists = Provider.ConstraintExists("TestTwo", "CK_TestTwo_TestId");
+
+        Assert.That(constraintExists, Is.True);
     }
 
     [Test]
@@ -115,7 +116,7 @@ public void RemoveUniqueConstraint()
     [Test]
     public virtual void RemoveCheckConstraint()
     {
-        AddCheckConstraint();
+        AddTestCheckConstraint();
         Provider.RemoveConstraint("TestTwo", "CK_TestTwo_TestId");
         Assert.That(Provider.ConstraintExists("TestTwo", "CK_TestTwo_TestId"), Is.False);
     }

src/Migrator/Providers/Impl/SQLite/SQLiteTransformationProvider.cs

@@ -751,6 +751,7 @@ public void RecreateTable(SQLiteTableInfo sqliteTableInfo)
 
         var dbFields = columnDbFields.Concat(foreignKeyDbFields)
             .Concat(uniqueDbFields)
+            .Concat(checkConstraintDbFields)
             .ToArray();
 
         // ToHashSet() not available in older .NET versions so we create it old-fashioned.
@@ -811,6 +812,12 @@ public void RecreateTable(SQLiteTableInfo sqliteTableInfo)
         }
     }
 
+    [Obsolete]
+    public override void AddTable(string table, string engine, string columns)
+    {
+        throw new NotSupportedException();
+    }
+
     public override void AddColumn(string table, Column column)
     {
         if (!TableExists(table))
@@ -819,6 +826,7 @@ public override void AddColumn(string table, Column column)
         }
 
         var sqliteInfo = GetSQLiteTableInfo(table);
+
         if (sqliteInfo.ColumnMappings.Select(x => x.OldName).ToList().Contains(column.Name))
         {
             throw new Exception("Column already exists.");
@@ -830,6 +838,61 @@ public override void AddColumn(string table, Column column)
         RecreateTable(sqliteInfo);
     }
 
+    public override void AddColumn(string table, string columnName, DbType type, ColumnProperty property)
+    {
+        var column = new Column(columnName, type, property);
+
+        AddColumn(table, column);
+    }
+
+    public override void AddColumn(string table, string columnName, MigratorDbType type, ColumnProperty property)
+    {
+        var column = new Column(columnName, type, property);
+
+        AddColumn(table, column);
+    }
+
+    public override void AddColumn(string table, string columnName, DbType type)
+    {
+        var column = new Column(columnName, type);
+
+        AddColumn(table, column);
+    }
+
+    public override void AddColumn(string table, string columnName, MigratorDbType type)
+    {
+        var column = new Column(columnName, type);
+
+        AddColumn(table, column);
+    }
+
+    public override void AddColumn(string table, string columnName, DbType type, int size, ColumnProperty property)
+    {
+        var column = new Column(columnName, type, size, property);
+
+        AddColumn(table, column);
+    }
+
+    public override void AddColumn(string table, string columnName, MigratorDbType type, int size, ColumnProperty property)
+    {
+        var column = new Column(columnName, type, size, property);
+
+        AddColumn(table, column);
+    }
+
+    public override void AddColumn(string table, string columnName, DbType type, object defaultValue)
+    {
+        var column = new Column(columnName, type, defaultValue);
+
+        AddColumn(table, column);
+    }
+
+    public override void AddColumn(string table, string sqlColumn)
+    {
+        var column = new Column(sqlColumn);
+        AddColumn(table, column);
+    }
+
     public override void ChangeColumn(string table, Column column)
     {
         if (!TableExists(table))
@@ -910,9 +973,12 @@ public override string[] GetConstraints(string table)
             .Select(x => x.Name)
             .ToList();
 
-        // TODO add PK and CHECK
+        var checkConstraints = sqliteInfo.CheckConstraints
+            .Select(x => x.Name)
+            .ToList();
 
         var names = foreignKeyNames.Concat(uniqueConstraints)
+            .Concat(checkConstraints)
             .Where(x => !string.IsNullOrWhiteSpace(x))
             .ToArray();
 
@@ -1471,6 +1537,16 @@ public List<PragmaTableInfoItem> GetPragmaTableInfoItems(string tableNameNotQuot
         return pragmaTableInfoItems;
     }
 
+    public override void AddCheckConstraint(string constraintName, string tableName, string checkSql)
+    {
+        var sqliteTableInfo = GetSQLiteTableInfo(tableName);
+
+        var checkConstraint = new CheckConstraint(constraintName, checkSql);
+        sqliteTableInfo.CheckConstraints.Add(checkConstraint);
+
+        RecreateTable(sqliteTableInfo);
+    }
+
     public List<CheckConstraint> GetCheckConstraints(string tableName)
     {
         if (!TableExists(tableName))

src/Migrator/Providers/TransformationProvider.cs

@@ -425,6 +425,7 @@ public virtual void AddTable(string name, string engine, params IDbField[] field
         var compoundPrimaryKey = pks.Count > 1;
 
         var columnProviders = new List<ColumnPropertiesMapper>(columns.Count());
+
         foreach (var column in columns)
         {
             // Remove the primary key notation if compound primary key because we'll add it back later
@@ -447,15 +448,17 @@ public virtual void AddTable(string name, string engine, params IDbField[] field
         }
 
         var indexes = fields.Where(x => x is Index).Cast<Index>().ToArray();
+
         foreach (var index in indexes)
         {
             AddIndex(name, index);
         }
 
         var foreignKeys = fields.Where(x => x is ForeignKeyConstraint).Cast<ForeignKeyConstraint>().ToArray();
+
         foreach (var foreignKey in foreignKeys)
         {
-            this.AddForeignKey(name, foreignKey);
+            AddForeignKey(name, foreignKey);
         }
     }
 
@@ -647,7 +650,7 @@ public virtual void AddColumn(string table, string column, MigratorDbType type,
     /// AddColumn(string, string, Type, int, ColumnProperty, object)
     /// </see>
     /// </summary>
-    public void AddColumn(string table, string column, DbType type)
+    public virtual void AddColumn(string table, string column, DbType type)
     {
         AddColumn(table, column, type, 0, ColumnProperty.Null, null);
     }