Use ArgumentNullException.ThrowIfNull in PresentationCore (#8126)

* CA1510

* manual changes

Author: halgab

src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/Automation/InteropAutomationProvider.cs

@@ -20,14 +20,8 @@ internal class InteropAutomationProvider: IRawElementProviderFragmentRoot
 
         internal InteropAutomationProvider(HostedWindowWrapper wrapper, AutomationPeer parent)
         {
-            if (wrapper == null)
-            {
-                throw new ArgumentNullException("wrapper");
-            }
-            if (parent == null)
-            {
-                throw new ArgumentNullException("parent");
-            }
+            ArgumentNullException.ThrowIfNull(wrapper);
+            ArgumentNullException.ThrowIfNull(parent);
 
             _wrapper = wrapper;
             _parent = parent;

src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/FontCache/FontFaceLayoutInfo.cs

@@ -727,10 +727,7 @@ public bool Contains(KeyValuePair<int, ushort> item)
 
             public void CopyTo(KeyValuePair<int, ushort>[] array, int arrayIndex)
             {
-                if (array == null)
-                {
-                    throw new ArgumentNullException("array");
-                }
+                ArgumentNullException.ThrowIfNull(array);
 
                 if (array.Rank != 1)
                 {

src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/FontFace/CompositeFontInfo.cs

@@ -57,8 +57,7 @@ internal CompositeFontInfo()
         internal void PrepareToAddFamilyMap(FontFamilyMap familyMap)
         {
             // Validate parameters.
-            if (familyMap == null)
-                throw new ArgumentNullException("familyMap");
+            ArgumentNullException.ThrowIfNull(familyMap);
 
             if (string.IsNullOrEmpty(familyMap.Target))
                 throw new ArgumentException(SR.FamilyMap_TargetNotSet);

src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/FontFace/TypefaceCollection.cs

@@ -69,10 +69,7 @@ public bool Contains(Typeface item)
 
         public void CopyTo(Typeface[] array, int arrayIndex)
         {
-            if (array == null)
-            {
-                throw new ArgumentNullException("array");
-            }
+            ArgumentNullException.ThrowIfNull(array);
 
             if (array.Rank != 1)
             {

src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/IO/Packaging/ByteRangeDownloader.cs

@@ -56,10 +56,7 @@ internal class ByteRangeDownloader : IDisposable
         internal ByteRangeDownloader(Uri requestedUri, string tempFileName, SafeWaitHandle eventHandle)
             : this(requestedUri, eventHandle)
         {
-            if (tempFileName == null)
-            {
-                throw new ArgumentNullException("tempFileName");
-            }
+            ArgumentNullException.ThrowIfNull(tempFileName);
 
             if (tempFileName.Length <= 0)
             {
@@ -186,10 +183,7 @@ internal void RequestByteRanges(int[,] byteRanges)
             // The worker thread will never call dispose nor this method; no need to lock
             CheckDisposed();
 
-            if (byteRanges == null)
-            {
-                throw new ArgumentNullException("byteRanges");
-            }
+            ArgumentNullException.ThrowIfNull(byteRanges);
 
             CheckTwoDimensionalByteRanges(byteRanges);
 
@@ -303,10 +297,7 @@ internal IWebProxy Proxy
             set
             {
                 CheckDisposed();
-                if (value == null)
-                {
-                    throw new ArgumentNullException("value");
-                }
+                ArgumentNullException.ThrowIfNull(value);
 
                 if (!_firstRequestMade)
                 {
@@ -411,21 +402,15 @@ private void CheckDisposed()
         /// </summary>
         private ByteRangeDownloader(Uri requestedUri, SafeWaitHandle eventHandle)
         {
-            if (requestedUri == null)
-            {
-                throw new ArgumentNullException("requestedUri");
-            }
+            ArgumentNullException.ThrowIfNull(requestedUri);
 
             // Ensure uri is correct scheme (http or https) Do case-sensitive comparison since Uri.Scheme contract is to return in lower case only.
             if (!string.Equals(requestedUri.Scheme, Uri.UriSchemeHttp, StringComparison.Ordinal) && !string.Equals(requestedUri.Scheme, Uri.UriSchemeHttps, StringComparison.Ordinal))
             {
                 throw new ArgumentException(SR.InvalidScheme, "requestedUri");
             }
 
-            if (eventHandle == null)
-            {
-                throw new ArgumentNullException("eventHandle");
-            }
+            ArgumentNullException.ThrowIfNull(eventHandle);
 
             if (eventHandle.IsInvalid || eventHandle.IsClosed)
             {

src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/IO/Packaging/DeobfuscatingStream.cs

@@ -196,10 +196,7 @@ public override bool CanWrite
         /// <remarks>streamUri has to be a pack Uri</remarks>
         internal DeobfuscatingStream(Stream obfuscatedStream, Uri streamUri, bool leaveOpen)
         {
-            if (obfuscatedStream == null)
-            {
-                throw new ArgumentNullException("obfuscatedStream");
-            }
+            ArgumentNullException.ThrowIfNull(obfuscatedStream);
 
             // Make sure streamUri is in the correct form; getting partUri from it will do all necessary checks for error
             //    conditions; We also have to make sure that it has a part name

src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/IO/Packaging/PreloadedPackages.cs

@@ -160,10 +160,7 @@ internal static void Clear()
 
         private static void ValidateUriKey(Uri uri)
         {
-            if (uri == null)
-            {
-                throw new ArgumentNullException("uri");
-            }
+            ArgumentNullException.ThrowIfNull(uri);
 
             if (!uri.IsAbsoluteUri)
             {

src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/IO/Packaging/PseudoWebRequest.cs

@@ -201,8 +201,7 @@ public override WebHeaderCollection Headers
             }
             set
             {
-                if (value == null)
-                   throw new ArgumentNullException("value");
+                ArgumentNullException.ThrowIfNull(value);
 
                 _headers = value;
             }
@@ -222,8 +221,7 @@ public override string Method
             }
             set
             {
-                if (value == null)
-                    throw new ArgumentNullException("value");
+                ArgumentNullException.ThrowIfNull(value);
 
                 _method = value;
             }

src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/Ink/ExtendedProperty.cs

@@ -163,10 +163,7 @@ internal object Value
             }
             set
             {
-                if (value == null)
-                {
-                    throw new ArgumentNullException("value");
-                }
+                ArgumentNullException.ThrowIfNull(value);
 
                 // validate the type information for the id against the id
                 ExtendedPropertySerializer.Validate(_id, value);

src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/Ink/ExtendedPropertyCollection.cs

@@ -247,10 +247,7 @@ internal object this[Guid attributeId]
             }
             set
             {
-                if (value == null)
-                {
-                    throw new ArgumentNullException("value");
-                }
+                ArgumentNullException.ThrowIfNull(value);
                 for (int i = 0; i < _extendedProperties.Count; i++)
                 {
                     ExtendedProperty currentProperty = _extendedProperties[i];