Enabling ScrollPattern only when Combobox dropDown is opened

arpitmathur · arpitmathur · commit 18a5cf3a2bad · 2019-07-23T15:19:40.000-07:00
diff --git a/src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Automation/Peers/ComboBoxAutomationPeer.cs b/src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Automation/Peers/ComboBoxAutomationPeer.cs
@@ -51,16 +51,20 @@ override protected string GetClassNameCore()
         override public object GetPattern(PatternInterface pattern)
         {
             object iface = null;
+            ComboBox owner = (ComboBox)Owner;
 
             if (pattern == PatternInterface.Value)
             {
-                ComboBox owner = (ComboBox)Owner;
                 if (owner.IsEditable) iface = this;
             }
             else if(pattern == PatternInterface.ExpandCollapse)
             {
                 iface = this;
             }
+            else if (pattern == PatternInterface.Scroll)
+            {
+                if (owner.IsDropDownOpen) iface = this;
+            }
             else
             {
                 iface = base.GetPattern(pattern);

Original file line number	Diff line number	Diff line change
`@@ -51,16 +51,20 @@ override protected string GetClassNameCore()`
`51`	`51`	`override public object GetPattern(PatternInterface pattern)`
`52`	`52`	`{`
`53`	`53`	`object iface = null;`
	`54`	`+ ComboBox owner = (ComboBox)Owner;`
`54`	`55`
`55`	`56`	`if (pattern == PatternInterface.Value)`
`56`	`57`	`{`
`57`		`- ComboBox owner = (ComboBox)Owner;`
`58`	`58`	`if (owner.IsEditable) iface = this;`
`59`	`59`	`}`
`60`	`60`	`else if(pattern == PatternInterface.ExpandCollapse)`
`61`	`61`	`{`
`62`	`62`	`iface = this;`
`63`	`63`	`}`
	`64`	`+ else if (pattern == PatternInterface.Scroll)`
	`65`	`+ {`
	`66`	`+ if (owner.IsDropDownOpen) iface = this;`
	`67`	`+ }`
`64`	`68`	`else`
`65`	`69`	`{`
`66`	`70`	`iface = base.GetPattern(pattern);`