Skip to content

Conversation

benrr101
Copy link
Contributor

This is a replacement of #3042 that will give us the complete CI

Description: After some discussion with @saurabh500 we came to the conclusion that it's just not beneficial to have the ReliabilitySection code in the netfx project. It is only included in debug builds (which we don't even use for CI builds anyhow), and it makes massive clutter in the code base. Although I've experimented with some ideas to leave it in place but cleanup the code, simply removing it is probably the easiest solution.

Testing: Project still builds without it and since it provides no functionality, it won't break anything to remove it.

@paulmedynski and @mdaigle, y'all already approved this one before :)

@benrr101 benrr101 added Code Health 💊 Issues/PRs that are targeted to source code quality improvements. Common Project 🚮 Things that relate to the common project project labels Feb 19, 2025
@benrr101 benrr101 added this to the 7.0-preview1 milestone Feb 19, 2025
@benrr101 benrr101 requested review from mdaigle, paulmedynski and a team February 19, 2025 19:46
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 62.46305% with 381 lines in your changes missing coverage. Please review.

Project coverage is 72.73%. Comparing base (17cb0b0) to head (3d3ada8).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...core/src/Microsoft/Data/SqlClient/SqlDataReader.cs 56.84% 123 Missing ⚠️
...etfx/src/Microsoft/Data/SqlClient/SqlDataReader.cs 57.04% 122 Missing ⚠️
...t/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs 62.10% 83 Missing ⚠️
...icrosoft/Data/SqlClient/SqlDelegatedTransaction.cs 61.01% 23 Missing ⚠️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 43.75% 18 Missing ⚠️
...etfx/src/Microsoft/Data/SqlClient/SqlConnection.cs 74.28% 9 Missing ⚠️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 91.66% 2 Missing ⚠️
...fx/src/Microsoft/Data/SqlClient/TdsParser.netfx.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3164      +/-   ##
==========================================
- Coverage   72.96%   72.73%   -0.24%     
==========================================
  Files         283      285       +2     
  Lines       58997    59192     +195     
==========================================
+ Hits        43048    43054       +6     
- Misses      15949    16138     +189     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.51% <60.43%> (-0.22%) ⬇️
netfx 71.12% <64.65%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benrr101 benrr101 merged commit 083ae33 into main Feb 20, 2025
252 checks passed
@benrr101 benrr101 deleted the dev/russellben/merge/reliabilitysection-delete branch February 20, 2025 21:03
This was referenced Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Health 💊 Issues/PRs that are targeted to source code quality improvements. Common Project 🚮 Things that relate to the common project project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants