-
Notifications
You must be signed in to change notification settings - Fork 315
Cleanup/Merge | Remove Reliability Section #3164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
benrr101
merged 3 commits into
main
from
dev/russellben/merge/reliabilitysection-delete
Feb 20, 2025
Merged
Cleanup/Merge | Remove Reliability Section #3164
benrr101
merged 3 commits into
main
from
dev/russellben/merge/reliabilitysection-delete
Feb 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdaigle
approved these changes
Feb 19, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3164 +/- ##
==========================================
- Coverage 72.96% 72.73% -0.24%
==========================================
Files 283 285 +2
Lines 58997 59192 +195
==========================================
+ Hits 43048 43054 +6
- Misses 15949 16138 +189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
paulmedynski
approved these changes
Feb 20, 2025
This was referenced Jul 25, 2025
Open
This was referenced Aug 26, 2025
Merged
This was referenced Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code Health 💊
Issues/PRs that are targeted to source code quality improvements.
Common Project 🚮
Things that relate to the common project project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement of #3042 that will give us the complete CI
Description: After some discussion with @saurabh500 we came to the conclusion that it's just not beneficial to have the ReliabilitySection code in the netfx project. It is only included in debug builds (which we don't even use for CI builds anyhow), and it makes massive clutter in the code base. Although I've experimented with some ideas to leave it in place but cleanup the code, simply removing it is probably the easiest solution.
Testing: Project still builds without it and since it provides no functionality, it won't break anything to remove it.
@paulmedynski and @mdaigle, y'all already approved this one before :)