Skip to content

Conversation

@MichaelSimons
Copy link
Member

Update Newtonsoft 13.0.1 referenced to 13.0.3 to prevent online only prebuilts. This is fallout from dotnet/source-build-externals#195.

@MichaelSimons
Copy link
Member Author

FYI, in 9.0 we now have a check to fail online builds if they have prebuilts. This would have caught this.

@ViktorHofer
Copy link
Member

The failure says there's still a Newtonsoft.Json/13.0.1 in the dependency graph. Do you need help with identifying the project that brings it in? The project.assets.json file should tell.

@MichaelSimons
Copy link
Member Author

The failure says there's still a Newtonsoft.Json/13.0.1 in the dependency graph. Do you need help with identifying the project that brings it in? The project.assets.json file should tell.

This is a nuget restore source issue in online builds, not a problem with the actual SBRP packages. This wouldn't be an issue if we have proper project dependencies and no n-1 SBRP packages around.

@MichaelSimons MichaelSimons merged commit fa4c0e8 into dotnet:release/8.0 Nov 6, 2023
@MichaelSimons MichaelSimons deleted the update-newtonsoft branch November 6, 2023 15:00
@MichaelSimons
Copy link
Member Author

/backport to main

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants