Skip to content

Commit 96dceea

Browse files
authored
Updates to PR template (#455)
1 parent 8e273fd commit 96dceea

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

.github/pull_request_template.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
## Description
22

3+
<Insert description of your changes>
4+
35
## PR Checklist
46

57
If you are upgrading the version of a repo submodule, please follow this
@@ -8,12 +10,22 @@ checklist:
810
- [ ] Provide a link to an issue in the consuming repo describing the need for
911
the upgrade. Both this PR and the PR doing the upgrade in the consuming repo
1012
should link to that issue.
13+
- [ ] Are you targeting the correct branch? For example, if you need to
14+
reference this version in 9.0, you should target the 9.0 branch.
1115
- [ ] Have you done your due diligence to ensure the upgrade can be completed
1216
in the consuming repo in a timely manner? If consuming the dependency flow of
1317
this update takes a long time or needs to be backed out, it may require the
1418
reversion of the upgrade in this PR. That's something we want to avoid.
19+
20+
## After Merge
21+
22+
- [ ] Once the package gets published via darc, you may need to manually trigger
23+
the darc subscription on the configuration from the consuming repo. Subscriptions
24+
for release branches, for example, are typically disabled.
1525
- [ ] When consuming the dependency flow from this repo for the purposes of a
1626
version upgrade, consider using a separate PR or at least changing the title of
1727
the dependency flow PR to accurately reflect the purpose of the change. Seeing
1828
a PR named "Upgrade IdentityModel to 8.0.1", for example, provides better
1929
clarity than "Update dependencies from dotnet/source-build-externals".
30+
- [ ] If this PR targeted a release branch, port the changes to higher release
31+
and main branches.

0 commit comments

Comments
 (0)