From 1c7a92d66d3bd8f3da1e50cd2d65bba933d74037 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Tue, 4 Feb 2025 23:40:55 +0100 Subject: [PATCH 1/3] Create dependencies for aspnetcore template packages. This is necessary so that dependency flow inside the VMR (product build and source-build) and correctly upgrade the version to the live one. Also group all aspnetcore dependencies together in the Version.Details.xml file. --- eng/Version.Details.xml | 64 +++++++++++-------- eng/Versions.props | 10 +-- .../targets/BundledTemplates.targets | 8 +-- 3 files changed, 43 insertions(+), 39 deletions(-) diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index 1cb6fc9cf532..acf210ea1b3b 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -139,14 +139,6 @@ https://github.com/dotnet/roslyn 6908aead3a8b313798c381d5e435e9e6068301a7 - - https://github.com/dotnet/aspnetcore - febd7e8bdf05f17fb4e0e4dd3123e9538fbf7e7b - - - https://github.com/dotnet/aspnetcore - febd7e8bdf05f17fb4e0e4dd3123e9538fbf7e7b - https://github.com/nuget/nuget.client a4a2e3f31ddc2adb52ebd3204ea6f650d89caf3f @@ -364,6 +356,42 @@ https://github.com/dotnet/aspnetcore febd7e8bdf05f17fb4e0e4dd3123e9538fbf7e7b + + https://github.com/dotnet/aspnetcore + febd7e8bdf05f17fb4e0e4dd3123e9538fbf7e7b + + + https://github.com/dotnet/aspnetcore + febd7e8bdf05f17fb4e0e4dd3123e9538fbf7e7b + + + https://github.com/dotnet/aspnetcore + febd7e8bdf05f17fb4e0e4dd3123e9538fbf7e7b + + + https://github.com/dotnet/aspnetcore + febd7e8bdf05f17fb4e0e4dd3123e9538fbf7e7b + + + https://github.com/dotnet/aspnetcore + febd7e8bdf05f17fb4e0e4dd3123e9538fbf7e7b + + + https://github.com/dotnet/aspnetcore + febd7e8bdf05f17fb4e0e4dd3123e9538fbf7e7b + + + https://github.com/dotnet/aspnetcore + febd7e8bdf05f17fb4e0e4dd3123e9538fbf7e7b + + + https://github.com/dotnet/aspnetcore + febd7e8bdf05f17fb4e0e4dd3123e9538fbf7e7b + + + https://github.com/dotnet/aspnetcore + febd7e8bdf05f17fb4e0e4dd3123e9538fbf7e7b + https://github.com/dotnet/aspnetcore @@ -388,22 +416,6 @@ b10bc23eb5ee2203c38584e9838f9a6f486b699b - - https://github.com/dotnet/aspnetcore - febd7e8bdf05f17fb4e0e4dd3123e9538fbf7e7b - - - https://github.com/dotnet/aspnetcore - febd7e8bdf05f17fb4e0e4dd3123e9538fbf7e7b - - - https://github.com/dotnet/aspnetcore - febd7e8bdf05f17fb4e0e4dd3123e9538fbf7e7b - - - https://github.com/dotnet/aspnetcore - febd7e8bdf05f17fb4e0e4dd3123e9538fbf7e7b - https://github.com/dotnet/winforms @@ -554,10 +566,6 @@ https://github.com/dotnet/runtime 219622a23cef3dde6a08378ac9829cb2b242cead - - https://github.com/dotnet/aspnetcore - febd7e8bdf05f17fb4e0e4dd3123e9538fbf7e7b - https://github.com/dotnet/runtime 219622a23cef3dde6a08378ac9829cb2b242cead diff --git a/eng/Versions.props b/eng/Versions.props index a186debcacd8..f18413a158b9 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -83,7 +83,7 @@ - 10.0.0-preview.2.25081.2 + 10.0.0-preview.2.25081.2 @@ -237,6 +237,8 @@ 10.0.0-alpha.2.25073.4 10.0.0-alpha.2.25073.4 10.0.0-alpha.2.25073.4 + 10.0.0-alpha.2.25073.4 + 10.0.0-alpha.2.25073.4 10.0.0-alpha.2.25073.4 10.0.0-alpha.2.25073.4 10.0.0-alpha.2.25073.4 @@ -253,12 +255,6 @@ 10.0.0-preview.2.25103.1 10.0.0-preview.2.25103.1 - - - $(MicrosoftAspNetCoreAppRuntimewinx64PackageVersion) - $(MicrosoftDotnetWinFormsProjectTemplatesPackageVersion) - $(MicrosoftDotNetWpfProjectTemplatesPackageVersion) - 2.2.0-beta.19072.10 10.0.0-preview.24602.1 diff --git a/src/Installer/redist-installer/targets/BundledTemplates.targets b/src/Installer/redist-installer/targets/BundledTemplates.targets index 281018be6211..e7a1f834b782 100644 --- a/src/Installer/redist-installer/targets/BundledTemplates.targets +++ b/src/Installer/redist-installer/targets/BundledTemplates.targets @@ -20,10 +20,10 @@ - - - - + + + + From 6c498623e5d813294b006f0adb54e086b1d58522 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Tue, 4 Feb 2025 23:43:09 +0100 Subject: [PATCH 2/3] Update .NET 10.0 templates definitions --- src/Installer/redist-installer/targets/BundledTemplates.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Installer/redist-installer/targets/BundledTemplates.targets b/src/Installer/redist-installer/targets/BundledTemplates.targets index e7a1f834b782..f81a3b9e5e85 100644 --- a/src/Installer/redist-installer/targets/BundledTemplates.targets +++ b/src/Installer/redist-installer/targets/BundledTemplates.targets @@ -22,7 +22,7 @@ - + From acced5af32786b3528d744842ed2366191d4230d Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Wed, 5 Feb 2025 12:55:34 +0100 Subject: [PATCH 3/3] added wpf patches --- ...ral-packages-when-building-inside-th.patch | 30 +++++++++++++++++++ ...the-ArtifactsPackagingDir-on-win-x64.patch | 24 +++++++++++++++ 2 files changed, 54 insertions(+) create mode 100644 src/SourceBuild/patches/wpf/0001-Create-arch-neutral-packages-when-building-inside-th.patch create mode 100644 src/SourceBuild/patches/wpf/0004-Fix-the-ArtifactsPackagingDir-on-win-x64.patch diff --git a/src/SourceBuild/patches/wpf/0001-Create-arch-neutral-packages-when-building-inside-th.patch b/src/SourceBuild/patches/wpf/0001-Create-arch-neutral-packages-when-building-inside-th.patch new file mode 100644 index 000000000000..a75419dc9254 --- /dev/null +++ b/src/SourceBuild/patches/wpf/0001-Create-arch-neutral-packages-when-building-inside-th.patch @@ -0,0 +1,30 @@ +From 2c9670d56a70dc78cad3f94cd815fc75638fd034 Mon Sep 17 00:00:00 2001 +From: Viktor Hofer +Date: Tue, 4 Feb 2025 23:47:43 +0100 +Subject: [PATCH] Create arch neutral packages when building inside the VMR + (#10405) + +Backport: https://github.com/dotnet/wpf/pull/10405 + +--- + packaging/Directory.Build.props | 5 +++-- + 1 file changed, 3 insertions(+), 2 deletions(-) + +diff --git a/packaging/Directory.Build.props b/packaging/Directory.Build.props +index a1f50ce3d..15516fade 100644 +--- a/packaging/Directory.Build.props ++++ b/packaging/Directory.Build.props +@@ -16,10 +16,11 @@ + Set $(IsPackable) = true, except when + $(CreateArchNeutralPackage) == true && $(Platform) != x86 + The idea here is that for arch-neutral packages, only the x86 build phase will generate the nuget package +- The platform/RID specific packages will be generated in their respective $(Platform) specific build phases ++ The platform/RID specific packages will be generated in their respective $(Platform) specific build phases. ++ Platform neutral packages should always get generated when building the product (DotNetBuild=true). + --> + true +- false ++ false + + + diff --git a/src/SourceBuild/patches/wpf/0004-Fix-the-ArtifactsPackagingDir-on-win-x64.patch b/src/SourceBuild/patches/wpf/0004-Fix-the-ArtifactsPackagingDir-on-win-x64.patch new file mode 100644 index 000000000000..dfeb06cabb2b --- /dev/null +++ b/src/SourceBuild/patches/wpf/0004-Fix-the-ArtifactsPackagingDir-on-win-x64.patch @@ -0,0 +1,24 @@ +From 5d5f1c9eff148801ac0116c5b33d3b1608340d30 Mon Sep 17 00:00:00 2001 +From: Viktor Hofer +Date: Wed, 5 Feb 2025 12:44:01 +0100 +Subject: [PATCH 4/4] Fix the ArtifactsPackagingDir on win-x64 + +Backport: https://github.com/dotnet/wpf/pull/10411 + +--- + eng/WpfArcadeSdk/tools/Packaging.props | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/eng/WpfArcadeSdk/tools/Packaging.props b/eng/WpfArcadeSdk/tools/Packaging.props +index ad1383c18..b052f0484 100644 +--- a/eng/WpfArcadeSdk/tools/Packaging.props ++++ b/eng/WpfArcadeSdk/tools/Packaging.props +@@ -1,7 +1,6 @@ + + +- $(ArtifactsDir)packaging\$(Configuration)\$(Platform)\ +- $(ArtifactsDir)packaging\$(Configuration)\ ++ $(ArtifactsDir)packaging\$(Configuration)\ + + + runtime.win-$(Platform)