diff --git a/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.Analyzers.targets b/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.Analyzers.targets
index adb582018346..bfe44a366470 100644
--- a/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.Analyzers.targets
+++ b/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.Analyzers.targets
@@ -62,7 +62,7 @@ Copyright (c) .NET Foundation. All rights reserved.
4
- $(_TargetFrameworkVersionWithoutV.Substring(0, 1))
+ $(_TargetFrameworkVersionWithoutV.Split('.')[0])
diff --git a/test/Microsoft.NET.Build.Tests/GivenThatWeWantToFloatWarningLevels.cs b/test/Microsoft.NET.Build.Tests/GivenThatWeWantToFloatWarningLevels.cs
index fafc1185848a..9ce49dbf12ed 100644
--- a/test/Microsoft.NET.Build.Tests/GivenThatWeWantToFloatWarningLevels.cs
+++ b/test/Microsoft.NET.Build.Tests/GivenThatWeWantToFloatWarningLevels.cs
@@ -13,7 +13,7 @@ public GivenThatWeWantToFloatWarningLevels(ITestOutputHelper log) : base(log)
}
[InlineData(targetFrameworkNet6, "6")]
- [InlineData(ToolsetInfo.CurrentTargetFramework, "1")]
+ [InlineData(ToolsetInfo.CurrentTargetFramework, ToolsetInfo.CurrentTargetFrameworkVersion)]
[InlineData(targetFrameworkNetFramework472, "4")]
[RequiresMSBuildVersionTheory("16.8")]
public void It_defaults_WarningLevel_To_The_Current_TFM_When_Net(string tfm, string warningLevel)
@@ -59,7 +59,7 @@ static void Main()
}
[InlineData(1, "1")]
- [InlineData(null, "1")]
+ [InlineData(null, ToolsetInfo.CurrentTargetFrameworkVersion)]
[RequiresMSBuildVersionTheory("16.8")]
public void It_always_accepts_user_defined_WarningLevel(int? warningLevel, string expectedWarningLevel)
{
@@ -156,8 +156,11 @@ static void Main()
buildResult.StdErr.Should().Be(string.Empty);
}
- [InlineData(ToolsetInfo.CurrentTargetFramework, ToolsetInfo.CurrentTargetFrameworkVersion)]
- [RequiresMSBuildVersionTheory("16.8")]
+ [InlineData(ToolsetInfo.CurrentTargetFramework, ToolsetInfo.NextTargetFrameworkVersion)]
+ // Fixing this test requires bumping _LatestAnalysisLevel and _PreviewAnalysisLevel
+ // Bumping will cause It_maps_analysis_properties_to_globalconfig to fail which requires changes in dotnet/roslyn-analyzers repo.
+ // See instructions in the comment in It_maps_analysis_properties_to_globalconfig
+ [RequiresMSBuildVersionTheory("16.8", Skip = "https://github.com/dotnet/sdk/issues/45299")]
public void It_defaults_preview_AnalysisLevel_to_the_next_tfm(string currentTFM, string nextTFMVersionNumber)
{
var testProject = new TestProject
diff --git a/test/Microsoft.NET.Build.Tests/GivenThatWeWantToUseBinaryFormatter.cs b/test/Microsoft.NET.Build.Tests/GivenThatWeWantToUseBinaryFormatter.cs
index 98029672102a..69b6423f0a0f 100644
--- a/test/Microsoft.NET.Build.Tests/GivenThatWeWantToUseBinaryFormatter.cs
+++ b/test/Microsoft.NET.Build.Tests/GivenThatWeWantToUseBinaryFormatter.cs
@@ -133,6 +133,7 @@ public void It_warns_when_targeting_certain_frameworks_and_not_using_pragma_supp
[Theory]
[InlineData("net9.0")]
+ [InlineData(ToolsetInfo.CurrentTargetFramework)]
public void It_errors_when_targeting_certain_frameworks_and_not_using_pragma_suppressions(string targetFramework)
{
var testProject = new TestProject()
@@ -159,6 +160,7 @@ public void It_errors_when_targeting_certain_frameworks_and_not_using_pragma_sup
[Theory]
[InlineData("net9.0")]
+ [InlineData(ToolsetInfo.CurrentTargetFramework)]
public void It_allows_downgrading_errors_to_warnings_via_project_config(string targetFramework)
{
var testProject = new TestProject()