[VMR] Add verticals for Linux/Windows NativeAOT runtime packs #45154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Member
Author
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ViktorHofer
reviewed
Nov 26, 2024
Member
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
Does https://github.com/dotnet/runtime/blob/abee17762558f6b4435163fe192c92b9caefde40/eng/DotNetBuild.props#L37 also need to be updated?
Open
3 tasks
Member
Author
|
@ViktorHofer yeah but it doesn't really affect the NativeAOT build. We just build a bit more because we pass the -allconfigurations flag |
Member
Author
|
Failures are unrelated |
ViktorHofer
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#4760