From 3b6748c8c225c9cbd95cad48094ed0e31e2625f4 Mon Sep 17 00:00:00 2001 From: Omair Majid Date: Fri, 7 Jun 2024 16:56:27 -0400 Subject: [PATCH 1/2] Dispose HttpClient and Stream in AddPackageParser The Stream instance and HttpClient instance are both IDisposable. So clean them up. --- .../dotnet-add/dotnet-add-package/AddPackageParser.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Cli/dotnet/commands/dotnet-add/dotnet-add-package/AddPackageParser.cs b/src/Cli/dotnet/commands/dotnet-add/dotnet-add-package/AddPackageParser.cs index 97d1d7364e16..ef3ecfb548ec 100644 --- a/src/Cli/dotnet/commands/dotnet-add/dotnet-add-package/AddPackageParser.cs +++ b/src/Cli/dotnet/commands/dotnet-add/dotnet-add-package/AddPackageParser.cs @@ -83,7 +83,7 @@ private static CliCommand ConstructCommand() public static IEnumerable QueryNuGet(string match) { - var httpClient = new HttpClient(); + using var httpClient = new HttpClient(); Stream result; @@ -104,6 +104,8 @@ public static IEnumerable QueryNuGet(string match) { yield return packageId; } + + stream.Dispose(); } internal static IEnumerable EnumerablePackageIdFromQueryResponse(Stream result) From 1ac1e561672cd202bf98218eef498ff6282a1d7e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20K=C3=B6plinger?= Date: Wed, 12 Jun 2024 15:28:24 +0200 Subject: [PATCH 2/2] Fix typo --- .../commands/dotnet-add/dotnet-add-package/AddPackageParser.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Cli/dotnet/commands/dotnet-add/dotnet-add-package/AddPackageParser.cs b/src/Cli/dotnet/commands/dotnet-add/dotnet-add-package/AddPackageParser.cs index ef3ecfb548ec..afdae3e1b1f8 100644 --- a/src/Cli/dotnet/commands/dotnet-add/dotnet-add-package/AddPackageParser.cs +++ b/src/Cli/dotnet/commands/dotnet-add/dotnet-add-package/AddPackageParser.cs @@ -105,7 +105,7 @@ public static IEnumerable QueryNuGet(string match) yield return packageId; } - stream.Dispose(); + result.Dispose(); } internal static IEnumerable EnumerablePackageIdFromQueryResponse(Stream result)