From ec5e539a57729b371458906b563e230af36bf48b Mon Sep 17 00:00:00 2001 From: Marc Paine Date: Thu, 12 Jan 2023 11:36:17 -0800 Subject: [PATCH 1/2] This call is failing on the Darwin leg in installer. Let's just remove it and see if the test can pass as I don't think that check is necessary anymore. We can potentially just remove the 1.1 and 2.0 targeting if this is blocking. --- .../GivenThatWeWantToPublishAHelloWorldProject.cs | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAHelloWorldProject.cs b/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAHelloWorldProject.cs index 2a2b998bc84c..16017a4d3260 100644 --- a/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAHelloWorldProject.cs +++ b/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAHelloWorldProject.cs @@ -75,11 +75,6 @@ public void It_publishes_portable_apps_to_the_publish_folder_and_the_app_should_ [InlineData(ToolsetInfo.CurrentTargetFramework)] public void It_publishes_self_contained_apps_to_the_publish_folder_and_the_app_should_run(string targetFramework) { - if (!EnvironmentInfo.SupportsTargetFramework(targetFramework)) - { - return; - } - var rid = EnvironmentInfo.GetCompatibleRid(targetFramework); var helloWorldAsset = _testAssetsManager From ea7db262bfe3d2aa026a36177a677c6b085282f6 Mon Sep 17 00:00:00 2001 From: Marc Paine Date: Thu, 12 Jan 2023 13:33:56 -0800 Subject: [PATCH 2/2] Remove the 1.1 target that doesn't work on ubuntu 22. --- .../GivenThatWeWantToPublishAHelloWorldProject.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAHelloWorldProject.cs b/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAHelloWorldProject.cs index 16017a4d3260..bb4becb82b88 100644 --- a/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAHelloWorldProject.cs +++ b/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAHelloWorldProject.cs @@ -70,7 +70,6 @@ public void It_publishes_portable_apps_to_the_publish_folder_and_the_app_should_ } [Theory] - [InlineData("netcoreapp1.1")] [InlineData("netcoreapp2.0")] [InlineData(ToolsetInfo.CurrentTargetFramework)] public void It_publishes_self_contained_apps_to_the_publish_folder_and_the_app_should_run(string targetFramework)