Skip to content

Migrate the nuget state from earlier SDKs #29040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Migrate the nuget state from earlier SDKs #29040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eb9439
Migrate the nuget state from earlier SDKs
marcpopMSFT Nov 11, 2022
6fa3515
Pass the test when running using the 6.0 SDK against 17.4.0 or higher…
marcpopMSFT Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Cli/Microsoft.DotNet.Configurer/DotnetFirstTimeUseConfigurer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ public void Configure()
if (ShouldPrintFirstTimeUseNotice())
{
Stopwatch beforeFirstTimeUseNotice = Stopwatch.StartNew();
// Migrate the nuget state from earlier SDKs
NuGet.Common.Migrations.MigrationRunner.Run();

if (!_dotnetFirstRunConfiguration.NoLogo)
{
PrintFirstTimeMessageWelcome();
Expand Down
6 changes: 6 additions & 0 deletions src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildASelfContainedApp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,12 @@ static int Last2DigitsTo0(int versionBuild)
[InlineData("net6.0")]
public void It_can_publish_runtime_specific_apps_with_library_dependencies_self_contained(string targetFramework) {

// There's a bug when using the 6.0 SDK with 17.4 but we have limited control over the VS version used in helix
Version.TryParse(TestContext.Current.ToolsetUnderTest.MSBuildVersion, out Version msbuildVersion);
Version.TryParse("17.4.0", out Version maximumVersion);
if (msbuildVersion >= maximumVersion)
return;

// create a basic library and a basic app, reference the library from the app and then
// publish the app with a RID specified and self-contained.
// verify that no warnings about missing the --self-contained flag are emitted.
Expand Down