Retarget Microsoft.Extensions.DotNetDeltaApplier to netstandard2.1 #28984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
mkArtakMSFT
reviewed
Nov 9, 2022
mkArtakMSFT
approved these changes
Nov 9, 2022
Member
Author
|
@lbussell PTAL |
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Microsoft.Extensions.DotNetDeltaApplier.dllfrom the current .NET SDK version can be loaded to an app that targets any version of .NET >= 6.0 and equal or lower than the current version. We could target the dll tonet6.0to satisfy these requirements, but that would add more prebuilds to source build. Instead, we targetnetstandard2.1.Fixes dotnet/aspnetcore#45129, https://github.com/aspnet/AspNetCore-ManualTests/issues/1635
Customer Impact
Customers can't use
dotnet-watchfrom .NET 7.0 when .NET 6.0 is also installed.Regression?
Regressed by #27012
Risk
The change is small and the affected code paths are well covered by tests.
Verification
Packaging changes reviewed?