Skip to content

Commit fa58985

Browse files
sfoslundsfoslund
committed
PR feedback
1 parent d549243 commit fa58985

16 files changed

+139
-139
lines changed

‎src/Cli/dotnet/CommonLocalizableStrings.resx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -678,13 +678,13 @@ setx PATH "%PATH%;{0}"
678678
<value>Publish the .NET runtime with your application so the runtime doesn't need to be installed on the target machine.
679679
The default is 'true' if a runtime identifier is specified.</value>
680680
</data>
681-
<data name="NoSelfContainedOptionDescription" xml:space="preserve">
682-
<value>Publish your application as a framework dependent application without the .NET runtime. A supported .NET runtime must be installed to run your application.</value>
681+
<data name="FrameworkDependentOptionDescription" xml:space="preserve">
682+
<value>Publish your application as a framework dependent application. A compatible .NET runtime must be installed on the target machine to run your application.</value>
683683
</data>
684684
<data name="SelfContainAndNoSelfContainedConflict" xml:space="preserve">
685685
<value>The '--self-contained' and '--no-self-contained' options conflict with each other. Specify only one of the options.</value>
686686
</data>
687-
<data name="RuntimeOptionShouldBeUsedWithSelfContained" xml:space="preserve">
688-
<value>Warning: The '-r|--runtime' option should be used with '--self-contained' or '--no-self-contained'.</value>
687+
<data name="SelfContainedOptionShouldBeUsedWithRuntime" xml:space="preserve">
688+
<value>Warning: The '--self-contained' or '--no-self-contained' option should be used with '-r|--runtime'.</value>
689689
</data>
690690
</root>

‎src/Cli/dotnet/CommonOptions.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ public static Option SelfContainedOption() =>
107107
public static Option NoSelfContainedOption() =>
108108
new ForwardedOption<bool>(
109109
"--no-self-contained",
110-
CommonLocalizableStrings.NoSelfContainedOptionDescription)
110+
CommonLocalizableStrings.FrameworkDependentOptionDescription)
111111
.ForwardAs("-property:SelfContained=false");
112112

113113
public static bool VerbosityIsDetailedOrDiagnostic(this VerbosityOptions verbosity)
@@ -135,7 +135,7 @@ public static void ValidateSelfContainedOptions(bool hasSelfContainedOption, boo
135135
var msbuildProj = MsbuildProject.FromFileOrDirectory(new ProjectCollection(), project, false);
136136
if (msbuildProj.IsTargetingNetCoreVersionOrAbove(NuGetFramework.Parse("net6.0")))
137137
{
138-
Reporter.Output.WriteLine(CommonLocalizableStrings.RuntimeOptionShouldBeUsedWithSelfContained.Yellow());
138+
Reporter.Output.WriteLine(CommonLocalizableStrings.SelfContainedOptionShouldBeUsedWithRuntime.Yellow());
139139
}
140140
}
141141
catch

‎src/Cli/dotnet/xlf/CommonLocalizableStrings.cs.xlf‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -75,16 +75,16 @@ export PATH="$PATH:{0}"
7575
</target>
7676
<note />
7777
</trans-unit>
78+
<trans-unit id="FrameworkDependentOptionDescription">
79+
<source>Publish your application as a framework dependent application. A compatible .NET runtime must be installed on the target machine to run your application.</source>
80+
<target state="new">Publish your application as a framework dependent application. A compatible .NET runtime must be installed on the target machine to run your application.</target>
81+
<note />
82+
</trans-unit>
7883
<trans-unit id="MoreThanOneProjectInDirectory">
7984
<source>Found more than one project in `{0}`. Specify which one to use.</source>
8085
<target state="translated">V {0} se našlo několik projektů. Vyberte, který z nich chcete použít.</target>
8186
<note />
8287
</trans-unit>
83-
<trans-unit id="NoSelfContainedOptionDescription">
84-
<source>Publish your application as a framework dependent application without the .NET runtime. A supported .NET runtime must be installed to run your application.</source>
85-
<target state="new">Publish your application as a framework dependent application without the .NET runtime. A supported .NET runtime must be installed to run your application.</target>
86-
<note />
87-
</trans-unit>
8888
<trans-unit id="ProjectAlreadyHasAreference">
8989
<source>Project already has a reference to `{0}`.</source>
9090
<target state="translated">Projekt už obsahuje odkaz na {0}.</target>
@@ -140,11 +140,6 @@ export PATH="$PATH:{0}"
140140
<target state="translated">Balíček</target>
141141
<note />
142142
</trans-unit>
143-
<trans-unit id="RuntimeOptionShouldBeUsedWithSelfContained">
144-
<source>Warning: The '-r|--runtime' option should be used with '--self-contained' or '--no-self-contained'.</source>
145-
<target state="new">Warning: The '-r|--runtime' option should be used with '--self-contained' or '--no-self-contained'.</target>
146-
<note />
147-
</trans-unit>
148143
<trans-unit id="SelfContainAndNoSelfContainedConflict">
149144
<source>The '--self-contained' and '--no-self-contained' options conflict with each other. Specify only one of the options.</source>
150145
<target state="new">The '--self-contained' and '--no-self-contained' options conflict with each other. Specify only one of the options.</target>
@@ -157,6 +152,11 @@ The default is 'true' if a runtime identifier is specified.</source>
157152
The default is 'true' if a runtime identifier is specified.</target>
158153
<note />
159154
</trans-unit>
155+
<trans-unit id="SelfContainedOptionShouldBeUsedWithRuntime">
156+
<source>Warning: The '--self-contained' or '--no-self-contained' option should be used with '-r|--runtime'.</source>
157+
<target state="new">Warning: The '--self-contained' or '--no-self-contained' option should be used with '-r|--runtime'.</target>
158+
<note />
159+
</trans-unit>
160160
<trans-unit id="Solution">
161161
<source>Solution</source>
162162
<target state="translated">Řešení</target>

‎src/Cli/dotnet/xlf/CommonLocalizableStrings.de.xlf‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -75,16 +75,16 @@ export PATH="$PATH:{0}"
7575
</target>
7676
<note />
7777
</trans-unit>
78+
<trans-unit id="FrameworkDependentOptionDescription">
79+
<source>Publish your application as a framework dependent application. A compatible .NET runtime must be installed on the target machine to run your application.</source>
80+
<target state="new">Publish your application as a framework dependent application. A compatible .NET runtime must be installed on the target machine to run your application.</target>
81+
<note />
82+
</trans-unit>
7883
<trans-unit id="MoreThanOneProjectInDirectory">
7984
<source>Found more than one project in `{0}`. Specify which one to use.</source>
8085
<target state="translated">In "{0}" wurden mehrere Projekte gefunden. Geben Sie an, welches davon verwendet werden soll.</target>
8186
<note />
8287
</trans-unit>
83-
<trans-unit id="NoSelfContainedOptionDescription">
84-
<source>Publish your application as a framework dependent application without the .NET runtime. A supported .NET runtime must be installed to run your application.</source>
85-
<target state="new">Publish your application as a framework dependent application without the .NET runtime. A supported .NET runtime must be installed to run your application.</target>
86-
<note />
87-
</trans-unit>
8888
<trans-unit id="ProjectAlreadyHasAreference">
8989
<source>Project already has a reference to `{0}`.</source>
9090
<target state="translated">Für das Projekt ist bereits ein Verweis auf "{0}" vorhanden.</target>
@@ -140,11 +140,6 @@ export PATH="$PATH:{0}"
140140
<target state="translated">Paket</target>
141141
<note />
142142
</trans-unit>
143-
<trans-unit id="RuntimeOptionShouldBeUsedWithSelfContained">
144-
<source>Warning: The '-r|--runtime' option should be used with '--self-contained' or '--no-self-contained'.</source>
145-
<target state="new">Warning: The '-r|--runtime' option should be used with '--self-contained' or '--no-self-contained'.</target>
146-
<note />
147-
</trans-unit>
148143
<trans-unit id="SelfContainAndNoSelfContainedConflict">
149144
<source>The '--self-contained' and '--no-self-contained' options conflict with each other. Specify only one of the options.</source>
150145
<target state="new">The '--self-contained' and '--no-self-contained' options conflict with each other. Specify only one of the options.</target>
@@ -157,6 +152,11 @@ The default is 'true' if a runtime identifier is specified.</source>
157152
The default is 'true' if a runtime identifier is specified.</target>
158153
<note />
159154
</trans-unit>
155+
<trans-unit id="SelfContainedOptionShouldBeUsedWithRuntime">
156+
<source>Warning: The '--self-contained' or '--no-self-contained' option should be used with '-r|--runtime'.</source>
157+
<target state="new">Warning: The '--self-contained' or '--no-self-contained' option should be used with '-r|--runtime'.</target>
158+
<note />
159+
</trans-unit>
160160
<trans-unit id="Solution">
161161
<source>Solution</source>
162162
<target state="translated">Projektmappe</target>

‎src/Cli/dotnet/xlf/CommonLocalizableStrings.es.xlf‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -75,16 +75,16 @@ export PATH="$PATH:{0}"
7575
</target>
7676
<note />
7777
</trans-unit>
78+
<trans-unit id="FrameworkDependentOptionDescription">
79+
<source>Publish your application as a framework dependent application. A compatible .NET runtime must be installed on the target machine to run your application.</source>
80+
<target state="new">Publish your application as a framework dependent application. A compatible .NET runtime must be installed on the target machine to run your application.</target>
81+
<note />
82+
</trans-unit>
7883
<trans-unit id="MoreThanOneProjectInDirectory">
7984
<source>Found more than one project in `{0}`. Specify which one to use.</source>
8085
<target state="translated">Se han encontrado varios proyectos en "{0}". Especifique el que debe usarse.</target>
8186
<note />
8287
</trans-unit>
83-
<trans-unit id="NoSelfContainedOptionDescription">
84-
<source>Publish your application as a framework dependent application without the .NET runtime. A supported .NET runtime must be installed to run your application.</source>
85-
<target state="new">Publish your application as a framework dependent application without the .NET runtime. A supported .NET runtime must be installed to run your application.</target>
86-
<note />
87-
</trans-unit>
8888
<trans-unit id="ProjectAlreadyHasAreference">
8989
<source>Project already has a reference to `{0}`.</source>
9090
<target state="translated">El proyecto ya tiene una referencia a "{0}".</target>
@@ -140,11 +140,6 @@ export PATH="$PATH:{0}"
140140
<target state="translated">Paquete</target>
141141
<note />
142142
</trans-unit>
143-
<trans-unit id="RuntimeOptionShouldBeUsedWithSelfContained">
144-
<source>Warning: The '-r|--runtime' option should be used with '--self-contained' or '--no-self-contained'.</source>
145-
<target state="new">Warning: The '-r|--runtime' option should be used with '--self-contained' or '--no-self-contained'.</target>
146-
<note />
147-
</trans-unit>
148143
<trans-unit id="SelfContainAndNoSelfContainedConflict">
149144
<source>The '--self-contained' and '--no-self-contained' options conflict with each other. Specify only one of the options.</source>
150145
<target state="new">The '--self-contained' and '--no-self-contained' options conflict with each other. Specify only one of the options.</target>
@@ -157,6 +152,11 @@ The default is 'true' if a runtime identifier is specified.</source>
157152
The default is 'true' if a runtime identifier is specified.</target>
158153
<note />
159154
</trans-unit>
155+
<trans-unit id="SelfContainedOptionShouldBeUsedWithRuntime">
156+
<source>Warning: The '--self-contained' or '--no-self-contained' option should be used with '-r|--runtime'.</source>
157+
<target state="new">Warning: The '--self-contained' or '--no-self-contained' option should be used with '-r|--runtime'.</target>
158+
<note />
159+
</trans-unit>
160160
<trans-unit id="Solution">
161161
<source>Solution</source>
162162
<target state="translated">Solución</target>

‎src/Cli/dotnet/xlf/CommonLocalizableStrings.fr.xlf‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -75,16 +75,16 @@ export PATH="$PATH:{0}"
7575
</target>
7676
<note />
7777
</trans-unit>
78+
<trans-unit id="FrameworkDependentOptionDescription">
79+
<source>Publish your application as a framework dependent application. A compatible .NET runtime must be installed on the target machine to run your application.</source>
80+
<target state="new">Publish your application as a framework dependent application. A compatible .NET runtime must be installed on the target machine to run your application.</target>
81+
<note />
82+
</trans-unit>
7883
<trans-unit id="MoreThanOneProjectInDirectory">
7984
<source>Found more than one project in `{0}`. Specify which one to use.</source>
8085
<target state="translated">Plusieurs projets dans '{0}'. Spécifiez celui à utiliser.</target>
8186
<note />
8287
</trans-unit>
83-
<trans-unit id="NoSelfContainedOptionDescription">
84-
<source>Publish your application as a framework dependent application without the .NET runtime. A supported .NET runtime must be installed to run your application.</source>
85-
<target state="new">Publish your application as a framework dependent application without the .NET runtime. A supported .NET runtime must be installed to run your application.</target>
86-
<note />
87-
</trans-unit>
8888
<trans-unit id="ProjectAlreadyHasAreference">
8989
<source>Project already has a reference to `{0}`.</source>
9090
<target state="translated">Le projet a déjà une référence à '{0}'.</target>
@@ -140,11 +140,6 @@ export PATH="$PATH:{0}"
140140
<target state="translated">Package</target>
141141
<note />
142142
</trans-unit>
143-
<trans-unit id="RuntimeOptionShouldBeUsedWithSelfContained">
144-
<source>Warning: The '-r|--runtime' option should be used with '--self-contained' or '--no-self-contained'.</source>
145-
<target state="new">Warning: The '-r|--runtime' option should be used with '--self-contained' or '--no-self-contained'.</target>
146-
<note />
147-
</trans-unit>
148143
<trans-unit id="SelfContainAndNoSelfContainedConflict">
149144
<source>The '--self-contained' and '--no-self-contained' options conflict with each other. Specify only one of the options.</source>
150145
<target state="new">The '--self-contained' and '--no-self-contained' options conflict with each other. Specify only one of the options.</target>
@@ -157,6 +152,11 @@ The default is 'true' if a runtime identifier is specified.</source>
157152
The default is 'true' if a runtime identifier is specified.</target>
158153
<note />
159154
</trans-unit>
155+
<trans-unit id="SelfContainedOptionShouldBeUsedWithRuntime">
156+
<source>Warning: The '--self-contained' or '--no-self-contained' option should be used with '-r|--runtime'.</source>
157+
<target state="new">Warning: The '--self-contained' or '--no-self-contained' option should be used with '-r|--runtime'.</target>
158+
<note />
159+
</trans-unit>
160160
<trans-unit id="Solution">
161161
<source>Solution</source>
162162
<target state="translated">Solution</target>

‎src/Cli/dotnet/xlf/CommonLocalizableStrings.it.xlf‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -75,16 +75,16 @@ export PATH="$PATH:{0}"
7575
</target>
7676
<note />
7777
</trans-unit>
78+
<trans-unit id="FrameworkDependentOptionDescription">
79+
<source>Publish your application as a framework dependent application. A compatible .NET runtime must be installed on the target machine to run your application.</source>
80+
<target state="new">Publish your application as a framework dependent application. A compatible .NET runtime must be installed on the target machine to run your application.</target>
81+
<note />
82+
</trans-unit>
7883
<trans-unit id="MoreThanOneProjectInDirectory">
7984
<source>Found more than one project in `{0}`. Specify which one to use.</source>
8085
<target state="translated">Sono stati trovati più progetti in `{0}`. Specificare quello da usare.</target>
8186
<note />
8287
</trans-unit>
83-
<trans-unit id="NoSelfContainedOptionDescription">
84-
<source>Publish your application as a framework dependent application without the .NET runtime. A supported .NET runtime must be installed to run your application.</source>
85-
<target state="new">Publish your application as a framework dependent application without the .NET runtime. A supported .NET runtime must be installed to run your application.</target>
86-
<note />
87-
</trans-unit>
8888
<trans-unit id="ProjectAlreadyHasAreference">
8989
<source>Project already has a reference to `{0}`.</source>
9090
<target state="translated">Per il progetto esiste già un riferimento a `{0}`.</target>
@@ -140,11 +140,6 @@ export PATH="$PATH:{0}"
140140
<target state="translated">Pacchetto</target>
141141
<note />
142142
</trans-unit>
143-
<trans-unit id="RuntimeOptionShouldBeUsedWithSelfContained">
144-
<source>Warning: The '-r|--runtime' option should be used with '--self-contained' or '--no-self-contained'.</source>
145-
<target state="new">Warning: The '-r|--runtime' option should be used with '--self-contained' or '--no-self-contained'.</target>
146-
<note />
147-
</trans-unit>
148143
<trans-unit id="SelfContainAndNoSelfContainedConflict">
149144
<source>The '--self-contained' and '--no-self-contained' options conflict with each other. Specify only one of the options.</source>
150145
<target state="new">The '--self-contained' and '--no-self-contained' options conflict with each other. Specify only one of the options.</target>
@@ -157,6 +152,11 @@ The default is 'true' if a runtime identifier is specified.</source>
157152
The default is 'true' if a runtime identifier is specified.</target>
158153
<note />
159154
</trans-unit>
155+
<trans-unit id="SelfContainedOptionShouldBeUsedWithRuntime">
156+
<source>Warning: The '--self-contained' or '--no-self-contained' option should be used with '-r|--runtime'.</source>
157+
<target state="new">Warning: The '--self-contained' or '--no-self-contained' option should be used with '-r|--runtime'.</target>
158+
<note />
159+
</trans-unit>
160160
<trans-unit id="Solution">
161161
<source>Solution</source>
162162
<target state="translated">Soluzione</target>

0 commit comments

Comments
 (0)