IsValidSolutionFolderPath -> IsSolutionFolderPathInDirectoryScope

Author: edvilme

src/Cli/dotnet/commands/dotnet-sln/add/Program.cs

@@ -32,11 +32,11 @@ private static string GetSolutionFolderPathWithForwardSlashes(string path)
             return "/" + string.Join("/", PathUtility.GetPathWithDirectorySeparator(path).Split(Path.DirectorySeparatorChar, StringSplitOptions.RemoveEmptyEntries)) + "/";
         }
 
-        private static bool IsValidSolutionFolderPath(string pathFragment)
+        private static bool IsSolutionFolderPathInDirectoryScope(string relativePath)
         {
-            return !string.IsNullOrEmpty(pathFragment) && !pathFragment
-                .Split(Path.DirectorySeparatorChar)
-                .Any(pathFragment => pathFragment == ".." || pathFragment == "." || Path.GetInvalidFileNameChars().Any(c => pathFragment.Contains(c)));
+            return !string.IsNullOrEmpty(relativePath)
+                && !Path.IsPathRooted(relativePath) // This means path is in a different volume
+                && !relativePath.StartsWith(".."); // This means path is outside the solution directory
         }
 
         public AddProjectToSolutionCommand(ParseResult parseResult) : base(parseResult)
@@ -137,8 +137,8 @@ private async Task AddProjectsToSolutionAsync(IEnumerable<string> projectPaths,
                     relativeSolutionFolderPath = Path.Combine([.. relativeSolutionFolderPath.Split(Path.DirectorySeparatorChar).SkipLast(1)]);
                 }
 
-                // If the generated path is invalid, make it empty
-                if (!IsValidSolutionFolderPath(relativeSolutionFolderPath))
+                // If the generated path is outside the solution directory, we need to set it to empty
+                if (!IsSolutionFolderPathInDirectoryScope(relativeSolutionFolderPath))
                 {
                     relativeSolutionFolderPath = string.Empty;
                 }