Apply code review feedback

Author: dsplaisted

src/Tasks/Microsoft.NET.Build.Tasks.UnitTests/GivenADependencyContextBuilder.cs

@@ -51,7 +51,7 @@ public void ItBuildsDependencyContextsFromProjectLockFiles(
                 FrameworkConstants.CommonFrameworks.NetCoreApp10,
                 runtime,
                 Constants.DefaultPlatformLibrary,
-                null,
+                runtimeFrameworks: null,
                 isSelfContained: !string.IsNullOrEmpty(runtime));
 
             DependencyContext dependencyContext = new DependencyContextBuilder(mainProject, projectContext, includeRuntimeFileVersions: false)
@@ -255,7 +255,7 @@ private DependencyContext BuildDependencyContextWithReferenceAssemblies(bool use
                 FrameworkConstants.CommonFrameworks.NetCoreApp10,
                 runtime: null,
                 platformLibraryName: Constants.DefaultPlatformLibrary,
-                null,
+                runtimeFrameworks: null,
                 isSelfContained: false);
 
             CompilationOptions compilationOptions = 

src/Tasks/Microsoft.NET.Build.Tasks.UnitTests/GivenAProjectContext.cs

@@ -20,9 +20,9 @@ public void ItComputesExcludeFromPublishList()
             LockFile lockFile = TestLockFiles.GetLockFile("dependencies.withgraphs");
             ProjectContext projectContext = lockFile.CreateProjectContext(
                FrameworkConstants.CommonFrameworks.NetStandard16,
-               null,
+               runtime: null,
                Constants.DefaultPlatformLibrary,
-               null,
+               runtimeFrameworks: null,
                isSelfContained: false);
 
             IEnumerable<string> excludeFromPublishPackageIds = new[] { "Microsoft.Extensions.Logging.Abstractions" };

src/Tasks/Microsoft.NET.Build.Tasks.UnitTests/GivenAPublishAssembliesResolver.cs

@@ -26,7 +26,7 @@ public void ItResolvesAssembliesFromProjectLockFiles(string projectName, string
                 FrameworkConstants.CommonFrameworks.NetCoreApp10,
                 runtime,
                 Constants.DefaultPlatformLibrary,
-                null,
+                runtimeFrameworks: null,
                 isSelfContained: false);
 
             IEnumerable<ResolvedFile> resolvedFiles = new PublishAssembliesResolver(new MockPackageResolver())
@@ -46,7 +46,7 @@ public void ItResolvesAssembliesFromProjectLockFilesWithStoreLayout(string proje
                 FrameworkConstants.CommonFrameworks.NetCoreApp10,
                 runtime,
                 Constants.DefaultPlatformLibrary,
-                null,
+                runtimeFrameworks: null,
                 isSelfContained: false);
 
             IEnumerable<ResolvedFile> resolvedFiles = new PublishAssembliesResolver(new MockPackageResolver())

src/Tasks/Microsoft.NET.Build.Tasks/FilterResolvedFiles.cs

@@ -59,7 +59,7 @@ protected override void ExecuteCore()
                 NuGetUtils.ParseFrameworkName(TargetFramework),
                 RuntimeIdentifier,
                 PlatformLibraryName,
-                null,
+                runtimeFrameworks: null,
                 IsSelfContained);
 
             var packageClosure =  new HashSet<PackageIdentity>();

src/Tasks/Microsoft.NET.Build.Tasks/GenerateRuntimeConfigurationFiles.cs

@@ -104,7 +104,7 @@ private void AddFrameworks(RuntimeOptions runtimeOptions, ProjectContext project
             {
                 runtimeOptions.tfm = TargetFramework;
 
-                if (projectContext.RuntimeFrameworks == null)
+                if (projectContext.RuntimeFrameworks == null || projectContext.RuntimeFrameworks.Length == 0)
                 {
                     //  If there are no RuntimeFrameworks (which would be set in the ResolveFrameworkReference task based
                     //  on FrameworkReference items), then use package resolved from MicrosoftNETPlatformLibrary for

src/Tasks/Microsoft.NET.Build.Tasks/ReportUnknownFrameworkReferences.cs

@@ -0,0 +1,18 @@
+namespace Microsoft.NET.Build.Tasks
+{
+    public class ReportUnknownFrameworkReferences : TaskBase
+    {
+        public string[] UnresolvedFrameworkReferences { get; set; }
+
+        protected override void ExecuteCore()
+        {
+            if (UnresolvedFrameworkReferences != null)
+            {
+                foreach (var unresolvedFrameworkReference in UnresolvedFrameworkReferences)
+                {
+                    Log.LogError(Strings.UnknownFrameworkReference, unresolvedFrameworkReference);
+                }
+            }
+        }
+    }
+}

src/Tasks/Microsoft.NET.Build.Tasks/ResolveFrameworkReferences.cs

@@ -100,20 +100,4 @@ public KnownFrameworkReference(ITaskItem item)
             public string TargetingPackVersion => _item.GetMetadata("TargetingPackVersion");
         }
     }
-
-    public class ReportUnknownFrameworkReferences : TaskBase
-    {
-        public string[] UnresolvedFrameworkReferences { get; set; }
-
-        protected override void ExecuteCore()
-        {
-            if (UnresolvedFrameworkReferences != null)
-            {
-                foreach (var unresolvedFrameworkReference in UnresolvedFrameworkReferences)
-                {
-                    Log.LogError(Strings.UnknownFrameworkReference, unresolvedFrameworkReference);
-                }
-            }
-        }
-    }
 }