Skip to content

Commit 464619e

Browse files
Remove default verbosity and fix test cases
1 parent e41e5d4 commit 464619e

File tree

4 files changed

+15
-16
lines changed

4 files changed

+15
-16
lines changed

src/Cli/dotnet/CommonOptions.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ internal static class CommonOptions
2323
new ForwardedOption<VerbosityOptions>("--verbosity", "-v")
2424
{
2525
Description = CommonLocalizableStrings.VerbosityOptionDescription,
26-
HelpName = CommonLocalizableStrings.LevelArgumentName,
27-
DefaultValueFactory = _ => VerbosityOptions.minimal
26+
HelpName = CommonLocalizableStrings.LevelArgumentName
2827
}.ForwardAsSingle(o => $"-verbosity:{o}");
2928

3029
public static CliOption<VerbosityOptions> HiddenVerbosityOption =

src/Tests/dotnet.Tests/CommandTests/ToolInstallGlobalOrToolPathCommandTests.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public ToolInstallGlobalOrToolPathCommandTests(ITestOutputHelper log): base(log)
6060
_createToolPackageStoresAndDownloader = (location, forwardArguments) => (_toolPackageStore, _toolPackageStoreQuery, CreateToolPackageDownloader());
6161

6262

63-
_parseResult = Parser.Instance.Parse($"dotnet tool install -g {PackageId}");
63+
_parseResult = Parser.Instance.Parse($"dotnet tool install -g {PackageId} --verbosity minimal");
6464
}
6565

6666
[Fact]
@@ -283,7 +283,7 @@ public void WhenRunWithPackageIdItShouldShowSuccessMessage()
283283
}
284284

285285
[Fact]
286-
public void WhenRunWithPackageIdWithQuietItShouldShowSuccessMessage()
286+
public void WhenRunWithPackageIdWithQuietItShouldShowNoSuccessMessage()
287287
{
288288
var parseResultQuiet = Parser.Instance.Parse($"dotnet tool install -g {PackageId} --verbosity quiet");
289289
var toolInstallGlobalOrToolPathCommand = new ToolInstallGlobalOrToolPathCommand(
@@ -330,7 +330,7 @@ public void WhenRunWithInvalidVersionItShouldThrow()
330330
[Fact]
331331
public void WhenRunWithExactVersionItShouldSucceed()
332332
{
333-
ParseResult result = Parser.Instance.Parse($"dotnet tool install -g {PackageId} --version {PackageVersion}");
333+
ParseResult result = Parser.Instance.Parse($"dotnet tool install -g {PackageId} --version {PackageVersion} --verbosity minimal");
334334

335335
var toolInstallGlobalOrToolPathCommand = new ToolInstallGlobalOrToolPathCommand(
336336
result,
@@ -354,7 +354,7 @@ public void WhenRunWithExactVersionItShouldSucceed()
354354
[Fact]
355355
public void WhenRunWithValidVersionRangeItShouldSucceed()
356356
{
357-
ParseResult result = Parser.Instance.Parse($"dotnet tool install -g {PackageId} --version [1.0,2.0]");
357+
ParseResult result = Parser.Instance.Parse($"dotnet tool install -g {PackageId} --version [1.0,2.0] --verbosity minimal");
358358

359359
var toolInstallGlobalOrToolPathCommand = new ToolInstallGlobalOrToolPathCommand(
360360
result,
@@ -410,7 +410,7 @@ public void WhenRunWithPrereleaseItShouldSucceed()
410410
{
411411
IToolPackageDownloader toolToolPackageDownloader = GetToolToolPackageDownloaderWithPreviewInFeed();
412412

413-
ParseResult result = Parser.Instance.Parse($"dotnet tool install -g {PackageId} --prerelease");
413+
ParseResult result = Parser.Instance.Parse($"dotnet tool install -g {PackageId} --prerelease --verbosity minimal");
414414

415415
var toolInstallGlobalOrToolPathCommand = new ToolInstallGlobalOrToolPathCommand(
416416
result,
@@ -502,7 +502,7 @@ public void WhenRunWithoutAMatchingRangeItShouldFail()
502502
[Fact]
503503
public void WhenRunWithValidVersionWildcardItShouldSucceed()
504504
{
505-
ParseResult result = Parser.Instance.Parse($"dotnet tool install -g {PackageId} --version 1.0.*");
505+
ParseResult result = Parser.Instance.Parse($"dotnet tool install -g {PackageId} --version 1.0.* --verbosity minimal");
506506

507507
var toolInstallGlobalOrToolPathCommand = new ToolInstallGlobalOrToolPathCommand(
508508
result,

src/Tests/dotnet.Tests/CommandTests/ToolUninstallGlobalOrToolPathCommandTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public void GivenANonExistentPackageItErrors()
5656
[Fact]
5757
public void GivenAPackageItUninstalls()
5858
{
59-
CreateInstallCommand($"-g {PackageId}").Execute().Should().Be(0);
59+
CreateInstallCommand($"-g {PackageId} --verbosity minimal").Execute().Should().Be(0);
6060

6161
_reporter
6262
.Lines
@@ -98,7 +98,7 @@ public void GivenAPackageItUninstalls()
9898
[Fact]
9999
public void GivenAPackageWhenCallFromUninstallRedirectCommandItUninstalls()
100100
{
101-
CreateInstallCommand($"-g {PackageId}").Execute().Should().Be(0);
101+
CreateInstallCommand($"-g {PackageId} --verbosity minimal").Execute().Should().Be(0);
102102

103103
_reporter
104104
.Lines
@@ -168,7 +168,7 @@ var uninstallCommand
168168
[Fact]
169169
public void GivenAFailureToUninstallItLeavesItInstalled()
170170
{
171-
CreateInstallCommand($"-g {PackageId}").Execute().Should().Be(0);
171+
CreateInstallCommand($"-g {PackageId} --verbosity minimal").Execute().Should().Be(0);
172172

173173
_reporter
174174
.Lines

src/Tests/dotnet.Tests/CommandTests/ToolUpdateGlobalOrToolPathCommandTests.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ public void GivenAnExistedLowerversionInstallationWhenCallItCanPrintSuccessMessa
143143
CreateInstallCommand($"-g {_packageId} --version {LowerPackageVersion}").Execute();
144144
_reporter.Lines.Clear();
145145

146-
var command = CreateUpdateCommand($"-g {_packageId}");
146+
var command = CreateUpdateCommand($"-g {_packageId} --verbosity minimal");
147147

148148
command.Execute();
149149

@@ -158,7 +158,7 @@ public void GivenAnExistedLowerversionInstallationWhenCallWithWildCardVersionItC
158158
CreateInstallCommand($"-g {_packageId} --version {LowerPackageVersion}").Execute();
159159
_reporter.Lines.Clear();
160160

161-
var command = CreateUpdateCommand($"-g {_packageId} --version 1.0.5-*");
161+
var command = CreateUpdateCommand($"-g {_packageId} --version 1.0.5-* --verbosity minimal");
162162

163163
command.Execute();
164164

@@ -173,7 +173,7 @@ public void GivenAnExistedLowerversionInstallationWhenCallWithPrereleaseVersionI
173173
CreateInstallCommand($"-g {_packageId} --version {LowerPackageVersion}").Execute();
174174
_reporter.Lines.Clear();
175175

176-
var command = CreateUpdateCommand($"-g {_packageId} --prerelease");
176+
var command = CreateUpdateCommand($"-g {_packageId} --prerelease --verbosity minimal");
177177

178178
command.Execute();
179179

@@ -208,7 +208,7 @@ public void GivenAnExistedSameVersionInstallationWhenCallItCanPrintSuccessMessag
208208
CreateInstallCommand($"-g {_packageId} --version {HigherPackageVersion}").Execute();
209209
_reporter.Lines.Clear();
210210

211-
var command = CreateUpdateCommand($"-g {_packageId}");
211+
var command = CreateUpdateCommand($"-g {_packageId} --verbosity minimal");
212212

213213
command.Execute();
214214

@@ -223,7 +223,7 @@ public void GivenAnExistedSameVersionInstallationWhenCallWithPrereleaseItUsesAPr
223223
CreateInstallCommand($"-g {_packageId} --version {HigherPreviewPackageVersion}").Execute();
224224
_reporter.Lines.Clear();
225225

226-
var command = CreateUpdateCommand($"-g {_packageId} --version {HigherPreviewPackageVersion}");
226+
var command = CreateUpdateCommand($"-g {_packageId} --version {HigherPreviewPackageVersion} --verbosity minimal");
227227

228228
command.Execute();
229229

0 commit comments

Comments
 (0)