Skip to content

Commit 1157aa7

Browse files
authored
Merge pull request #3333 from dsplaisted/wli3-update-stage0-061419
Update stage 0
2 parents cb8c89e + c6af9e9 commit 1157aa7

File tree

4 files changed

+12
-9
lines changed

4 files changed

+12
-9
lines changed

global.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"tools": {
3-
"dotnet": "3.0.100-preview7-012270",
3+
"dotnet": "3.0.100-preview7-012402",
44
"vs-opt": {
55
"version": "15.9"
66
}

src/Tasks/Microsoft.NET.Build.Tasks/PrepareForReadyToRunCompilation.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,9 @@ protected override void ExecuteCore()
6969
string supportedRuntimeIdentifiers = frameworkRef == null ? null : frameworkRef.GetMetadata("RuntimePackRuntimeIdentifiers");
7070

7171
// Get information on the runtime package used for the current target
72-
ITaskItem frameworkPack = RuntimePacks.Where(pack => pack.ItemSpec.EndsWith(".Microsoft.NETCore.App", StringComparison.InvariantCultureIgnoreCase)).SingleOrDefault();
72+
ITaskItem frameworkPack = RuntimePacks.Where(pack =>
73+
pack.GetMetadata(MetadataKeys.FrameworkName).Equals("Microsoft.NETCore.App", StringComparison.OrdinalIgnoreCase))
74+
.SingleOrDefault();
7375
_runtimeIdentifier = frameworkPack == null ? null : frameworkPack.GetMetadata(MetadataKeys.RuntimeIdentifier);
7476
_packagePath = frameworkPack == null ? null : frameworkPack.GetMetadata(MetadataKeys.PackageDirectory);
7577

src/Tests/Microsoft.NET.Build.Tests/GivenFrameworkReferences.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ public void RuntimeFrameworkVersionCanBeSpecifiedOnFrameworkReference()
396396
resolvedVersions.RuntimeFramework["Microsoft.NETCore.App"].Should().Be(runtimeFrameworkVersion);
397397
resolvedVersions.PackageDownload["Microsoft.NETCore.App.Ref"].Should().Be(targetingPackVersion);
398398
string runtimePackName = resolvedVersions.PackageDownload.Keys
399-
.Where(k => k.StartsWith("runtime.") && k.EndsWith(".Microsoft.NETCore.App"))
399+
.Where(k => k.StartsWith("Microsoft.NETCore.App.Runtime."))
400400
.Single();
401401
resolvedVersions.PackageDownload[runtimePackName].Should().Be(runtimeFrameworkVersion);
402402
resolvedVersions.TargetingPack["Microsoft.NETCore.App"].Should().Be(targetingPackVersion);
@@ -419,7 +419,7 @@ public void RuntimeFrameworkVersionCanBeSpecifiedViaProperty()
419419
resolvedVersions.RuntimeFramework["Microsoft.NETCore.App"].Should().Be(runtimeFrameworkVersion);
420420
resolvedVersions.PackageDownload["Microsoft.NETCore.App.Ref"].Should().Be(targetingPackVersion);
421421
string runtimePackName = resolvedVersions.PackageDownload.Keys
422-
.Where(k => k.StartsWith("runtime.") && k.EndsWith(".Microsoft.NETCore.App"))
422+
.Where(k => k.StartsWith("Microsoft.NETCore.App.Runtime."))
423423
.Single();
424424
resolvedVersions.PackageDownload[runtimePackName].Should().Be(runtimeFrameworkVersion);
425425
resolvedVersions.TargetingPack["Microsoft.NETCore.App"].Should().Be(targetingPackVersion);
@@ -455,7 +455,7 @@ public void TargetLatestPatchCanBeSpecifiedOnFrameworkReference(bool attributeVa
455455
resolvedVersions.RuntimeFramework["Microsoft.NETCore.App"].Should().Be(expectedRuntimeFrameworkVersion);
456456
resolvedVersions.PackageDownload["Microsoft.NETCore.App.Ref"].Should().Be(targetingPackVersion);
457457
string runtimePackName = resolvedVersions.PackageDownload.Keys
458-
.Where(k => k.StartsWith("runtime.") && k.EndsWith(".Microsoft.NETCore.App"))
458+
.Where(k => k.StartsWith("Microsoft.NETCore.App.Runtime."))
459459
.Single();
460460
resolvedVersions.PackageDownload[runtimePackName].Should().Be(expectedRuntimeFrameworkVersion);
461461
resolvedVersions.TargetingPack["Microsoft.NETCore.App"].Should().Be(targetingPackVersion);
@@ -481,7 +481,7 @@ public void TargetLatestPatchCanBeSpecifiedViaProperty(bool propertyValue)
481481
resolvedVersions.RuntimeFramework["Microsoft.NETCore.App"].Should().Be(expectedRuntimeFrameworkVersion);
482482
resolvedVersions.PackageDownload["Microsoft.NETCore.App.Ref"].Should().Be(targetingPackVersion);
483483
string runtimePackName = resolvedVersions.PackageDownload.Keys
484-
.Where(k => k.StartsWith("runtime.") && k.EndsWith(".Microsoft.NETCore.App"))
484+
.Where(k => k.StartsWith("Microsoft.NETCore.App.Runtime."))
485485
.Single();
486486
resolvedVersions.PackageDownload[runtimePackName].Should().Be(expectedRuntimeFrameworkVersion);
487487
resolvedVersions.TargetingPack["Microsoft.NETCore.App"].Should().Be(targetingPackVersion);
@@ -512,7 +512,7 @@ public void TargetingPackVersionCanBeSpecifiedOnFrameworkReference()
512512
resolvedVersions.RuntimeFramework["Microsoft.NETCore.App"].Should().Be(expectedRuntimeFrameworkVersion);
513513
resolvedVersions.PackageDownload["Microsoft.NETCore.App.Ref"].Should().Be(targetingPackVersion);
514514
string runtimePackName = resolvedVersions.PackageDownload.Keys
515-
.Where(k => k.StartsWith("runtime.") && k.EndsWith(".Microsoft.NETCore.App"))
515+
.Where(k => k.StartsWith("Microsoft.NETCore.App.Runtime."))
516516
.Single();
517517
resolvedVersions.PackageDownload[runtimePackName].Should().Be(expectedRuntimeFrameworkVersion);
518518
resolvedVersions.TargetingPack["Microsoft.NETCore.App"].Should().Be(targetingPackVersion);
@@ -629,7 +629,7 @@ public void IsTrimmableDefaultsComeFromKnownFrameworkReference()
629629
var runtimeAssetTrimInfo = GetRuntimeAssetTrimInfo(testProject);
630630

631631
string runtimePackName = runtimeAssetTrimInfo.Keys
632-
.Where(k => k.StartsWith("runtime.") && k.EndsWith(".Microsoft.NETCore.App"))
632+
.Where(k => k.StartsWith("Microsoft.NETCore.App.Runtime."))
633633
.Single();
634634

635635
foreach (var runtimeAsset in runtimeAssetTrimInfo[runtimePackName])
@@ -657,7 +657,7 @@ public void IsTrimmableCanBeSpecifiedOnFrameworkReference()
657657
});
658658

659659
string runtimePackName = runtimeAssetTrimInfo.Keys
660-
.Where(k => k.StartsWith("runtime.") && k.EndsWith(".Microsoft.NETCore.App"))
660+
.Where(k => k.StartsWith("Microsoft.NETCore.App.Runtime."))
661661
.Single();
662662

663663
foreach (var runtimeAsset in runtimeAssetTrimInfo[runtimePackName])

src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPreserveCompilationContext.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -674,6 +674,7 @@ public void It_excludes_runtime_store_packages_from_the_refs_folder()
674674
System.ServiceModel.Web.dll
675675
System.ServiceProcess.dll
676676
System.Text.Encoding.dll
677+
System.Text.Encoding.CodePages.dll
677678
System.Text.Encoding.Extensions.dll
678679
System.Text.Encodings.Web.dll
679680
System.Text.RegularExpressions.dll

0 commit comments

Comments
 (0)