Disallow BLK<SIMD>
#84868
Merged
Disallow BLK<SIMD>
#84868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsSome positive diffs are expected.
|
From compiler.hpp to gentree.cpp. Motivation: more methods are to come and the header file is very large already.
SingleAccretion
force-pushed
the
No-Blk-Simd-Upstream
branch
4 times, most recently
from
8e51a8b to
647dfc8
Compare
SingleAccretion
force-pushed
the
No-Blk-Simd-Upstream
branch
from
647dfc8 to
e09bbeb
Compare
The IND(COMMA) -> COMMA(IND) transformation decanonicalizes array access as it is only performed on "uses" (i. e. not stores). Simply do not do this for SIMD types. Evidently, this unblocks some if conversions.
SingleAccretion
force-pushed
the
No-Blk-Simd-Upstream
branch
from
e09bbeb to
52f548a
Compare
Preserve the behavior of setting the "is used in a SIMD intrinsic" flag. Will bring additional positive diffs due to the "ldobj" change.
SingleAccretion
force-pushed
the
No-Blk-Simd-Upstream
branch
from
52f548a to
bf36863
Compare
|
@dotnet/jit-contrib |
tannergooding
approved these changes
Apr 17, 2023
jakobbotsch
reviewed
Apr 19, 2023
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I think the failures are current known ones. |
|
I looked as well and believe so too. Jitstress run. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a very long time, both
OBJ/BLK<SIMD>andIND<SIMD>representations for a SIMD-typed load have been legal. There is no point in having both, so this change disallows the former (as a less canonical one).Plus a number of supporting changes (see individual commits).
Diffs.