Additional changes to merged test runners #67367
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
added
NO-MERGE
ghost
assigned
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkoritzinsky
force-pushed
the
JIT-Methodical
branch
from
6727725 to
976f6ea
Compare
|
/azp run runtime-extra-platforms |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Previously this target was only called from the recursive traversal used when globally copying native artifacts for all projects (this is used in the lab where the native artifacts are produced on a different machine than the managed test artifacts). In case of combined (local) test build we weren't running the target, only its dependencies (ResolveCMakeNativeProjectReference and ConsolidateNativeProjectReference); this used to be sufficient as these two targets handle all logic related to copying native components of a normal project, however I have recently added special logic for copying merged test wrapper native artifacts the CopyAllNativeProjectReferenceBinaries target and so we now must make sure it also always runs. Thanks Tomas
jkoritzinsky
force-pushed
the
JIT-Methodical
branch
from
c914f7d to
3a01542
Compare
… we can easily pass the additional parameter
jkoritzinsky
force-pushed
the
JIT-Methodical
branch
from
3a01542 to
19b6e88
Compare
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkoritzinsky
force-pushed
the
JIT-Methodical
branch
from
19b6e88 to
0fd5fef
Compare
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This PR has served its purpose. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing changes on top of #65597
Do not review or merge. Changes will be pushed into #65597 after validation.