From 82397ebdbb72bfe71eb26e2b6071e40e99aa267f Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 15 Mar 2021 10:27:16 +0300 Subject: [PATCH 1/8] Set default features flags to match to iOS SDK defaults --- eng/testing/linker/SupportFiles/Directory.Build.props | 1 + eng/testing/tests.mobile.targets | 11 +++++++++++ 2 files changed, 12 insertions(+) diff --git a/eng/testing/linker/SupportFiles/Directory.Build.props b/eng/testing/linker/SupportFiles/Directory.Build.props index b5c4dfe732fb21..ad6c9dbb6916d7 100644 --- a/eng/testing/linker/SupportFiles/Directory.Build.props +++ b/eng/testing/linker/SupportFiles/Directory.Build.props @@ -3,6 +3,7 @@ true false false + false true true link diff --git a/eng/testing/tests.mobile.targets b/eng/testing/tests.mobile.targets index d287996e15eeb6..984ced1e101a85 100644 --- a/eng/testing/tests.mobile.targets +++ b/eng/testing/tests.mobile.targets @@ -33,6 +33,17 @@ true + + false + false + false + false + true + false + true + true + + true From a74a423a1fb654a5ff907276d79de5a4e975150a Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 16 Mar 2021 11:33:07 +0300 Subject: [PATCH 2/8] Apply a better msbuild practice --- eng/testing/tests.mobile.targets | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/eng/testing/tests.mobile.targets b/eng/testing/tests.mobile.targets index 984ced1e101a85..aea04a062d6b87 100644 --- a/eng/testing/tests.mobile.targets +++ b/eng/testing/tests.mobile.targets @@ -10,7 +10,7 @@ true - + $HARNESS_RUNNER wasm $XHARNESS_COMMAND --app=. --engine=$(JSEngine) $(JSEngineArgs) --js-file=runtime.js --output-directory=$XHARNESS_OUT -- $(RunTestsJSArguments) --run WasmTestRunner.dll $(AssemblyName).dll $HARNESS_RUNNER wasm $XHARNESS_COMMAND --app=. --engine=$(JSEngine) $(JSEngineArgs) --js-file=runtime.js --output-directory=$XHARNESS_OUT --expected-exit-code=$(ExpectedExitCode) -- $(RunTestsJSArguments) --run $(AssemblyName).dll --testing @@ -21,7 +21,7 @@ false - + false false false @@ -33,7 +33,7 @@ true - + false false false From d8a01cccc41f71ed31f07e0e47992df3288cfc6b Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Thu, 18 Mar 2021 15:48:13 +0300 Subject: [PATCH 3/8] Remove InvariantGlobalization default feature flag --- eng/testing/tests.mobile.targets | 1 - 1 file changed, 1 deletion(-) diff --git a/eng/testing/tests.mobile.targets b/eng/testing/tests.mobile.targets index aea04a062d6b87..745aafa3be971f 100644 --- a/eng/testing/tests.mobile.targets +++ b/eng/testing/tests.mobile.targets @@ -38,7 +38,6 @@ false false false - true false true true From fa22dd4b009489b70a85d11e35d01f30c67dfb31 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 19 Mar 2021 10:08:55 +0300 Subject: [PATCH 4/8] Remove redundant property declarations since the respective flags are turned off by default. --- eng/testing/linker/SupportFiles/Directory.Build.props | 3 --- 1 file changed, 3 deletions(-) diff --git a/eng/testing/linker/SupportFiles/Directory.Build.props b/eng/testing/linker/SupportFiles/Directory.Build.props index ad6c9dbb6916d7..0a6fb586d9bcfd 100644 --- a/eng/testing/linker/SupportFiles/Directory.Build.props +++ b/eng/testing/linker/SupportFiles/Directory.Build.props @@ -1,9 +1,6 @@ true - false - false - false true true link From 814f872d152501ef98c4f4fd63af735764553c93 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 22 Mar 2021 22:51:32 +0300 Subject: [PATCH 5/8] Set the flags to true in case of empty value --- eng/testing/tests.mobile.targets | 3 +++ 1 file changed, 3 insertions(+) diff --git a/eng/testing/tests.mobile.targets b/eng/testing/tests.mobile.targets index 745aafa3be971f..e5be26b718f606 100644 --- a/eng/testing/tests.mobile.targets +++ b/eng/testing/tests.mobile.targets @@ -8,6 +8,9 @@ $(JSEngineArgs) --engine-arg=--stack-trace-limit=1000 true + true + true + true From db62e3ae69899d5188178ce76094c967ca348dc5 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 23 Mar 2021 11:23:40 +0300 Subject: [PATCH 6/8] Move back the default switch values for the linker tests --- eng/testing/linker/SupportFiles/Directory.Build.props | 3 +++ 1 file changed, 3 insertions(+) diff --git a/eng/testing/linker/SupportFiles/Directory.Build.props b/eng/testing/linker/SupportFiles/Directory.Build.props index 0a6fb586d9bcfd..ad6c9dbb6916d7 100644 --- a/eng/testing/linker/SupportFiles/Directory.Build.props +++ b/eng/testing/linker/SupportFiles/Directory.Build.props @@ -1,6 +1,9 @@ true + false + false + false true true link From dacb3e0616e4b0cd4aaab420e97a569eca97aa39 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 23 Mar 2021 20:35:10 +0300 Subject: [PATCH 7/8] Add iOSSsimulator to the condition MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Alexander Köplinger --- eng/testing/tests.mobile.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/testing/tests.mobile.targets b/eng/testing/tests.mobile.targets index e5be26b718f606..598967605e1c62 100644 --- a/eng/testing/tests.mobile.targets +++ b/eng/testing/tests.mobile.targets @@ -36,7 +36,7 @@ true - + false false false From 347d2b0b9d366c1903f2c7eb3af797ce9e18e9b5 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 23 Mar 2021 20:35:36 +0300 Subject: [PATCH 8/8] Use spaces MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Alexander Köplinger --- eng/testing/tests.mobile.targets | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/eng/testing/tests.mobile.targets b/eng/testing/tests.mobile.targets index 598967605e1c62..7fc9b7cd77e951 100644 --- a/eng/testing/tests.mobile.targets +++ b/eng/testing/tests.mobile.targets @@ -37,13 +37,13 @@ - false - false - false - false - false - true - true + false + false + false + false + false + true + true