Skip to content

Conversation

@trungnt2910
Copy link
Contributor

This contains a part of the code required to build CoreCLR and get paltests to pass on Haiku.

This commit covers src/coreclr/**, except the PAL files included in the previous commit.

Part of #55803.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 6, 2024
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@trungnt2910
Copy link
Contributor Author

Changes to doublemapping.cpp in this PR adds a POSIX fallback which should also fix #72192 (haven't tested that yet though).

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli
Copy link
Member

janvorli commented Nov 7, 2024

@trungnt2910 can you please resolve the conflict so that I can merge the change?

trungnt2910 and others added 2 commits November 8, 2024 13:20
This contains a part of the code required to build CoreCLR and get
`paltests` to pass on Haiku.

This commit covers `src/coreclr/**`, except the PAL files included
in the previous commit.

Co-authored-by: Jessica Hamilton <[email protected]>
This was removed in dotnet#103441 but required for Haiku builds.
@trungnt2910 trungnt2910 force-pushed the dev/trungnt2910/haiku-coreclr branch from 0b8188d to 1df901a Compare November 8, 2024 02:20
@trungnt2910
Copy link
Contributor Author

trungnt2910 commented Nov 8, 2024

Done.

Best to wait for the Haiku builds CI to succeed as well before merging though.

UPDATE: It's successful now.

@janvorli
Copy link
Member

janvorli commented Dec 6, 2024

@trungnt2910 I am sorry, I've missed you've added note that the Haiku build CI succeeded. Merging now.

@janvorli janvorli merged commit bf44aaa into dotnet:main Dec 6, 2024
148 of 150 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2025
@am11 am11 added the os-haiku label Apr 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-coreclr community-contribution Indicates that the PR has been added by a community member os-haiku

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants