Add Socket.Get/SetRawSocketOption (#33261)

stephentoub · web-flow · commit bf030341cd23 · 2020-03-06T17:35:39.000-05:00
diff --git a/src/libraries/Common/src/Interop/Unix/System.Native/Interop.GetSockOpt.cs b/src/libraries/Common/src/Interop/Unix/System.Native/Interop.GetSockOpt.cs
@@ -15,5 +15,8 @@ internal static partial class Sys
 
         [DllImport(Libraries.SystemNative, EntryPoint = "SystemNative_GetSockOpt")]
         internal static extern unsafe Error GetSockOpt(IntPtr socket, SocketOptionLevel optionLevel, SocketOptionName optionName, byte* optionValue, int* optionLen);
+
+        [DllImport(Libraries.SystemNative, EntryPoint = "SystemNative_GetRawSockOpt")]
+        internal static extern unsafe Error GetRawSockOpt(SafeHandle socket, int optionLevel, int optionName, byte* optionValue, int* optionLen);
     }
 }
diff --git a/src/libraries/Common/src/Interop/Unix/System.Native/Interop.SetSockOpt.cs b/src/libraries/Common/src/Interop/Unix/System.Native/Interop.SetSockOpt.cs
@@ -15,5 +15,8 @@ internal static partial class Sys
 
         [DllImport(Libraries.SystemNative, EntryPoint = "SystemNative_SetSockOpt")]
         internal static extern unsafe Error SetSockOpt(IntPtr socket, SocketOptionLevel optionLevel, SocketOptionName optionName, byte* optionValue, int optionLen);
+
+        [DllImport(Libraries.SystemNative, EntryPoint = "SystemNative_SetRawSockOpt")]
+        internal static extern unsafe Error SetRawSockOpt(SafeHandle socket, int optionLevel, int optionName, byte* optionValue, int optionLen);
     }
 }
diff --git a/src/libraries/Common/src/Interop/Windows/WinSock/Interop.getsockopt.cs b/src/libraries/Common/src/Interop/Windows/WinSock/Interop.getsockopt.cs
@@ -10,19 +10,11 @@ internal static partial class Interop
     internal static partial class Winsock
     {
         [DllImport(Interop.Libraries.Ws2_32, SetLastError = true)]
-        internal static extern SocketError getsockopt(
-            [In] SafeSocketHandle socketHandle,
-            [In] SocketOptionLevel optionLevel,
-            [In] SocketOptionName optionName,
-            [Out] out int optionValue,
-            [In, Out] ref int optionLength);
-
-        [DllImport(Interop.Libraries.Ws2_32, SetLastError = true)]
-        internal static extern SocketError getsockopt(
+        internal static unsafe extern SocketError getsockopt(
             [In] SafeSocketHandle socketHandle,
             [In] SocketOptionLevel optionLevel,
             [In] SocketOptionName optionName,
-            [Out] byte[] optionValue,
+            [Out] byte* optionValue,
             [In, Out] ref int optionLength);
 
         [DllImport(Interop.Libraries.Ws2_32, SetLastError = true)]
diff --git a/src/libraries/Common/src/Interop/Windows/WinSock/Interop.setsockopt.cs b/src/libraries/Common/src/Interop/Windows/WinSock/Interop.setsockopt.cs
@@ -28,11 +28,11 @@ internal static extern SocketError setsockopt(
             [In] int optionLength);
 
         [DllImport(Interop.Libraries.Ws2_32, SetLastError = true)]
-        internal static extern SocketError setsockopt(
+        internal static unsafe extern SocketError setsockopt(
             [In] SafeSocketHandle socketHandle,
             [In] SocketOptionLevel optionLevel,
             [In] SocketOptionName optionName,
-            [In] byte[]? optionValue,
+            [In] byte* optionValue,
             [In] int optionLength);
 
         [DllImport(Interop.Libraries.Ws2_32, SetLastError = true)]
diff --git a/src/libraries/Native/Unix/System.Native/pal_networking.c b/src/libraries/Native/Unix/System.Native/pal_networking.c
@@ -1986,6 +1986,26 @@ int32_t SystemNative_GetSockOpt(
     return Error_SUCCESS;
 }
 
+int32_t SystemNative_GetRawSockOpt(
+    intptr_t socket, int32_t socketOptionLevel, int32_t socketOptionName, uint8_t* optionValue, int32_t* optionLen)
+{
+    if (optionLen == NULL || *optionLen < 0)
+    {
+        return Error_EFAULT;
+    }
+
+    socklen_t optLen = (socklen_t)*optionLen;
+    int err = getsockopt(ToFileDescriptor(socket), socketOptionLevel, socketOptionName, optionValue, &optLen);
+    if (err != 0)
+    {
+        return SystemNative_ConvertErrorPlatformToPal(errno);
+    }
+
+    assert(optLen <= (socklen_t)*optionLen);
+    *optionLen = (int32_t)optLen;
+    return Error_SUCCESS;
+}
+
 int32_t
 SystemNative_SetSockOpt(intptr_t socket, int32_t socketOptionLevel, int32_t socketOptionName, uint8_t* optionValue, int32_t optionLen)
 {
@@ -2065,6 +2085,18 @@ SystemNative_SetSockOpt(intptr_t socket, int32_t socketOptionLevel, int32_t sock
     return err == 0 ? Error_SUCCESS : SystemNative_ConvertErrorPlatformToPal(errno);
 }
 
+int32_t SystemNative_SetRawSockOpt(
+    intptr_t socket, int32_t socketOptionLevel, int32_t socketOptionName, uint8_t* optionValue, int32_t optionLen)
+{
+    if (optionLen < 0 || optionValue == NULL)
+    {
+        return Error_EFAULT;
+    }
+
+    int err = setsockopt(ToFileDescriptor(socket), socketOptionLevel, socketOptionName, optionValue, (socklen_t)optionLen);
+    return err == 0 ? Error_SUCCESS : SystemNative_ConvertErrorPlatformToPal(errno);
+}
+
 static bool TryConvertSocketTypePalToPlatform(int32_t palSocketType, int* platformSocketType)
 {
     assert(platformSocketType != NULL);
diff --git a/src/libraries/Native/Unix/System.Native/pal_networking.h b/src/libraries/Native/Unix/System.Native/pal_networking.h
@@ -391,9 +391,15 @@ PALEXPORT int32_t SystemNative_GetSocketErrorOption(intptr_t socket, int32_t* er
 PALEXPORT int32_t SystemNative_GetSockOpt(
     intptr_t socket, int32_t socketOptionLevel, int32_t socketOptionName, uint8_t* optionValue, int32_t* optionLen);
 
+PALEXPORT int32_t SystemNative_GetRawSockOpt(
+    intptr_t socket, int32_t socketOptionLevel, int32_t socketOptionName, uint8_t* optionValue, int32_t* optionLen);
+
 PALEXPORT int32_t SystemNative_SetSockOpt(
     intptr_t socket, int32_t socketOptionLevel, int32_t socketOptionName, uint8_t* optionValue, int32_t optionLen);
 
+PALEXPORT int32_t SystemNative_SetRawSockOpt(
+    intptr_t socket, int32_t socketOptionLevel, int32_t socketOptionName, uint8_t* optionValue, int32_t optionLen);
+
 PALEXPORT int32_t SystemNative_Socket(int32_t addressFamily, int32_t socketType, int32_t protocolType, intptr_t* createdSocket);
 
 PALEXPORT int32_t SystemNative_GetAtOutOfBandMark(intptr_t socket, int32_t* available);
diff --git a/src/libraries/System.Net.Sockets/ref/System.Net.Sockets.cs b/src/libraries/System.Net.Sockets/ref/System.Net.Sockets.cs
@@ -309,6 +309,7 @@ public void EndDisconnect(System.IAsyncResult asyncResult) { }
         public void EndSendFile(System.IAsyncResult asyncResult) { }
         public int EndSendTo(System.IAsyncResult asyncResult) { throw null; }
         ~Socket() { }
+        public int GetRawSocketOption(int optionLevel, int optionName, System.Span<byte> optionValue) { throw null; }
         public object? GetSocketOption(System.Net.Sockets.SocketOptionLevel optionLevel, System.Net.Sockets.SocketOptionName optionName) { throw null; }
         public void GetSocketOption(System.Net.Sockets.SocketOptionLevel optionLevel, System.Net.Sockets.SocketOptionName optionName, byte[] optionValue) { }
         public byte[] GetSocketOption(System.Net.Sockets.SocketOptionLevel optionLevel, System.Net.Sockets.SocketOptionName optionName, int optionLength) { throw null; }
@@ -358,6 +359,7 @@ public void SendFile(string? fileName, byte[]? preBuffer, byte[]? postBuffer, Sy
         public int SendTo(byte[] buffer, System.Net.Sockets.SocketFlags socketFlags, System.Net.EndPoint remoteEP) { throw null; }
         public bool SendToAsync(System.Net.Sockets.SocketAsyncEventArgs e) { throw null; }
         public void SetIPProtectionLevel(System.Net.Sockets.IPProtectionLevel level) { }
+        public void SetRawSocketOption(int optionLevel, int optionName, System.ReadOnlySpan<byte> optionValue) { }
         public void SetSocketOption(System.Net.Sockets.SocketOptionLevel optionLevel, System.Net.Sockets.SocketOptionName optionName, bool optionValue) { }
         public void SetSocketOption(System.Net.Sockets.SocketOptionLevel optionLevel, System.Net.Sockets.SocketOptionName optionName, byte[] optionValue) { }
         public void SetSocketOption(System.Net.Sockets.SocketOptionLevel optionLevel, System.Net.Sockets.SocketOptionName optionName, int optionValue) { }
diff --git a/src/libraries/System.Net.Sockets/src/System/Net/Sockets/ConnectOverlappedAsyncResult.Windows.cs b/src/libraries/System.Net.Sockets/src/System/Net/Sockets/ConnectOverlappedAsyncResult.Windows.cs
@@ -8,7 +8,7 @@ namespace System.Net.Sockets
     internal sealed partial class ConnectOverlappedAsyncResult : BaseOverlappedAsyncResult
     {
         // This method is called by base.CompletionPortCallback base.OverlappedCallback as part of IO completion
-        internal override object? PostCompletion(int numBytes)
+        internal override unsafe object? PostCompletion(int numBytes)
         {
             SocketError errorCode = (SocketError)ErrorCode;
             Socket socket = (Socket)AsyncObject;
diff --git a/src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs b/src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
@@ -1818,6 +1818,20 @@ public void SetSocketOption(SocketOptionLevel optionLevel, SocketOptionName opti
             }
         }
 
+        public void SetRawSocketOption(int optionLevel, int optionName, ReadOnlySpan<byte> optionValue)
+        {
+            ThrowIfDisposed();
+
+            SocketError errorCode = SocketPal.SetRawSockOpt(_handle, optionLevel, optionName, optionValue);
+
+            if (NetEventSource.IsEnabled) NetEventSource.Info(this, $"SetSockOpt optionLevel:{optionLevel} optionName:{optionName} returns errorCode:{errorCode}");
+
+            if (errorCode != SocketError.Success)
+            {
+                UpdateStatusAfterSocketErrorAndThrowException(errorCode);
+            }
+        }
+
         // Gets the value of a socket option.
         public object? GetSocketOption(SocketOptionLevel optionLevel, SocketOptionName optionName)
         {
@@ -1894,7 +1908,7 @@ public byte[] GetSocketOption(SocketOptionLevel optionLevel, SocketOptionName op
                 optionValue,
                 ref realOptionLength);
 
-            if (NetEventSource.IsEnabled) NetEventSource.Info(this, $"Interop.Winsock.getsockopt returns errorCode:{errorCode}");
+            if (NetEventSource.IsEnabled) NetEventSource.Info(this, $"GetSockOpt returned errorCode:{errorCode}");
 
             // Throw an appropriate SocketException if the native call fails.
             if (errorCode != SocketError.Success)
@@ -1912,6 +1926,23 @@ public byte[] GetSocketOption(SocketOptionLevel optionLevel, SocketOptionName op
             return optionValue;
         }
 
+        public int GetRawSocketOption(int optionLevel, int optionName, Span<byte> optionValue)
+        {
+            ThrowIfDisposed();
+
+            int realOptionLength = optionValue.Length;
+            SocketError errorCode = SocketPal.GetRawSockOpt(_handle, optionLevel, optionName, optionValue, ref realOptionLength);
+
+            if (NetEventSource.IsEnabled) NetEventSource.Info(this, $"GetRawSockOpt optionLevel:{optionLevel} optionName:{optionName} returned errorCode:{errorCode}");
+
+            if (errorCode != SocketError.Success)
+            {
+                UpdateStatusAfterSocketErrorAndThrowException(errorCode);
+            }
+
+            return realOptionLength;
+        }
+
         public void SetIPProtectionLevel(IPProtectionLevel level)
         {
             if (level == IPProtectionLevel.Unspecified)
diff --git a/src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.Windows.cs b/src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.Windows.cs
@@ -1156,7 +1156,7 @@ out remoteSocketAddress.InternalSize
             return socketError;
         }
 
-        private SocketError FinishOperationConnect()
+        private unsafe SocketError FinishOperationConnect()
         {
             try
             {
diff --git a/src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs b/src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
@@ -1218,6 +1218,27 @@ public static unsafe SocketError SetSockOpt(SafeSocketHandle handle, SocketOptio
             }
         }
 
+        public static unsafe SocketError SetRawSockOpt(SafeSocketHandle handle, int optionLevel, int optionName, ReadOnlySpan<byte> optionValue)
+        {
+            fixed (byte* optionValuePtr = optionValue)
+            {
+                Interop.Error err = Interop.Sys.SetRawSockOpt(handle, optionLevel, optionName, optionValuePtr, optionValue.Length);
+
+                if (err == Interop.Error.SUCCESS)
+                {
+                    // When dealing with SocketOptionLevel/SocketOptionName, we know what the values mean and can use GetErrorAndTrackSetting
+                    // to keep track of changed values.  But since we don't know what these levels/names mean (hence, "raw"), we have to
+                    // assume it's not tracked, and thus call SetExposed.  It's a reasonable assumption, given that the only values we
+                    // track are ones for which we have portable names, and if a portable name exists for it, why would the caller choose
+                    // the more difficult path of using the "raw" level/name?
+                    handle.SetExposed();
+                    return SocketError.Success;
+                }
+
+                return GetSocketErrorForErrorCode(err);
+            }
+        }
+
         public static unsafe SocketError SetMulticastOption(SafeSocketHandle handle, SocketOptionName optionName, MulticastOption optionValue)
         {
             Debug.Assert(optionName == SocketOptionName.AddMembership || optionName == SocketOptionName.DropMembership, $"Unexpected optionName: {optionName}");
@@ -1358,6 +1379,25 @@ public static unsafe SocketError GetSockOpt(SafeSocketHandle handle, SocketOptio
             return GetSocketErrorForErrorCode(err);
         }
 
+        public static unsafe SocketError GetRawSockOpt(SafeSocketHandle handle, int optionLevel, int optionName, Span<byte> optionValue, ref int optionLength)
+        {
+            Debug.Assert((uint)optionLength <= optionValue.Length);
+
+            int optLen = optionLength;
+            fixed (byte* pinnedValue = optionValue)
+            {
+                Interop.Error err = Interop.Sys.GetRawSockOpt(handle, optionLevel, optionName, pinnedValue, &optLen);
+
+                if (err == Interop.Error.SUCCESS)
+                {
+                    optionLength = optLen;
+                    return SocketError.Success;
+                }
+
+                return GetSocketErrorForErrorCode(err);
+            }
+        }
+
         public static unsafe SocketError GetMulticastOption(SafeSocketHandle handle, SocketOptionName optionName, out MulticastOption? optionValue)
         {
             Debug.Assert(optionName == SocketOptionName.AddMembership || optionName == SocketOptionName.DropMembership, $"Unexpected optionName={optionName}");
diff --git a/src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Windows.cs b/src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Windows.cs
@@ -587,7 +587,7 @@ public static unsafe SocketError SetSockOpt(SafeSocketHandle handle, SocketOptio
             return errorCode == SocketError.SocketError ? GetLastSocketError() : SocketError.Success;
         }
 
-        public static SocketError SetSockOpt(SafeSocketHandle handle, SocketOptionLevel optionLevel, SocketOptionName optionName, byte[] optionValue)
+        public static unsafe SocketError SetSockOpt(SafeSocketHandle handle, SocketOptionLevel optionLevel, SocketOptionName optionName, byte[] optionValue)
         {
             SocketError errorCode;
             if (optionLevel == SocketOptionLevel.Tcp &&
@@ -596,18 +596,33 @@ public static SocketError SetSockOpt(SafeSocketHandle handle, SocketOptionLevel
             {
                 return IOControlKeepAlive.Set(handle, optionName, optionValue);
             }
-            else
+
+            fixed (byte* optionValuePtr = optionValue)
             {
                 errorCode = Interop.Winsock.setsockopt(
                     handle,
                     optionLevel,
                     optionName,
-                    optionValue,
+                    optionValuePtr,
                     optionValue != null ? optionValue.Length : 0);
                 return errorCode == SocketError.SocketError ? GetLastSocketError() : SocketError.Success;
             }
         }
 
+        public static unsafe SocketError SetRawSockOpt(SafeSocketHandle handle, int optionLevel, int optionName, ReadOnlySpan<byte> optionValue)
+        {
+            fixed (byte* optionValuePtr = optionValue)
+            {
+                SocketError errorCode = Interop.Winsock.setsockopt(
+                    handle,
+                    (SocketOptionLevel)optionLevel,
+                    (SocketOptionName)optionName,
+                    optionValuePtr,
+                    optionValue.Length);
+                return errorCode == SocketError.SocketError ? GetLastSocketError() : SocketError.Success;
+            }
+        }
+
         public static void SetReceivingDualModeIPv4PacketInformation(Socket socket)
         {
             socket.SetSocketOption(SocketOptionLevel.IP, SocketOptionName.PacketInformation, true);
@@ -696,7 +711,7 @@ public static void SetIPProtectionLevel(Socket socket, SocketOptionLevel optionL
             socket.SetSocketOption(optionLevel, SocketOptionName.IPProtectionLevel, protectionLevel);
         }
 
-        public static SocketError GetSockOpt(SafeSocketHandle handle, SocketOptionLevel optionLevel, SocketOptionName optionName, out int optionValue)
+        public static unsafe SocketError GetSockOpt(SafeSocketHandle handle, SocketOptionLevel optionLevel, SocketOptionName optionName, out int optionValue)
         {
             if (optionLevel == SocketOptionLevel.Tcp &&
                 (optionName == SocketOptionName.TcpKeepAliveTime || optionName == SocketOptionName.TcpKeepAliveInterval) &&
@@ -706,17 +721,20 @@ public static SocketError GetSockOpt(SafeSocketHandle handle, SocketOptionLevel
                 return SocketError.Success;
             }
 
-            int optionLength = 4; // sizeof(int)
+            int optionLength = sizeof(int);
+            int tmpOptionValue = 0;
             SocketError errorCode = Interop.Winsock.getsockopt(
                 handle,
                 optionLevel,
                 optionName,
-                out optionValue,
+                (byte*)&tmpOptionValue,
                 ref optionLength);
+
+            optionValue = tmpOptionValue;
             return errorCode == SocketError.SocketError ? GetLastSocketError() : SocketError.Success;
         }
 
-        public static SocketError GetSockOpt(SafeSocketHandle handle, SocketOptionLevel optionLevel, SocketOptionName optionName, byte[] optionValue, ref int optionLength)
+        public static unsafe SocketError GetSockOpt(SafeSocketHandle handle, SocketOptionLevel optionLevel, SocketOptionName optionName, byte[] optionValue, ref int optionLength)
         {
             if (optionLevel == SocketOptionLevel.Tcp &&
                 (optionName == SocketOptionName.TcpKeepAliveTime || optionName == SocketOptionName.TcpKeepAliveInterval) &&
@@ -725,13 +743,33 @@ public static SocketError GetSockOpt(SafeSocketHandle handle, SocketOptionLevel
                 return IOControlKeepAlive.Get(handle, optionName, optionValue, ref optionLength);
             }
 
-            SocketError errorCode = Interop.Winsock.getsockopt(
-               handle,
-               optionLevel,
-               optionName,
-               optionValue,
-               ref optionLength);
-            return errorCode == SocketError.SocketError ? GetLastSocketError() : SocketError.Success;
+            fixed (byte* optionValuePtr = optionValue)
+            {
+                SocketError errorCode = Interop.Winsock.getsockopt(
+                   handle,
+                   optionLevel,
+                   optionName,
+                   optionValuePtr,
+                   ref optionLength);
+                return errorCode == SocketError.SocketError ? GetLastSocketError() : SocketError.Success;
+            }
+        }
+
+        public static unsafe SocketError GetRawSockOpt(SafeSocketHandle handle, int optionLevel, int optionName, Span<byte> optionValue, ref int optionLength)
+        {
+            Debug.Assert((uint)optionLength <= optionValue.Length);
+
+            SocketError errorCode;
+            fixed (byte* optionValuePtr = optionValue)
+            {
+                errorCode = Interop.Winsock.getsockopt(
+                    handle,
+                    (SocketOptionLevel)optionLevel,
+                    (SocketOptionName)optionName,
+                    optionValuePtr,
+                    ref optionLength);
+                return errorCode == SocketError.SocketError ? GetLastSocketError() : SocketError.Success;
+            }
         }
 
         public static SocketError GetMulticastOption(SafeSocketHandle handle, SocketOptionName optionName, out MulticastOption? optionValue)
diff --git a/src/libraries/System.Net.Sockets/tests/FunctionalTests/DisposedSocketTests.cs b/src/libraries/System.Net.Sockets/tests/FunctionalTests/DisposedSocketTests.cs
diff --git a/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.Unix.cs b/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.Unix.cs
diff --git a/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.Windows.cs b/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.Windows.cs
diff --git a/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs b/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs
diff --git a/src/libraries/System.Net.Sockets/tests/FunctionalTests/System.Net.Sockets.Tests.csproj b/src/libraries/System.Net.Sockets/tests/FunctionalTests/System.Net.Sockets.Tests.csproj

Original file line number	Diff line number	Diff line change
`@@ -15,5 +15,8 @@ internal static partial class Sys`
`15`	`15`
`16`	`16`	`[DllImport(Libraries.SystemNative, EntryPoint = "SystemNative_GetSockOpt")]`
`17`	`17`	`internal static extern unsafe Error GetSockOpt(IntPtr socket, SocketOptionLevel optionLevel, SocketOptionName optionName, byte* optionValue, int* optionLen);`
	`18`	`+`
	`19`	`+ [DllImport(Libraries.SystemNative, EntryPoint = "SystemNative_GetRawSockOpt")]`
	`20`	`+ internal static extern unsafe Error GetRawSockOpt(SafeHandle socket, int optionLevel, int optionName, byte* optionValue, int* optionLen);`
`18`	`21`	`}`
`19`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ namespace System.Net.Sockets`
`8`	`8`	`internal sealed partial class ConnectOverlappedAsyncResult : BaseOverlappedAsyncResult`
`9`	`9`	`{`
`10`	`10`	`// This method is called by base.CompletionPortCallback base.OverlappedCallback as part of IO completion`
`11`		`- internal override object? PostCompletion(int numBytes)`
	`11`	`+ internal override unsafe object? PostCompletion(int numBytes)`
`12`	`12`	`{`
`13`	`13`	`SocketError errorCode = (SocketError)ErrorCode;`
`14`	`14`	`Socket socket = (Socket)AsyncObject;`
Original file line number	Diff line number	Diff line change
`@@ -1156,7 +1156,7 @@ out remoteSocketAddress.InternalSize`
`1156`	`1156`	`return socketError;`
`1157`	`1157`	`}`
`1158`	`1158`
`1159`		`- private SocketError FinishOperationConnect()`
	`1159`	`+ private unsafe SocketError FinishOperationConnect()`
`1160`	`1160`	`{`
`1161`	`1161`	`try`
`1162`	`1162`	`{`