Fix TimeSpan in tests

Author: eduardo-vp

src/libraries/System.Private.CoreLib/src/System/Threading/SemaphoreSlim.cs

@@ -262,7 +262,7 @@ public bool Wait(TimeSpan timeout, CancellationToken cancellationToken)
             }
 
             // Call wait with the timeout milliseconds
-            return Wait(totalMilliseconds == timeout.Infinite ? Timeout.UnsignedInfinite : (uint)totalMilliseconds, cancellationToken);
+            return Wait(totalMilliseconds == Timeout.Infinite ? Timeout.UnsignedInfinite : (uint)totalMilliseconds, cancellationToken);
         }
 
         /// <summary>

src/libraries/System.Threading/tests/SemaphoreSlimTests.cs

@@ -60,7 +60,7 @@ public static void RunSemaphoreSlimTest1_Wait()
             RunSemaphoreSlimTest1_Wait_Helper(10, 10, 10, true, null);
             RunSemaphoreSlimTest1_Wait_Helper(1, 10, 10, true, null);
             RunSemaphoreSlimTest1_Wait_Helper(0, 10, 10, false, null);
-            RunSemaphoreSlimTest1_Wait_Helper(1, 10, new TimeSpan(0, 0, Timer.MaxSupportedTimeout), true, null);
+            RunSemaphoreSlimTest1_Wait_Helper(1, 10, TimeSpan.FromMilliseconds(Timer.MaxSupportedTimeout), true, null);
         }
 
         [Fact]
@@ -69,7 +69,7 @@ public static void RunSemaphoreSlimTest1_Wait_NegativeCases()
             // Invalid timeout
             RunSemaphoreSlimTest1_Wait_Helper(10, 10, -10, true, typeof(ArgumentOutOfRangeException));
             RunSemaphoreSlimTest1_Wait_Helper
-               (10, 10, new TimeSpan(0, 0, Timer.MaxSupportedTimeout + 1), true, typeof(ArgumentOutOfRangeException));
+               (10, 10, TimeSpan.FromMilliseconds(Timer.MaxSupportedTimeout + 1), true, typeof(ArgumentOutOfRangeException));
         }
 
         [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
@@ -88,7 +88,7 @@ public static void RunSemaphoreSlimTest1_WaitAsync()
             RunSemaphoreSlimTest1_WaitAsync_Helper(10, 10, 10, true, null);
             RunSemaphoreSlimTest1_WaitAsync_Helper(1, 10, 10, true, null);
             RunSemaphoreSlimTest1_WaitAsync_Helper(0, 10, 10, false, null);
-            RunSemaphoreSlimTest1_WaitAsync_Helper(1, 10, new TimeSpan(0, 0, Timer.MaxSupportedTimeout), true, null);
+            RunSemaphoreSlimTest1_WaitAsync_Helper(1, 10, TimeSpan.FromMilliseconds(Timer.MaxSupportedTimeout), true, null);
         }
 
         [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
@@ -98,7 +98,7 @@ public static void RunSemaphoreSlimTest1_WaitAsync_NegativeCases()
             // Invalid timeout
             RunSemaphoreSlimTest1_WaitAsync_Helper(10, 10, -10, true, typeof(ArgumentOutOfRangeException));
             RunSemaphoreSlimTest1_WaitAsync_Helper
-               (10, 10, new TimeSpan(0, 0, Timer.MaxSupportedTimeout + 1), true, typeof(ArgumentOutOfRangeException));
+               (10, 10, TimeSpan.FromMilliseconds(Timer.MaxSupportedTimeout + 1), true, typeof(ArgumentOutOfRangeException));
             RunSemaphoreSlimTest1_WaitAsync2();
         }