[wasm] WBT: workload installation cleanup

Author: radical

src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs

@@ -97,9 +97,14 @@ public override bool Execute()
                 }
 
                 string cachePath = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());
+                string lastTargetPath = string.Empty;
                 foreach (InstallWorkloadRequest req in selectedRequests)
                 {
-                    Log.LogMessage(MessageImportance.High, $"** Installing workload {req.WorkloadId} in {req.TargetPath} **");
+                    if (req.TargetPath != lastTargetPath)
+                        Log.LogMessage(MessageImportance.High, $"{Environment.NewLine}** Preparing {req.TargetPath} **");
+                    lastTargetPath = req.TargetPath;
+
+                    Log.LogMessage(MessageImportance.High, $"    - {req.WorkloadId}: Installing workload");
                     if (!req.Validate(Log))
                         return false;
 
@@ -159,11 +164,11 @@ private bool InstallAllManifests()
 
                 if (manifestsInstalled.Contains(req.ManifestName))
                 {
-                    Log.LogMessage(MessageImportance.High, $"{Environment.NewLine}** Manifests for workload {req.WorkloadId} are already installed **{Environment.NewLine}");
+                    Log.LogMessage(MessageImportance.High, $"** {req.WorkloadId}: Manifests are already installed **");
                     continue;
                 }
 
-                Log.LogMessage(MessageImportance.High, $"{Environment.NewLine}** Installing manifests for workload {req.WorkloadId} **");
+                Log.LogMessage(MessageImportance.High, $"{Environment.NewLine}** {req.WorkloadId}: Installing manifests **");
                 if (!InstallWorkloadManifest(workload,
                                              req.ManifestName,
                                              req.Version,
@@ -230,13 +235,13 @@ private bool InstallPacks(InstallWorkloadRequest req, string nugetConfigContents
                                                     Path.Combine(req.TargetPath, "dotnet"),
                                                     $"workload install --skip-manifest-update --no-cache --configfile \"{nugetConfigPath}\" {req.WorkloadId}",
                                                     workingDir: Path.GetTempPath(),
-                                                    silent: false,
                                                     logStdErrAsMessage: req.IgnoreErrors,
-                                                    debugMessageImportance: MessageImportance.High);
+                                                    debugMessageImportance: MessageImportance.Normal);
             if (exitCode != 0)
             {
                 if (req.IgnoreErrors)
                 {
+                    Log.LogMessage(MessageImportance.High, output);
                     Log.LogMessage(MessageImportance.High,
                                     $"{Environment.NewLine} ** Ignoring workload installation failure exit code {exitCode}. **{Environment.NewLine}");
                 }
@@ -245,6 +250,7 @@ private bool InstallPacks(InstallWorkloadRequest req, string nugetConfigContents
                     Log.LogError($"workload install failed with exit code {exitCode}: {output}");
                 }
 
+                Log.LogMessage(MessageImportance.Low, $"List of the relevant paths in {req.TargetPath}");
                 foreach (string dir in Directory.EnumerateDirectories(Path.Combine(req.TargetPath, "sdk-manifests"), "*", SearchOption.AllDirectories))
                     Log.LogMessage(MessageImportance.Low, $"\t{Path.Combine(req.TargetPath, "sdk-manifests", dir)}");
 
@@ -257,7 +263,7 @@ private bool InstallPacks(InstallWorkloadRequest req, string nugetConfigContents
 
         private void UpdateAppRef(string sdkPath, string version)
         {
-            Log.LogMessage(MessageImportance.High, $"{Environment.NewLine}** Updating Targeting pack **{Environment.NewLine}");
+            Log.LogMessage(MessageImportance.Normal, $"    - Updating Targeting pack");
 
             string pkgPath = Path.Combine(LocalNuGetsPath, $"Microsoft.NETCore.App.Ref.{version}.nupkg");
             if (!File.Exists(pkgPath))
@@ -291,7 +297,7 @@ private string GetNuGetConfig()
 
         private bool InstallWorkloadManifest(ITaskItem workloadId, string name, string version, string sdkDir, string nugetConfigContents, bool stopOnMissing)
         {
-            Log.LogMessage(MessageImportance.High, $"    ** Installing manifest: {name}/{version}");
+            Log.LogMessage(MessageImportance.High, $"    - Installing manifest: {name}/{version}");
 
             // Find any existing directory with the manifest name, ignoring the case
             // Multiple directories for a manifest, differing only in case causes