Add check for unloaded types in GetAppDomainStaticAddress (#34677)

Fixes #33367

When a module is unloaded, the managed objectref is collected during a GC before the profiler is notified that the module is unloading. That means if you call in to GetAppDomainStaticAddress between when the object is collected and when you are notified about the module unload (GarbageCollectionFinished is a place that will hit this every time) it will cause an AV from trying to use the null objectref.

This fix prevents this AV by checking to see if the object's loaderheap or managed loaderheap object ref are invalid first.

Author: davmason

src/coreclr/src/vm/proftoeeinterfaceimpl.cpp

@@ -3145,6 +3145,12 @@ HRESULT ProfToEEInterfaceImpl::GetAppDomainStaticAddress(ClassID classId,
         return CORPROF_E_DATAINCOMPLETE;
     }
 
+    if (typeHandle.GetModule()->GetLoaderAllocator() == NULL ||
+        typeHandle.GetModule()->GetLoaderAllocator()->GetExposedObject() == NULL)
+    {
+        return CORPROF_E_DATAINCOMPLETE;
+    }
+
     //
     // Get the field descriptor object
     //

src/coreclr/tests/src/profiler/native/CMakeLists.txt

@@ -5,9 +5,10 @@ project(Profiler)
 set(GCBASIC_SOURCES gcbasicprofiler/gcbasicprofiler.cpp)
 set(REJIT_SOURCES rejitprofiler/rejitprofiler.cpp rejitprofiler/ilrewriter.cpp rejitprofiler/sigparse.cpp)
 set(EVENTPIPE_SOURCES eventpipeprofiler/eventpipeprofiler.cpp)
-set(UNITTEST_SOURCES unittestprofiler/unittestprofiler.cpp)
+set(METADATAGETDISPENSER_SOURCES metadatagetdispenser/metadatagetdispenser.cpp)
+set(GETAPPDOMAINSTATICADDRESS_SOURCES getappdomainstaticaddress/getappdomainstaticaddress.cpp)
 
-set(SOURCES ${GCBASIC_SOURCES} ${REJIT_SOURCES} ${EVENTPIPE_SOURCES} ${UNITTEST_SOURCES} profiler.def profiler.cpp classfactory.cpp dllmain.cpp guids.cpp)
+set(SOURCES ${GCBASIC_SOURCES} ${REJIT_SOURCES} ${EVENTPIPE_SOURCES} ${METADATAGETDISPENSER_SOURCES} ${GETAPPDOMAINSTATICADDRESS_SOURCES} profiler.def profiler.cpp classfactory.cpp dllmain.cpp guids.cpp)
 
 include_directories(../../../../src/pal/prebuilt/inc)
 

src/coreclr/tests/src/profiler/native/classfactory.cpp

@@ -6,7 +6,8 @@
 #include "gcbasicprofiler/gcbasicprofiler.h"
 #include "rejitprofiler/rejitprofiler.h"
 #include "eventpipeprofiler/eventpipeprofiler.h"
-#include "unittestprofiler/unittestprofiler.h"
+#include "metadatagetdispenser/metadatagetdispenser.h"
+#include "getappdomainstaticaddress/getappdomainstaticaddress.h"
 
 ClassFactory::ClassFactory(REFCLSID clsid) : refCount(0), clsid(clsid)
 {
@@ -58,7 +59,8 @@ HRESULT STDMETHODCALLTYPE ClassFactory::CreateInstance(IUnknown *pUnkOuter, REFI
 		new GCBasicProfiler(),
         new ReJITProfiler(),
         new EventPipeProfiler(),
-        new UnitTestProfiler()
+        new MetaDataGetDispenser(),
+        new GetAppDomainStaticAddress()
 		// add new profilers here
 	};