Skip to content

Commit 01c9a84

Browse files
authored
[mono] Reenable disabled tests as mono now respects non-public custom attributes in dynamic assemblies (#88322)
* Reenable disabled tests * Disable Roslyn analyzer tests in the browser as Monitor.Wait / Monitor.Pulse are not supported on single-threaded WASM Contributes to: #60650
1 parent 79c2669 commit 01c9a84

16 files changed

+1
-20
lines changed

src/libraries/System.Private.CoreLib/tests/IntrinsicsInSystemPrivatecoreLibAnalyzer.Tests/IntrinsicsInSystemPrivateCoreLibUnitTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
namespace IntrinsicsInSystemPrivateCoreLib.Test
77
{
8-
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
8+
[SkipOnPlatform(TestPlatforms.Browser, "Do not try to run analyzer tests in the browser")]
99
public class IntrinsicsInSystemPrivateCoreLibUnitTest
1010
{
1111
string BoilerPlate = @"

src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/AddGeneratedComClassTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
namespace ComInterfaceGenerator.Unit.Tests
1111
{
12-
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
1312
public class AddGeneratedComClassTests
1413
{
1514
[Fact]

src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/ComHostingDoesNotSupportGeneratedComInterfaceTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
namespace ComInterfaceGenerator.Unit.Tests
1010
{
11-
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
1211
public class ComHostingDoesNotSupportGeneratedComInterfaceTests
1312
{
1413
[InlineData(true)]

src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/ConvertToGeneratedComInterfaceTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
namespace ComInterfaceGenerator.Unit.Tests
1111
{
12-
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
1312
public class ConvertToGeneratedComInterfaceTests
1413
{
1514
[Fact]

src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/GeneratedComInterfaceAnalyzerTests.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111

1212
namespace ComInterfaceGenerator.Unit.Tests
1313
{
14-
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
1514
public class GeneratedComInterfaceAnalyzerTests
1615
{
1716
static string _usings = $$"""
@@ -21,7 +20,6 @@ public class GeneratedComInterfaceAnalyzerTests
2120
#pragma warning restore CS8019
2221
""";
2322

24-
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
2523
public class InterfaceHasInterfaceTypeAttributeOnly
2624
{
2725
[Fact]
@@ -143,7 +141,6 @@ void Bar() {}
143141
}
144142
}
145143

146-
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
147144
public class InterfaceHasGeneratedComInterfaceAttributeOnly
148145
{
149146
[Fact]
@@ -162,7 +159,6 @@ void Bar() {}
162159
}
163160
}
164161

165-
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
166162
public class InterfaceHasGeneratedComInterfaceAttributeAndInterfaceTypeAttribute
167163
{
168164
[Fact]
@@ -318,7 +314,6 @@ await VerifyCS.VerifyAnalyzerAsync(
318314
}
319315
}
320316

321-
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
322317
public class PartialInterfaceHasGeneratedComInterfaceAttributeAndInterfaceTypeAttribute
323318
{
324319
[Fact]

src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/RuntimeComApiUsageWithSourceGeneratedComTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
namespace ComInterfaceGenerator.Unit.Tests
1212
{
13-
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
1413
public class RuntimeComApiUsageWithSourceGeneratedComTests
1514
{
1615
[Fact]

src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/AddDisableRuntimeMarshallingAttributeFixerTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
namespace LibraryImportGenerator.UnitTests
1818
{
19-
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
2019
public class AddDisableRuntimeMarshallingAttributeFixerTests
2120
{
2221
[Fact]

src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/ConvertToLibraryImportAnalyzerTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
namespace LibraryImportGenerator.UnitTests
1616
{
17-
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
1817
public class ConvertToLibraryImportAnalyzerTests
1918
{
2019
public static IEnumerable<object[]> MarshallingRequiredTypes() => new[]

src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/ConvertToLibraryImportFixerTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919

2020
namespace LibraryImportGenerator.UnitTests
2121
{
22-
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
2322
public class ConvertToLibraryImportFixerTests
2423
{
2524
private const string ConvertToLibraryImportKey = "ConvertToLibraryImport";

src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_AttributeUsage.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616
namespace LibraryImportGenerator.UnitTests
1717
{
18-
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
1918
public class CustomMarshallerAttributeAnalyzerTests_AttributeUsage
2019
{
2120
[Fact]

0 commit comments

Comments
 (0)