Revert "Allow FileWritesShared to be tracked and cleaned with an opt-in flag" #12239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a feature that allowed FileWritesShareable to be tracked and cleaned outside of the project directory with an opt-in flag. The revert removes the TrackFileWritesShareableOutsideOfProjectDirectory property and associated logic that was added to support .NET SDK's Artifacts Layout feature.
- Removes the TrackFileWritesShareableOutsideOfProjectDirectory property and its default value
- Eliminates the FilesToTrackFromOutputDirectories item group that conditionally included FileWritesShareable
- Restores the original behavior where only FileWrites (not FileWritesShareable) are tracked in output directories
|
Hold on this one - the VMR may fix-forward with #12236 instead. |
YuliiaKovalova
approved these changes
Aug 1, 2025
SimaTian
approved these changes
Aug 1, 2025
YuliiaKovalova
deleted the
revert-12096-allow-tracking-filewrites-outside-project-cone
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #12096
The rootcause is tracked internally: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2533238/