Skip to content

Conversation

@LittleLittleCloud
Copy link
Member

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

#7169

@LittleLittleCloud LittleLittleCloud mentioned this pull request Aug 29, 2024
13 tasks
@codecov
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.

Project coverage is 68.82%. Comparing base (70e5ab1) to head (15448e1).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/Microsoft.ML.GenAI.Phi/Phi3/Phi3ForCasualLM.cs 0.00% 30 Missing ⚠️
...crosoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7227      +/-   ##
==========================================
- Coverage   68.83%   68.82%   -0.01%     
==========================================
  Files        1453     1453              
  Lines      271482   271525      +43     
  Branches    28090    28094       +4     
==========================================
+ Hits       186863   186884      +21     
- Misses      77400    77418      +18     
- Partials     7219     7223       +4     
Flag Coverage Δ
Debug 68.82% <0.00%> (-0.01%) ⬇️
production 63.34% <0.00%> (-0.01%) ⬇️
test 89.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...crosoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs 0.00% <0.00%> (ø)
src/Microsoft.ML.GenAI.Phi/Phi3/Phi3ForCasualLM.cs 12.28% <0.00%> (-13.65%) ⬇️

... and 10 files with indirect coverage changes

Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@LittleLittleCloud LittleLittleCloud merged commit 7c937bf into dotnet:main Aug 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants