From a70f98675a61815c7aa18230b863ac640caadbb3 Mon Sep 17 00:00:00 2001 From: Aleksei Smirnov Date: Tue, 12 Sep 2023 12:41:27 +0300 Subject: [PATCH 01/10] Add performance tests --- Microsoft.ML.sln | 11 ++++++ ...soft.Data.Analysis.PerformanceTests.csproj | 18 ++++++++++ .../PerformanceTests.cs | 34 +++++++++++++++++++ .../Program.cs | 17 ++++++++++ 4 files changed, 80 insertions(+) create mode 100644 test/Microsoft.Data.Analysis.PerformanceTests/Microsoft.Data.Analysis.PerformanceTests.csproj create mode 100644 test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs create mode 100644 test/Microsoft.Data.Analysis.PerformanceTests/Program.cs diff --git a/Microsoft.ML.sln b/Microsoft.ML.sln index d22e7ee013..5e81a5f3b0 100644 --- a/Microsoft.ML.sln +++ b/Microsoft.ML.sln @@ -168,6 +168,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.Tokenizers.Tes EndProject Project("{6EC3EE1D-3C4E-46DD-8F32-0CC8E7565705}") = "Microsoft.ML.FSharp.Tests", "test\Microsoft.ML.FSharp.Tests\Microsoft.ML.FSharp.Tests.fsproj", "{041CB5CD-5832-413E-A894-D9DBED210B16}" EndProject +Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.Data.Analysis.PerformanceTests", "test\Microsoft.Data.Analysis.PerformanceTests\Microsoft.Data.Analysis.PerformanceTests.csproj", "{FB8A8823-CC6C-4C2F-8539-05FBFB7C91CD}" +EndProject Global GlobalSection(SolutionConfigurationPlatforms) = preSolution Debug|Any CPU = Debug|Any CPU @@ -788,6 +790,14 @@ Global {041CB5CD-5832-413E-A894-D9DBED210B16}.Release|Any CPU.Build.0 = Release|Any CPU {041CB5CD-5832-413E-A894-D9DBED210B16}.Release|x64.ActiveCfg = Release|Any CPU {041CB5CD-5832-413E-A894-D9DBED210B16}.Release|x64.Build.0 = Release|Any CPU + {FB8A8823-CC6C-4C2F-8539-05FBFB7C91CD}.Debug|Any CPU.ActiveCfg = Debug|Any CPU + {FB8A8823-CC6C-4C2F-8539-05FBFB7C91CD}.Debug|Any CPU.Build.0 = Debug|Any CPU + {FB8A8823-CC6C-4C2F-8539-05FBFB7C91CD}.Debug|x64.ActiveCfg = Debug|Any CPU + {FB8A8823-CC6C-4C2F-8539-05FBFB7C91CD}.Debug|x64.Build.0 = Debug|Any CPU + {FB8A8823-CC6C-4C2F-8539-05FBFB7C91CD}.Release|Any CPU.ActiveCfg = Release|Any CPU + {FB8A8823-CC6C-4C2F-8539-05FBFB7C91CD}.Release|Any CPU.Build.0 = Release|Any CPU + {FB8A8823-CC6C-4C2F-8539-05FBFB7C91CD}.Release|x64.ActiveCfg = Release|Any CPU + {FB8A8823-CC6C-4C2F-8539-05FBFB7C91CD}.Release|x64.Build.0 = Release|Any CPU EndGlobalSection GlobalSection(SolutionProperties) = preSolution HideSolutionNode = FALSE @@ -870,6 +880,7 @@ Global {BBC3A950-BD68-45AC-9DBD-A8F4D8847745} = {09EADF06-BE25-4228-AB53-95AE3E15B530} {C3D82402-F207-4F19-8C57-5AF0FBAF9682} = {AED9C836-31E3-4F3F-8ABC-929555D3F3C4} {041CB5CD-5832-413E-A894-D9DBED210B16} = {AED9C836-31E3-4F3F-8ABC-929555D3F3C4} + {FB8A8823-CC6C-4C2F-8539-05FBFB7C91CD} = {AED9C836-31E3-4F3F-8ABC-929555D3F3C4} EndGlobalSection GlobalSection(ExtensibilityGlobals) = postSolution SolutionGuid = {41165AF1-35BB-4832-A189-73060F82B01D} diff --git a/test/Microsoft.Data.Analysis.PerformanceTests/Microsoft.Data.Analysis.PerformanceTests.csproj b/test/Microsoft.Data.Analysis.PerformanceTests/Microsoft.Data.Analysis.PerformanceTests.csproj new file mode 100644 index 0000000000..ccd9fdc164 --- /dev/null +++ b/test/Microsoft.Data.Analysis.PerformanceTests/Microsoft.Data.Analysis.PerformanceTests.csproj @@ -0,0 +1,18 @@ + + + + Exe + disable + net6.0 + false + + + + + + + + + + + diff --git a/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs b/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs new file mode 100644 index 0000000000..5984244a3e --- /dev/null +++ b/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs @@ -0,0 +1,34 @@ +// Licensed to the .NET Foundation under one or more agreements. +// The .NET Foundation licenses this file to you under the MIT license. +// See the LICENSE file in the project root for more information. + +using System; +using System.Collections.Generic; +using System.Linq; +using System.Text; +using System.Threading.Tasks; +using BenchmarkDotNet.Attributes; + +namespace Microsoft.Data.Analysis.PerformanceTests +{ + public class PerformanceTests + { + private const int ItemsCount = 1000000; + private Int32DataFrameColumn _column1; + private Int32DataFrameColumn _column2; + + [GlobalSetup] + public void SetUp() + { + var values = Enumerable.Range(0, ItemsCount); + _column1 = new Int32DataFrameColumn("Column1", values); + _column2 = new Int32DataFrameColumn("Column2", values); + } + + [Benchmark] + public void Sum() + { + var column = _column1 + _column2; + } + } +} diff --git a/test/Microsoft.Data.Analysis.PerformanceTests/Program.cs b/test/Microsoft.Data.Analysis.PerformanceTests/Program.cs new file mode 100644 index 0000000000..3e418c02fe --- /dev/null +++ b/test/Microsoft.Data.Analysis.PerformanceTests/Program.cs @@ -0,0 +1,17 @@ +// Licensed to the .NET Foundation under one or more agreements. +// The .NET Foundation licenses this file to you under the MIT license. +// See the LICENSE file in the project root for more information. + +using BenchmarkDotNet.Running; + + +namespace Microsoft.Data.Analysis.PerformanceTests +{ + class Program + { + public static void Main(string[] args) + { + var summary = BenchmarkRunner.Run(); + } + } +} From 69fc3d7aad13c7f2c4af952f6e177858ccb71eb1 Mon Sep 17 00:00:00 2001 From: Aleksei Smirnov Date: Thu, 14 Sep 2023 15:31:55 +0300 Subject: [PATCH 02/10] Add extra tests --- .../PerformanceTests.cs | 179 +++++++++++++++++- 1 file changed, 172 insertions(+), 7 deletions(-) diff --git a/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs b/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs index 5984244a3e..f2d9c90c4a 100644 --- a/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs +++ b/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs @@ -14,21 +14,186 @@ namespace Microsoft.Data.Analysis.PerformanceTests public class PerformanceTests { private const int ItemsCount = 1000000; - private Int32DataFrameColumn _column1; - private Int32DataFrameColumn _column2; + + private Int32DataFrameColumn _int32Column1; + private Int32DataFrameColumn _int32Column2; + + private Int16DataFrameColumn _int16Column1; + private Int16DataFrameColumn _int16Column2; + + private DoubleDataFrameColumn _doubleColumn1; + private DoubleDataFrameColumn _doubleColumn2; + + private SingleDataFrameColumn _floatColumn1; + private SingleDataFrameColumn _floatColumn2; [GlobalSetup] public void SetUp() { - var values = Enumerable.Range(0, ItemsCount); - _column1 = new Int32DataFrameColumn("Column1", values); - _column2 = new Int32DataFrameColumn("Column2", values); + _int32Column1 = new Int32DataFrameColumn("Column1", ItemsCount); + _int32Column2 = new Int32DataFrameColumn("Column2", ItemsCount); + + _int16Column1 = new Int16DataFrameColumn("Column1", ItemsCount); + _int16Column2 = new Int16DataFrameColumn("Column2", ItemsCount); + + _doubleColumn1 = new DoubleDataFrameColumn("Column1", ItemsCount); + _doubleColumn2 = new DoubleDataFrameColumn("Column2", ItemsCount); + + _floatColumn1 = new SingleDataFrameColumn("Column1", ItemsCount); + _floatColumn2 = new SingleDataFrameColumn("Column2", ItemsCount); + } + + #region Addition + + [Benchmark] + public void Add_Int32() + { + var column = _int32Column1 + _int32Column2; + } + + [Benchmark] + public void Add_Int16() + { + var column = _int16Column1 + _int16Column2; + } + + [Benchmark] + public void Add_Double() + { + var column = _doubleColumn1 + _doubleColumn2; + } + + [Benchmark] + public void Add_Float() + { + var column = _floatColumn1 + _floatColumn2; + } + + [Benchmark] + public void Add_Int32_Int16() + { + var column = _int32Column1 + _int16Column2; + } + + [Benchmark] + public void Add_Double_Float() + { + var column = _doubleColumn1 + _floatColumn2; + } + #endregion + + #region Substract + [Benchmark] + public void Substract_Int32() + { + var column = _int32Column1 - _int32Column2; + } + + [Benchmark] + public void Substract_Int16() + { + var column = _int16Column1 - _int16Column2; + } + + [Benchmark] + public void Substract_Double() + { + var column = _doubleColumn1 - _doubleColumn2; + } + + [Benchmark] + public void Substract_Float() + { + var column = _floatColumn1 - _floatColumn2; + } + + [Benchmark] + public void Substract_Int32_Int16() + { + var column = _int32Column1 - _int16Column2; + } + + [Benchmark] + public void Substract_Double_Float() + { + var column = _doubleColumn1 - _floatColumn2; + } + #endregion + + #region Multiply + [Benchmark] + public void Multiply_Int32() + { + var column = _int32Column1 * _int32Column2; + } + + [Benchmark] + public void Multiply_Int16() + { + var column = _int16Column1 * _int16Column2; + } + + [Benchmark] + public void Multiply_Double() + { + var column = _doubleColumn1 * _doubleColumn2; + } + + [Benchmark] + public void Multiply_Float() + { + var column = _floatColumn1 * _floatColumn2; + } + + [Benchmark] + public void Multiply_Int32_Int16() + { + var column = _int32Column1 * _int16Column2; + } + + [Benchmark] + public void Multiply_Double_Float() + { + var column = _doubleColumn1 * _floatColumn2; + } + #endregion + + #region Divide + [Benchmark] + public void Divide_Int32() + { + var column = _int32Column1 / _int32Column2; + } + + [Benchmark] + public void Divide_Int16() + { + var column = _int16Column1 / _int16Column2; + } + + [Benchmark] + public void Divide_Double() + { + var column = _doubleColumn1 / _doubleColumn2; + } + + [Benchmark] + public void Divide_Float() + { + var column = _floatColumn1 / _floatColumn2; + } + + [Benchmark] + public void Divide_Int32_Int16() + { + var column = _int32Column1 / _int16Column2; } [Benchmark] - public void Sum() + public void Divide_Double_Float() { - var column = _column1 + _column2; + var column = _doubleColumn1 / _floatColumn2; } + #endregion } } From 2789c7b807721be43ee294a29d2e55d01ce9a149 Mon Sep 17 00:00:00 2001 From: Aleksei Smirnov Date: Thu, 14 Sep 2023 16:33:24 +0300 Subject: [PATCH 03/10] Fix --- .../PerformanceTests.cs | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs b/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs index f2d9c90c4a..6d782dd067 100644 --- a/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs +++ b/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs @@ -30,17 +30,19 @@ public class PerformanceTests [GlobalSetup] public void SetUp() { - _int32Column1 = new Int32DataFrameColumn("Column1", ItemsCount); - _int32Column2 = new Int32DataFrameColumn("Column2", ItemsCount); + var values = Enumerable.Range(1, ItemsCount).ToArray(); - _int16Column1 = new Int16DataFrameColumn("Column1", ItemsCount); - _int16Column2 = new Int16DataFrameColumn("Column2", ItemsCount); + _int32Column1 = new Int32DataFrameColumn("Column1", values); + _int32Column2 = new Int32DataFrameColumn("Column2", values); - _doubleColumn1 = new DoubleDataFrameColumn("Column1", ItemsCount); - _doubleColumn2 = new DoubleDataFrameColumn("Column2", ItemsCount); + _int16Column1 = new Int16DataFrameColumn("Column1", values.Select(v => (short)v)); + _int16Column2 = new Int16DataFrameColumn("Column2", values.Select(v => (short)v)); - _floatColumn1 = new SingleDataFrameColumn("Column1", ItemsCount); - _floatColumn2 = new SingleDataFrameColumn("Column2", ItemsCount); + _doubleColumn1 = new DoubleDataFrameColumn("Column1", values.Select(v => (double)v)); + _doubleColumn2 = new DoubleDataFrameColumn("Column2", values.Select(v => (double)v)); + + _floatColumn1 = new SingleDataFrameColumn("Column1", values.Select(v => (float)v)); + _floatColumn2 = new SingleDataFrameColumn("Column2", values.Select(v => (float)v)); } #region Addition From d3944d7169226d9855dae428286848205a95cb2d Mon Sep 17 00:00:00 2001 From: Aleksei Smirnov Date: Thu, 14 Sep 2023 18:00:51 +0300 Subject: [PATCH 04/10] Fix typo --- .../PerformanceTests.cs | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs b/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs index 6d782dd067..1210522851 100644 --- a/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs +++ b/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs @@ -84,39 +84,39 @@ public void Add_Double_Float() } #endregion - #region Substract + #region Subtract [Benchmark] - public void Substract_Int32() + public void Subtract_Int32() { var column = _int32Column1 - _int32Column2; } [Benchmark] - public void Substract_Int16() + public void Subtract_Int16() { var column = _int16Column1 - _int16Column2; } [Benchmark] - public void Substract_Double() + public void Subtract_Double() { var column = _doubleColumn1 - _doubleColumn2; } [Benchmark] - public void Substract_Float() + public void Subtract_Float() { var column = _floatColumn1 - _floatColumn2; } [Benchmark] - public void Substract_Int32_Int16() + public void Subtract_Int32_Int16() { var column = _int32Column1 - _int16Column2; } [Benchmark] - public void Substract_Double_Float() + public void Subtract_Double_Float() { var column = _doubleColumn1 - _floatColumn2; } From 8edbae46b065f7491e39db728d3f4bb53f075a3d Mon Sep 17 00:00:00 2001 From: Aleksei Smirnov Date: Fri, 15 Sep 2023 10:50:29 +0300 Subject: [PATCH 05/10] Fix Divide_Int16 and Divide_Int32_Int16 benchmarks --- .../PerformanceTests.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs b/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs index 1210522851..ac40bcdfe6 100644 --- a/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs +++ b/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs @@ -35,8 +35,9 @@ public void SetUp() _int32Column1 = new Int32DataFrameColumn("Column1", values); _int32Column2 = new Int32DataFrameColumn("Column2", values); - _int16Column1 = new Int16DataFrameColumn("Column1", values.Select(v => (short)v)); - _int16Column2 = new Int16DataFrameColumn("Column2", values.Select(v => (short)v)); + var shortValues = values.Select(v => (short)(v / short.MaxValue + 1)).ToArray(); + _int16Column1 = new Int16DataFrameColumn("Column1", shortValues); + _int16Column2 = new Int16DataFrameColumn("Column2", shortValues); _doubleColumn1 = new DoubleDataFrameColumn("Column1", values.Select(v => (double)v)); _doubleColumn2 = new DoubleDataFrameColumn("Column2", values.Select(v => (double)v)); From ec06bd8f09cdf2c91de92e43e8aeeb764fef629e Mon Sep 17 00:00:00 2001 From: Aleksei Smirnov Date: Fri, 15 Sep 2023 11:20:23 +0300 Subject: [PATCH 06/10] Fix --- .../PerformanceTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs b/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs index ac40bcdfe6..7343200603 100644 --- a/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs +++ b/test/Microsoft.Data.Analysis.PerformanceTests/PerformanceTests.cs @@ -35,7 +35,7 @@ public void SetUp() _int32Column1 = new Int32DataFrameColumn("Column1", values); _int32Column2 = new Int32DataFrameColumn("Column2", values); - var shortValues = values.Select(v => (short)(v / short.MaxValue + 1)).ToArray(); + var shortValues = values.Select(v => (short)(v % short.MaxValue + 1)).ToArray(); _int16Column1 = new Int16DataFrameColumn("Column1", shortValues); _int16Column2 = new Int16DataFrameColumn("Column2", shortValues); From 9f14fce8ba12d6fd97f493f4001b549e801ba0e4 Mon Sep 17 00:00:00 2001 From: Aleksei Smirnov Date: Mon, 18 Sep 2023 23:47:34 +0300 Subject: [PATCH 07/10] Change csproj file --- .../Microsoft.Data.Analysis.PerformanceTests.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/Microsoft.Data.Analysis.PerformanceTests/Microsoft.Data.Analysis.PerformanceTests.csproj b/test/Microsoft.Data.Analysis.PerformanceTests/Microsoft.Data.Analysis.PerformanceTests.csproj index ccd9fdc164..c0d91b66af 100644 --- a/test/Microsoft.Data.Analysis.PerformanceTests/Microsoft.Data.Analysis.PerformanceTests.csproj +++ b/test/Microsoft.Data.Analysis.PerformanceTests/Microsoft.Data.Analysis.PerformanceTests.csproj @@ -3,7 +3,7 @@ Exe disable - net6.0 + net6.0 false From 06a349f89ceaa0068c8f563319eada77cfffc362 Mon Sep 17 00:00:00 2001 From: Aleksei Smirnov Date: Tue, 26 Sep 2023 02:00:34 +0300 Subject: [PATCH 08/10] Update BenchmarkDotNetVersion to 0.13.5 --- eng/Versions.props | 2 +- .../Microsoft.Data.Analysis.PerformanceTests.csproj | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/Versions.props b/eng/Versions.props index d13d42aadc..54d582f4ad 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -74,7 +74,7 @@ 1.2.0 5.4.7 - 0.12.0 + 0.13.5 6.0.9 8.0.0-preview.3.23174.8 5.10.2 diff --git a/test/Microsoft.Data.Analysis.PerformanceTests/Microsoft.Data.Analysis.PerformanceTests.csproj b/test/Microsoft.Data.Analysis.PerformanceTests/Microsoft.Data.Analysis.PerformanceTests.csproj index c0d91b66af..fa3a7b571a 100644 --- a/test/Microsoft.Data.Analysis.PerformanceTests/Microsoft.Data.Analysis.PerformanceTests.csproj +++ b/test/Microsoft.Data.Analysis.PerformanceTests/Microsoft.Data.Analysis.PerformanceTests.csproj @@ -8,7 +8,7 @@ - + From 95622a38a6dcf5b74300a3b5c7a3f326d390c580 Mon Sep 17 00:00:00 2001 From: Aleksei Smirnov Date: Tue, 26 Sep 2023 02:08:51 +0300 Subject: [PATCH 09/10] Fix --- test/Microsoft.ML.CpuMath.PerformanceTests/Program.cs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/Microsoft.ML.CpuMath.PerformanceTests/Program.cs b/test/Microsoft.ML.CpuMath.PerformanceTests/Program.cs index 566ec8e7ba..18125d25a6 100644 --- a/test/Microsoft.ML.CpuMath.PerformanceTests/Program.cs +++ b/test/Microsoft.ML.CpuMath.PerformanceTests/Program.cs @@ -16,8 +16,7 @@ public static void Main(string[] args) .Run(args, CreateCustomConfig()); private static IConfig CreateCustomConfig() - => DefaultConfig.Instance - .With(Job.Default - .With(InProcessEmitToolchain.Instance)); + => DefaultConfig.Instance.AddJob(Job.Default + .WithToolchain(InProcessEmitToolchain.Instance)); } } From c271b159b7d280727ab07920198f2a21a4d3bf88 Mon Sep 17 00:00:00 2001 From: Jake Radzikowski Date: Mon, 25 Sep 2023 16:58:16 -0700 Subject: [PATCH 10/10] Change to 0.13.1 because that is what is latest version in our nuget feeds. --- eng/Versions.props | 2 +- test/Microsoft.ML.Benchmarks.Tests/BenchmarksTest.cs | 2 +- test/Microsoft.ML.PerformanceTests/Harness/Configs.cs | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/eng/Versions.props b/eng/Versions.props index 54d582f4ad..1b38246918 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -74,7 +74,7 @@ 1.2.0 5.4.7 - 0.13.5 + 0.13.1 6.0.9 8.0.0-preview.3.23174.8 5.10.2 diff --git a/test/Microsoft.ML.Benchmarks.Tests/BenchmarksTest.cs b/test/Microsoft.ML.Benchmarks.Tests/BenchmarksTest.cs index 4c19dc5d48..a2a9ec437a 100644 --- a/test/Microsoft.ML.Benchmarks.Tests/BenchmarksTest.cs +++ b/test/Microsoft.ML.Benchmarks.Tests/BenchmarksTest.cs @@ -52,7 +52,7 @@ where Attribute.IsDefined(type, typeof(CIBenchmark)) [MemberData(nameof(GetBenchmarks))] public void BenchmarksProjectIsNotBroken(Type type) { - var summary = BenchmarkRunner.Run(type, new TestConfig().With(new OutputLogger(output))); + var summary = BenchmarkRunner.Run(type, new TestConfig().AddLogger(new OutputLogger(output))); Assert.False(summary.HasCriticalValidationErrors, "The \"Summary\" should have NOT \"HasCriticalValidationErrors\""); diff --git a/test/Microsoft.ML.PerformanceTests/Harness/Configs.cs b/test/Microsoft.ML.PerformanceTests/Harness/Configs.cs index 71c24c5567..c7dd80c90b 100644 --- a/test/Microsoft.ML.PerformanceTests/Harness/Configs.cs +++ b/test/Microsoft.ML.PerformanceTests/Harness/Configs.cs @@ -20,11 +20,11 @@ public RecommendedConfig() { Add(DefaultConfig.Instance); // this config contains all of the basic settings (exporters, columns etc) - Add(GetJobDefinition() // job defines how many times given benchmark should be executed + AddJob(GetJobDefinition()// job defines how many times given benchmark should be executed .WithCustomBuildConfiguration(GetBuildConfigurationName()) - .With(CreateToolchain())); // toolchain is responsible for generating, building and running dedicated executable per benchmark + .WithToolchain(CreateToolchain())); // toolchain is responsible for generating, building and running dedicated executable per benchmark - Add(new ExtraMetricColumn()); // an extra column that can display additional metric reported by the benchmarks + AddColumn(new ExtraMetricColumn()); // an extra column that can display additional metric reported by the benchmarks } protected virtual Job GetJobDefinition()