Skip to content

Conversation

@Lehonti
Copy link
Contributor

@Lehonti Lehonti commented Aug 10, 2023

No description provided.

@michaelgsharp
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@michaelgsharp
Copy link
Contributor

@Lehonti I'm not quite sure yet why, but for some reason these changes are tripping a test where we make sure [BestFriends] isn't applied on public members. Don't see that in this PR though so not sure why its happening. Could be an incorrect test?

@Lehonti
Copy link
Contributor Author

Lehonti commented Sep 5, 2023

@Lehonti I'm not quite sure yet why, but for some reason these changes are tripping a test where we make sure [BestFriends] isn't applied on public members. Don't see that in this PR though so not sure why its happening. Could be an incorrect test?

Yes, I think it's probably an incorrect test. I don't know enough about the project so I refrained from modifying anything that could possibly alter the behavior of the code, and stuck to what I'm describing in the pull request (namely file-scoped namespaces). I usually do small changes like these when I'm just getting acquainted with a project.

@michaelgsharp
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Lehonti Lehonti closed this by deleting the head repository Mar 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants