Skip to content

enable BinaryClassifierSymSgdTest #4863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2020
Merged

enable BinaryClassifierSymSgdTest #4863

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7403b84
enable BinaryClassifierSymSgdTest
frank-dong-ms-zz Feb 20, 2020
9a78f64
Merge branch 'master' of https://github.com/dotnet/machinelearning in…
frank-dong-ms-zz Feb 22, 2020
82889ea
add TODO tag for linux and macos cases so we can easily go back to issue
frank-dong-ms-zz Feb 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions test/Microsoft.ML.Predictor.Tests/TestPredictors.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,16 +276,14 @@ public void BinaryClassifierLogisticRegressionTest()

[X64Fact("x86 output differs from Baseline")]
[TestCategory("Binary")]
//Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
[Trait("Category", "SkipInCI")]
public void BinaryClassifierSymSgdTest()
{
// Linux uses a version of MKL that doesn't support conditional numerical reproducibility the same way as
// TODO: Linux uses a version of MKL that doesn't support conditional numerical reproducibility the same way as
// Windows runs.
if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
return;

//Results sometimes go out of error tolerance on OS X.
// TODO: Results sometimes go out of error tolerance on OS X.
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
return;

Expand Down