From 7403b84ebf91d7c44b7ff425261a828ba6f14433 Mon Sep 17 00:00:00 2001 From: frank-dong-ms <55860649+frank-dong-ms@users.noreply.github.com> Date: Thu, 20 Feb 2020 12:39:18 -0800 Subject: [PATCH 1/2] enable BinaryClassifierSymSgdTest --- test/Microsoft.ML.Predictor.Tests/TestPredictors.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/Microsoft.ML.Predictor.Tests/TestPredictors.cs b/test/Microsoft.ML.Predictor.Tests/TestPredictors.cs index 797831afc0..c0e76e9648 100644 --- a/test/Microsoft.ML.Predictor.Tests/TestPredictors.cs +++ b/test/Microsoft.ML.Predictor.Tests/TestPredictors.cs @@ -277,8 +277,6 @@ public void BinaryClassifierLogisticRegressionTest() [X64Fact("x86 output differs from Baseline")] [TestCategory("Binary")] - //Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined - [Trait("Category", "SkipInCI")] public void BinaryClassifierSymSgdTest() { // Linux uses a version of MKL that doesn't support conditional numerical reproducibility the same way as From 82889eaeaf1978a8b9ff180cec2d51237e5a0b42 Mon Sep 17 00:00:00 2001 From: frank-dong-ms <55860649+frank-dong-ms@users.noreply.github.com> Date: Fri, 21 Feb 2020 23:38:32 -0800 Subject: [PATCH 2/2] add TODO tag for linux and macos cases so we can easily go back to issue --- test/Microsoft.ML.Predictor.Tests/TestPredictors.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/Microsoft.ML.Predictor.Tests/TestPredictors.cs b/test/Microsoft.ML.Predictor.Tests/TestPredictors.cs index b34d08e691..2feed686f1 100644 --- a/test/Microsoft.ML.Predictor.Tests/TestPredictors.cs +++ b/test/Microsoft.ML.Predictor.Tests/TestPredictors.cs @@ -278,12 +278,12 @@ public void BinaryClassifierLogisticRegressionTest() [TestCategory("Binary")] public void BinaryClassifierSymSgdTest() { - // Linux uses a version of MKL that doesn't support conditional numerical reproducibility the same way as + // TODO: Linux uses a version of MKL that doesn't support conditional numerical reproducibility the same way as // Windows runs. if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux)) return; - //Results sometimes go out of error tolerance on OS X. + // TODO: Results sometimes go out of error tolerance on OS X. if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX)) return;