Skip to content

Check exception status even if TF_SessionRun throws an exception #4755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2020
Merged

Check exception status even if TF_SessionRun throws an exception #4755

merged 1 commit into from
Feb 6, 2020

Conversation

@sharwell
Copy link
Contributor

@sharwell sharwell commented Jan 31, 2020

Extracted from #4569

@sharwell sharwell requested a review from a team as a code owner January 31, 2020 19:47
frank-dong-ms-zz
frank-dong-ms-zz approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@frank-dong-ms-zz frank-dong-ms-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sharwell
Copy link
Contributor Author

sharwell commented Jan 31, 2020

📝 Note that this is nice in general, but for the exception case we hit there is still no additional information about the crash. 😦

@antoniovs1029 antoniovs1029 added the test related to tests label Feb 4, 2020
@harishsk harishsk merged commit ff320b8 into dotnet:master Feb 6, 2020
@sharwell
Copy link
Contributor Author

sharwell commented Feb 6, 2020

@antoniovs1029 I'm removing this test label since this is a production code change.

@sharwell sharwell removed the test related to tests label Feb 6, 2020
@sharwell sharwell deleted the check-status branch February 6, 2020 13:16
@mstfbl mstfbl mentioned this pull request Mar 2, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@frank-dong-ms-zz frank-dong-ms-zz frank-dong-ms-zz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sharwell @frank-dong-ms-zz @harishsk @antoniovs1029