Skip to content

Fix runtime exception in ImageClassification. #3249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 9, 2019
Merged

Fix runtime exception in ImageClassification. #3249

merged 4 commits into from
Apr 9, 2019

Conversation

@codemzs
Copy link
Member

@codemzs codemzs commented Apr 8, 2019

fixes #3248

@codemzs codemzs requested review from sfilipi and zeahmed April 8, 2019 22:27
@codecov
Copy link

codecov bot commented Apr 8, 2019 •
edited
Loading

Codecov Report

Merging #3249 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3249      +/-   ##
==========================================
+ Coverage   72.61%   72.62%   +<.01%     
==========================================
  Files         804      807       +3     
  Lines      145025   145080      +55     
  Branches    16213    16213              
==========================================
+ Hits       105314   105368      +54     
- Misses      35294    35295       +1     
  Partials     4417     4417
Flag Coverage Δ
#Debug 72.62% <ø> (ø) ⬆️
#production 68.17% <ø> (+0.01%) ⬆️
#test 88.92% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.7% <0%> (-0.21%) ⬇️
...OnnxTransformer.StaticPipe/OnnxStaticExtensions.cs 100% <0%> (ø)
...L.DnnImageFeaturizer.ResNet18/ResNet18Extension.cs 100% <0%> (ø)
...r.StaticPipe/DnnImageFeaturizerStaticExtensions.cs 100% <0%> (ø)

zeahmed
zeahmed approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@zeahmed zeahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs codemzs requested a review from wschin April 8, 2019 23:48
@codemzs codemzs merged commit ee14339 into dotnet:master Apr 9, 2019
codemzs added a commit to codemzs/machinelearning that referenced this pull request Apr 11, 2019
@codemzs
Fix runtime exception in ImageClassification. (dotnet#3249)
bfa23db 
* Fix runtime exception in ImageClassification.

* Cleanup.

* revert changes.

* 3P license notice.
@codemzs codemzs mentioned this pull request Apr 11, 2019
Closed
@ericstj ericstj mentioned this pull request Apr 1, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfilipi sfilipi Awaiting requested review from sfilipi

2 more reviewers

@wschin wschin wschin approved these changes

@zeahmed zeahmed zeahmed approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix runtime exception in Image classification sample.

3 participants

@codemzs @wschin @zeahmed