From adc496f29b394c90acc39795c4a4315b1e94f749 Mon Sep 17 00:00:00 2001 From: Zeeshan Siddiqui Date: Wed, 27 Feb 2019 11:07:13 -0800 Subject: [PATCH 1/5] Package FastTree. --- .../Microsoft.ML.FastTree.nupkgproj | 12 ++++++++++++ .../Microsoft.ML.FastTree.symbols.nupkgproj | 5 +++++ .../Microsoft.ML.FastTree.csproj | 2 +- 3 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 pkg/Microsoft.ML.FastTree/Microsoft.ML.FastTree.nupkgproj create mode 100644 pkg/Microsoft.ML.FastTree/Microsoft.ML.FastTree.symbols.nupkgproj diff --git a/pkg/Microsoft.ML.FastTree/Microsoft.ML.FastTree.nupkgproj b/pkg/Microsoft.ML.FastTree/Microsoft.ML.FastTree.nupkgproj new file mode 100644 index 0000000000..a0b0d19b4e --- /dev/null +++ b/pkg/Microsoft.ML.FastTree/Microsoft.ML.FastTree.nupkgproj @@ -0,0 +1,12 @@ + + + + netstandard2.0 + ML.NET component for FastTree + + + + + + + diff --git a/pkg/Microsoft.ML.FastTree/Microsoft.ML.FastTree.symbols.nupkgproj b/pkg/Microsoft.ML.FastTree/Microsoft.ML.FastTree.symbols.nupkgproj new file mode 100644 index 0000000000..9f4c5712ff --- /dev/null +++ b/pkg/Microsoft.ML.FastTree/Microsoft.ML.FastTree.symbols.nupkgproj @@ -0,0 +1,5 @@ + + + + + diff --git a/src/Microsoft.ML.FastTree/Microsoft.ML.FastTree.csproj b/src/Microsoft.ML.FastTree/Microsoft.ML.FastTree.csproj index 6bf95bd119..9ba56bf8f6 100644 --- a/src/Microsoft.ML.FastTree/Microsoft.ML.FastTree.csproj +++ b/src/Microsoft.ML.FastTree/Microsoft.ML.FastTree.csproj @@ -2,7 +2,7 @@ netstandard2.0 - Microsoft.ML + Microsoft.ML.FastTree $(DefineConstants);USE_FASTTREENATIVE;NO_STORE;CORECLR true From f2b7eef9f21d170d267eedd3485955de3adba7bd Mon Sep 17 00:00:00 2001 From: Zeeshan Siddiqui Date: Wed, 27 Feb 2019 11:57:06 -0800 Subject: [PATCH 2/5] Add native code to the package and include fasttree nuget instructions in samples. --- .../Microsoft.ML.Samples/Dynamic/FastTreeRegression.cs | 1 + .../Static/FastTreeBinaryClassification.cs | 1 + .../samples/Microsoft.ML.Samples/Static/FastTreeRegression.cs | 1 + src/Native/build.proj | 4 ++-- 4 files changed, 5 insertions(+), 2 deletions(-) diff --git a/docs/samples/Microsoft.ML.Samples/Dynamic/FastTreeRegression.cs b/docs/samples/Microsoft.ML.Samples/Dynamic/FastTreeRegression.cs index 6d6c066879..546de0640c 100644 --- a/docs/samples/Microsoft.ML.Samples/Dynamic/FastTreeRegression.cs +++ b/docs/samples/Microsoft.ML.Samples/Dynamic/FastTreeRegression.cs @@ -6,6 +6,7 @@ namespace Microsoft.ML.Samples.Dynamic { public static class FastTreeRegression { + // This example requires installation of additional nuget package Microsoft.ML.FastTree. public static void Example() { // Create a new ML context, for ML.NET operations. It can be used for exception tracking and logging, diff --git a/docs/samples/Microsoft.ML.Samples/Static/FastTreeBinaryClassification.cs b/docs/samples/Microsoft.ML.Samples/Static/FastTreeBinaryClassification.cs index dfc3cdda0e..27acbc14ca 100644 --- a/docs/samples/Microsoft.ML.Samples/Static/FastTreeBinaryClassification.cs +++ b/docs/samples/Microsoft.ML.Samples/Static/FastTreeBinaryClassification.cs @@ -6,6 +6,7 @@ namespace Microsoft.ML.Samples.Static { public class FastTreeBinaryClassificationExample { + // This example requires installation of additional nuget package Microsoft.ML.FastTree. public static void FastTreeBinaryClassification() { // Downloading a classification dataset from github.com/dotnet/machinelearning. diff --git a/docs/samples/Microsoft.ML.Samples/Static/FastTreeRegression.cs b/docs/samples/Microsoft.ML.Samples/Static/FastTreeRegression.cs index 67ae9afb1a..2552e7bb73 100644 --- a/docs/samples/Microsoft.ML.Samples/Static/FastTreeRegression.cs +++ b/docs/samples/Microsoft.ML.Samples/Static/FastTreeRegression.cs @@ -8,6 +8,7 @@ namespace Microsoft.ML.Samples.Static { public class FastTreeRegressionExample { + // This example requires installation of additional nuget package Microsoft.ML.FastTree. public static void FastTreeRegression() { // Downloading a regression dataset from github.com/dotnet/machinelearning diff --git a/src/Native/build.proj b/src/Native/build.proj index aa5334a055..0ecba6deea 100644 --- a/src/Native/build.proj +++ b/src/Native/build.proj @@ -85,8 +85,6 @@ - + From 5f9b692df5b835c60ec4c1f3a97b035088ead707 Mon Sep 17 00:00:00 2001 From: Zeeshan Siddiqui Date: Wed, 27 Feb 2019 12:44:14 -0800 Subject: [PATCH 3/5] PR feedback. --- pkg/Microsoft.ML.LightGBM/Microsoft.ML.LightGBM.nupkgproj | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/Microsoft.ML.LightGBM/Microsoft.ML.LightGBM.nupkgproj b/pkg/Microsoft.ML.LightGBM/Microsoft.ML.LightGBM.nupkgproj index 8cddd1719e..c2afe8b47e 100644 --- a/pkg/Microsoft.ML.LightGBM/Microsoft.ML.LightGBM.nupkgproj +++ b/pkg/Microsoft.ML.LightGBM/Microsoft.ML.LightGBM.nupkgproj @@ -7,6 +7,7 @@ + From c65d201d59559c12744d880d33fd0f1cead907f0 Mon Sep 17 00:00:00 2001 From: Zeeshan Siddiqui Date: Wed, 27 Feb 2019 13:04:40 -0800 Subject: [PATCH 4/5] PR feedback. --- pkg/Microsoft.ML.StaticPipe/Microsoft.ML.StaticPipe.nupkgproj | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/Microsoft.ML.StaticPipe/Microsoft.ML.StaticPipe.nupkgproj b/pkg/Microsoft.ML.StaticPipe/Microsoft.ML.StaticPipe.nupkgproj index 364540323f..a584cfde18 100644 --- a/pkg/Microsoft.ML.StaticPipe/Microsoft.ML.StaticPipe.nupkgproj +++ b/pkg/Microsoft.ML.StaticPipe/Microsoft.ML.StaticPipe.nupkgproj @@ -9,6 +9,7 @@ + From 42a58b5039f33cf056b648386d57b2d4c47e34b0 Mon Sep 17 00:00:00 2001 From: Zeeshan Siddiqui Date: Wed, 27 Feb 2019 13:30:40 -0800 Subject: [PATCH 5/5] PR feedback. --- pkg/Microsoft.ML.LightGBM/Microsoft.ML.LightGBM.nupkgproj | 2 +- pkg/Microsoft.ML.StaticPipe/Microsoft.ML.StaticPipe.nupkgproj | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/Microsoft.ML.LightGBM/Microsoft.ML.LightGBM.nupkgproj b/pkg/Microsoft.ML.LightGBM/Microsoft.ML.LightGBM.nupkgproj index c2afe8b47e..d4e48e8dd0 100644 --- a/pkg/Microsoft.ML.LightGBM/Microsoft.ML.LightGBM.nupkgproj +++ b/pkg/Microsoft.ML.LightGBM/Microsoft.ML.LightGBM.nupkgproj @@ -7,7 +7,7 @@ - + diff --git a/pkg/Microsoft.ML.StaticPipe/Microsoft.ML.StaticPipe.nupkgproj b/pkg/Microsoft.ML.StaticPipe/Microsoft.ML.StaticPipe.nupkgproj index a584cfde18..1ee836402f 100644 --- a/pkg/Microsoft.ML.StaticPipe/Microsoft.ML.StaticPipe.nupkgproj +++ b/pkg/Microsoft.ML.StaticPipe/Microsoft.ML.StaticPipe.nupkgproj @@ -9,7 +9,7 @@ - +