Remove lazy parameters for GetRowCount #1621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschin
changed the title
Zruty0
reviewed
Nov 15, 2018
Zruty0
reviewed
Nov 15, 2018
Member
sfilipi
reviewed
Nov 15, 2018
| public override long? GetRowCount() | ||
| { | ||
| return _transform.GetRowCount(lazy); | ||
| return _transform.GetRowCount(); |
Member
There was a problem hiding this comment.
return [](start = 15, length = 7)
prefer => to full bodied for one liners.
Member
Author
There was a problem hiding this comment.
I'd like to keep change as small as possible. Maybe you can create another issue so that someone will fix it?
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1531. In most cases, the
GetRowCountis as lazy as before but in some places such asCacheDataViewinCacheDataView.cs, it could need more than O(1) time to wait until the actual number of rows is available.