-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Labels
APIIssues pertaining the friendly APIIssues pertaining the friendly APIP1Priority of the issue for triage purpose: Needs to be fixed soon.Priority of the issue for triage purpose: Needs to be fixed soon.lightgbmBugs related lightgbmBugs related lightgbmrankingBugs related ranking tasksBugs related ranking tasks
Description
First of all, is this a breaking change? @terrajobst suggested it is an acceptable breaking change #2305 (comment), @eerhardt commented that is was decided that changing defaults is acceptable #2305 (comment)
-
Change the following defaults based on results from @justinormont:
-
Update default n-gram length for Text Transform to match default text recipe #2870
FeatirizeTextdefault n-grams lengths to match default text recipe:- word: 1 -> 2
- char: no change
- @justinormont correct me if I am wrong: was the default weighting TF-IDF in TLC? It is currently TF
-
Change default # of iterations in Averaged Perceptron to 10 #2305
AveragedPerceptrondefault iterations from 1 to 10
-
-
RowGroupColumnName of ranking trainers options class defaults to null #3365
RowGroupColumnNameinFastTreeandLightGbmranking trainerOptionsclasses:null->'GroupId'- This won't actually break anything since a ranking trainer would throw anyway if there was no group ID column specified RowGroupColumnName of ranking trainers options class defaults to null #3365 (comment)
- This would make it consistent with the API for the rankers without the
Optionsclass, where the default is'GroupId' - They should be consistent, at least. Either
nulleverywhere or'GroupId'everywhere.
Metadata
Metadata
Assignees
Labels
APIIssues pertaining the friendly APIIssues pertaining the friendly APIP1Priority of the issue for triage purpose: Needs to be fixed soon.Priority of the issue for triage purpose: Needs to be fixed soon.lightgbmBugs related lightgbmBugs related lightgbmrankingBugs related ranking tasksBugs related ranking tasks