Skip to content

RowGroupColumnName of ranking trainers options class defaults to null #3365

@artidoro

Description

@artidoro

The Options class of the ranking trainers (FastTree and LightGbm) defaults to RowGroupColumnName = null.

This is:

  1. Inconsistent with the simple constructor where RowGroupColumnName defaults to GroupId
  2. Not desirable as in ranking the row group is very important for correct training

Here are the lines where the row group column name is set:

/// <summary>
/// Column to use for example groupId.
/// </summary>
[Argument(ArgumentType.AtMostOnce, HelpText = "Column to use for example groupId", ShortName = "groupId", SortOrder = 5, Visibility = ArgumentAttribute.VisibilityType.EntryPointsOnly)]
public string RowGroupColumnName = null;

We need to update the default and align it with the simple constructor.

Metadata

Metadata

Assignees

No one assigned

    Labels

    APIIssues pertaining the friendly APIP3Doc bugs, questions, minor issues, etc.bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions