-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Labels
APIIssues pertaining the friendly APIIssues pertaining the friendly APIP3Doc bugs, questions, minor issues, etc.Doc bugs, questions, minor issues, etc.bugSomething isn't workingSomething isn't working
Description
The Options class of the ranking trainers (FastTree and LightGbm) defaults to RowGroupColumnName = null.
This is:
- Inconsistent with the simple constructor where
RowGroupColumnNamedefaults toGroupId - Not desirable as in ranking the row group is very important for correct training
Here are the lines where the row group column name is set:
machinelearning/src/Microsoft.ML.Data/Training/TrainerInputBase.cs
Lines 106 to 110 in 738e5d5
| /// <summary> | |
| /// Column to use for example groupId. | |
| /// </summary> | |
| [Argument(ArgumentType.AtMostOnce, HelpText = "Column to use for example groupId", ShortName = "groupId", SortOrder = 5, Visibility = ArgumentAttribute.VisibilityType.EntryPointsOnly)] | |
| public string RowGroupColumnName = null; |
We need to update the default and align it with the simple constructor.
Metadata
Metadata
Assignees
Labels
APIIssues pertaining the friendly APIIssues pertaining the friendly APIP3Doc bugs, questions, minor issues, etc.Doc bugs, questions, minor issues, etc.bugSomething isn't workingSomething isn't working