-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Labels
APIIssues pertaining the friendly APIIssues pertaining the friendly API
Milestone
Description
We need to make sure our transforms are in good shape.
-
No protected fields/members/method in public classes. Only private protected.
-
Transformer class is sealed.
-
Transformer/Estimator should and catalog method names should be sensible (Estimators and their catalog extensions should have matching names #2853 fine if slightly different).
-
Column options cleaning:
- Option should have meaning and proper way it initialize it self.
- No short names.
-
public IReadOnlyCollection<(string outputColumnName, string inputColumnName)> Columns => ColumnPairs.AsReadOnly();
I don't think that public thing make sense to me, I would prefer to get rid of it. -
No public value tuples (especially in catalog methods) (Value-tuple stragglers in the public API #2881)
List still in progress.
Metadata
Metadata
Assignees
Labels
APIIssues pertaining the friendly APIIssues pertaining the friendly API