Skip to content

Scrubbing transformers (Meta issue) #2827

@Ivanidzo4ka

Description

@Ivanidzo4ka

We need to make sure our transforms are in good shape.

  1. No protected fields/members/method in public classes. Only private protected.

  2. Transformer class is sealed.

  3. Transformer/Estimator should and catalog method names should be sensible (Estimators and their catalog extensions should have matching names #2853 fine if slightly different).

  4. Column options cleaning:

  • Option should have meaning and proper way it initialize it self.
  • No short names.
  1. public IReadOnlyCollection<(string outputColumnName, string inputColumnName)> Columns => ColumnPairs.AsReadOnly();
    I don't think that public thing make sense to me, I would prefer to get rid of it.

  2. No public value tuples (especially in catalog methods) (Value-tuple stragglers in the public API #2881)

List still in progress.

Metadata

Metadata

Assignees

No one assigned

    Labels

    APIIssues pertaining the friendly API

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions