Parameter name Consistency in FastTree

[srsaggam]

machinelearning/src/Microsoft.ML.FastTree/FastTreeArguments.cs

Line 528 in 4bb3e00

public Double LearningRates = Defaults.LearningRates;

Should this be LearningRate? The Options have it named wrongly.

The named parameter for the FastTree is named correctly as learningRate.

machinelearning/src/Microsoft.ML.FastTree/TreeTrainersCatalog.cs

Line 34 in 4bb3e00

double learningRate = Defaults.LearningRates)

It would be great if you can check the same with all the trainers and transforms. i.e the named parameters(in the method) resemble the Actual Property name(in the options). In my opinion these all should be consistent. In case of named params (camel case) and for actual Property (of course is pascal case)

[srsaggam]

@justinormont @vinodshanbhag @daholste

[srsaggam]

@abgoswam Can you please take a look at this? and verify the same for all other trainers available in the catalog.

[justinormont]

We should go one step further and take up the larger task of verifying a unified naming scheme for all parameters across all components before the v1.0 release. After the release renaming parameters will be difficult.
/cc @glebuk

[abgoswam]

Also related to #2172 to bring consistency in naming convention.

[wschin]

It will be a part of #2617.