Skip to content

Commit e6aa43d

Browse files
committed
Address comments and update entry-point catalog
1 parent badb7e3 commit e6aa43d

File tree

3 files changed

+604
-403
lines changed

3 files changed

+604
-403
lines changed

src/Microsoft.ML.FastTree/FastTree.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ private protected void TrainCore(IChannel ch)
237237
using (Timer.Time(TimerEvent.TotalTrain))
238238
Train(ch);
239239
if (FastTreeTrainerOptions.ExecutionTime)
240-
PrintExecutionTimes(ch);
240+
PrintExecutionTime(ch);
241241
TrainedEnsemble = Ensemble;
242242
if (FeatureMap != null)
243243
TrainedEnsemble.RemapFeatures(FeatureMap);
@@ -257,7 +257,7 @@ private protected virtual void InitializeThreads(int numThreads)
257257
ThreadTaskManager.Initialize(numThreads);
258258
}
259259

260-
private protected virtual void PrintExecutionTimes(IChannel ch)
260+
private protected virtual void PrintExecutionTime(IChannel ch)
261261
{
262262
ch.Info("Execution time breakdown:\n{0}", Timer.GetString());
263263
}

src/Microsoft.ML.FastTree/FastTreeArguments.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ public abstract class TreeOptions : TrainerInputBaseWithGroupId
298298
public Double SoftmaxTemperature;
299299

300300
/// <summary>
301-
/// Print execution time breakdown to stdout.
301+
/// Print execution time breakdown to ML.NET channel.
302302
/// </summary>
303303
[Argument(ArgumentType.AtMostOnce, HelpText = "Print execution time breakdown to stdout", ShortName = "et,ExecutionTimes")]
304304
public bool ExecutionTime;
@@ -397,17 +397,19 @@ public abstract class TreeOptions : TrainerInputBaseWithGroupId
397397
/// <summary>
398398
/// Print metrics graph for the first test set.
399399
/// </summary>
400+
[BestFriend]
400401
[Argument(ArgumentType.LastOccurenceWins, HelpText = "Print metrics graph for the first test set", ShortName = "graph", Hide = true)]
401402
[TGUI(NotGui = true)]
402-
public bool PrintTestGraph;
403+
internal bool PrintTestGraph;
403404

404405
/// <summary>
405406
/// Print Train and Validation metrics in graph.
406407
/// </summary>
407408
//It is only enabled if printTestGraph is also set
409+
[BestFriend]
408410
[Argument(ArgumentType.LastOccurenceWins, HelpText = "Print Train and Validation metrics in graph", ShortName = "graphtv", Hide = true)]
409411
[TGUI(NotGui = true)]
410-
public bool PrintTrainValidGraph;
412+
internal bool PrintTrainValidGraph;
411413

412414
/// <summary>
413415
/// Calculate metric values for train/valid/test every k rounds.

0 commit comments

Comments
 (0)