work in progress on prior and random estimators

Author: artidoro

src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs

@@ -13,6 +13,7 @@
 using Microsoft.ML.Runtime.Model;
 using Microsoft.ML.Runtime.Training;
 using Microsoft.ML.Runtime.Internal.Internallearn;
+using Microsoft.ML.Core.Data;
 
 [assembly: LoadableClass(RandomTrainer.Summary, typeof(RandomTrainer), typeof(RandomTrainer.Arguments),
     new[] { typeof(SignatureBinaryClassifierTrainer), typeof(SignatureTrainer) },
@@ -38,38 +39,37 @@ namespace Microsoft.ML.Runtime.Learners
     /// <summary>
     /// A trainer that trains a predictor that returns random values
     /// </summary>
-    public sealed class RandomTrainer : TrainerBase<RandomPredictor>
+
+    public sealed class RandomTrainer : TrainerEstimatorBase<BinaryPredictionTransformer<RandomPredictor>, RandomPredictor>
     {
         internal const string LoadNameValue = "RandomPredictor";
         internal const string UserNameValue = "Random Predictor";
         internal const string Summary = "A toy predictor that returns a random value.";
 
         public class Arguments
         {
-            // Some sample arguments
-            [Argument(ArgumentType.AtMostOnce, HelpText = "Learning rate", ShortName = "lr")]
-            public Float LearningRate = (Float)1.0;
-
-            [Argument(ArgumentType.AtMostOnce, HelpText = "Some bool arg", ShortName = "boolarg")]
-            public bool BooleanArg = false;
         }
 
         public override PredictionKind PredictionKind => PredictionKind.BinaryClassification;
 
         private static readonly TrainerInfo _info = new TrainerInfo(normalization: false, caching: false);
         public override TrainerInfo Info => _info;
 
-        public RandomTrainer(IHostEnvironment env, Arguments args)
-            : base(env, LoadNameValue)
+        protected override SchemaShape.Column[] OutputColumns => throw new NotImplementedException();
+
+        public RandomTrainer(IHost host, SchemaShape.Column feature, SchemaShape.Column label, SchemaShape.Column weight)
+            : base(host, feature, label, weight)
         {
-            Host.CheckValue(args, nameof(args));
         }
 
-        public override RandomPredictor Train(TrainContext context)
+        protected override RandomPredictor TrainModelCore(TrainContext trainContext)
         {
-            Host.CheckValue(context, nameof(context));
+            Host.CheckValue(trainContext, nameof(trainContext));
             return new RandomPredictor(Host, Host.Rand.Next());
         }
+
+        protected override BinaryPredictionTransformer<RandomPredictor> MakeTransformer(RandomPredictor model, ISchema trainSchema)
+            => new BinaryPredictionTransformer<RandomPredictor>(Host, model, trainSchema, FeatureColumn.Name);
     }
 
     /// <summary>
@@ -196,7 +196,7 @@ private void MapDist(ref VBuffer<Float> src, ref Float score, ref Float prob)
     }
 
     // Learns the prior distribution for 0/1 class labels and just outputs that.
-    public sealed class PriorTrainer : TrainerBase<PriorPredictor>
+    public sealed class PriorTrainer : TrainerEstimatorBase<BinaryPredictionTransformer<PriorPredictor>, PriorPredictor>
     {
         internal const string LoadNameValue = "PriorPredictor";
         internal const string UserNameValue = "Prior Predictor";
@@ -210,13 +210,14 @@ public sealed class Arguments
         private static readonly TrainerInfo _info = new TrainerInfo(normalization: false, caching: false);
         public override TrainerInfo Info => _info;
 
-        public PriorTrainer(IHostEnvironment env, Arguments args)
-            : base(env, LoadNameValue)
+        protected override SchemaShape.Column[] OutputColumns { get; }
+
+        public PriorTrainer(IHost host, SchemaShape.Column feature, SchemaShape.Column label, SchemaShape.Column weight)
+            : base(host, feature, label, weight)
         {
-            Host.CheckValue(args, nameof(args));
         }
 
-        public override PriorPredictor Train(TrainContext context)
+        protected override PriorPredictor TrainModelCore(TrainContext context)
         {
             Contracts.CheckValue(context, nameof(context));
             var data = context.TrainingSet;
@@ -258,6 +259,10 @@ public override PriorPredictor Train(TrainContext context)
             Float prob = prob = pos + neg > 0 ? (Float)(pos / (pos + neg)) : Float.NaN;
             return new PriorPredictor(Host, prob);
         }
+
+        protected override BinaryPredictionTransformer<PriorPredictor> MakeTransformer(PriorPredictor model, ISchema trainSchema)
+             => new BinaryPredictionTransformer<PriorPredictor>(Host, model, trainSchema, FeatureColumn.Name);
+
     }
 
     public sealed class PriorPredictor :