modify base test class analyzer, allow also to extend from ft base test class (#4810)

Author: frank-dong-ms-zz

tools-local/Microsoft.ML.InternalCodeAnalyzer/BaseTestClassAnalyzer.cs

@@ -16,10 +16,10 @@ public sealed class BaseTestClassAnalyzer : DiagnosticAnalyzer
         private const string Category = "Test";
         internal const string DiagnosticId = "MSML_ExtendBaseTestClass";
 
-        private const string Title = "Test classes should be derived from BaseTestClass";
-        private const string Format = "Test class '{0}' should extend BaseTestClass.";
+        private const string Title = "Test classes should be derived from BaseTestClass or FunctionalTestBaseClass";
+        private const string Format = "Test class '{0}' should extend BaseTestClass or FunctionalTestBaseClass.";
         private const string Description =
-            "Test classes should be derived from BaseTestClass.";
+            "Test classes should be derived from BaseTestClass or FunctionalTestBaseClass.";
 
         private static DiagnosticDescriptor Rule =
             new DiagnosticDescriptor(DiagnosticId, Title, Format, Category,
@@ -51,13 +51,15 @@ private sealed class AnalyzerImpl
             private readonly Compilation _compilation;
             private readonly INamedTypeSymbol _factAttribute;
             private readonly INamedTypeSymbol _baseTestClass;
+            private readonly INamedTypeSymbol _FTbaseTestClass;
             private readonly ConcurrentDictionary<INamedTypeSymbol, bool> _knownTestAttributes = new ConcurrentDictionary<INamedTypeSymbol, bool>();
 
             public AnalyzerImpl(Compilation compilation, INamedTypeSymbol factAttribute)
             {
                 _compilation = compilation;
                 _factAttribute = factAttribute;
                 _baseTestClass = _compilation.GetTypeByMetadataName("Microsoft.ML.TestFramework.BaseTestClass");
+                _FTbaseTestClass = _compilation.GetTypeByMetadataName("Microsoft.ML.Functional.Tests.FunctionalTestBaseClass");
             }
 
             public void AnalyzeNamedType(SymbolAnalysisContext context)
@@ -87,12 +89,14 @@ public void AnalyzeNamedType(SymbolAnalysisContext context)
 
             private bool ExtendsBaseTestClass(INamedTypeSymbol namedType)
             {
-                if (_baseTestClass is null)
+                if (_baseTestClass is null && 
+                    _FTbaseTestClass is null)
                     return false;
 
                 for (var current = namedType; current is object; current = current.BaseType)
                 {
-                    if (Equals(current, _baseTestClass))
+                    if (Equals(current, _baseTestClass) ||
+                        Equals(current, _FTbaseTestClass))
                         return true;
                 }