Fix code review findings

Author: asmirnov82

src/Microsoft.Data.Analysis/ArrayUtility.cs

@@ -0,0 +1,18 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace Microsoft.Data.Analysis
+{
+    internal static class ArrayUtility
+    {
+        // Maximum size of one-dimensional array.
+        // See: https://msdn.microsoft.com/en-us/library/hh285054(v=vs.110).aspx
+        // Polyfilling Array.MaxLength API for netstandard2.0
+        public const int ArrayMaxSize = 0X7FEFFFFF;
+    }
+}

src/Microsoft.Data.Analysis/DataFrameBuffer.cs

@@ -80,7 +80,7 @@ public void EnsureCapacity(int numberOfValues)
             if (newLength > Capacity)
             {
                 //Double buffer size, but not higher than MaxByteCapacity
-                var doubledSize = (int)Math.Min((long)ReadOnlyBuffer.Length * 2, MaxCapacityInBytes);
+                var doubledSize = (int)Math.Min((long)ReadOnlyBuffer.Length * 2, ArrayUtility.ArrayMaxSize);
                 var newCapacity = Math.Max(newLength * Size, doubledSize);
 
                 var memory = new Memory<byte>(new byte[newCapacity]);

src/Microsoft.Data.Analysis/ReadOnlyDataFrameBuffer.cs

@@ -36,11 +36,7 @@ public ReadOnlyMemory<T> RawReadOnlyMemory
 
         protected int Capacity => ReadOnlyBuffer.Length / Size;
 
-        //The maximum size in any single dimension for byte array is 0x7FFFFFc7 - 2147483591
-        //See https://learn.microsoft.com/en-us/dotnet/framework/configure-apps/file-schema/runtime/gcallowverylargeobjects-element
-        public const int MaxCapacityInBytes = 2147483591;
-
-        public static int MaxCapacity => MaxCapacityInBytes / Size;
+        public static int MaxCapacity => ArrayUtility.ArrayMaxSize / Size;
 
         public ReadOnlySpan<T> ReadOnlySpan
         {

src/Microsoft.Data.Analysis/StringDataFrameColumn.cs

@@ -18,9 +18,7 @@ namespace Microsoft.Data.Analysis
     /// <remarks> Is NOT Arrow compatible </remarks>
     public partial class StringDataFrameColumn : DataFrameColumn, IEnumerable<string>
     {
-        //The maximum size in any single dimension for array containing other types than byte or single byte structure is 0X7FEFFFFF - 2146435071
-        //See https://learn.microsoft.com/en-us/dotnet/framework/configure-apps/file-schema/runtime/gcallowverylargeobjects-element
-        public static int MaxCapacity = 2146435071 / Unsafe.SizeOf<IntPtr>(); // Size of pointer
+        public static int MaxCapacity = ArrayUtility.ArrayMaxSize / Unsafe.SizeOf<IntPtr>(); // Max Size in bytes / size of pointer (8 bytes on x64)
 
         private readonly List<List<string>> _stringBuffers = new List<List<string>>(); // To store more than intMax number of strings
 

src/Microsoft.Data.Analysis/VBufferDataFrameColumn.cs

@@ -18,9 +18,8 @@ namespace Microsoft.Data.Analysis
     /// </summary>
     public partial class VBufferDataFrameColumn<T> : DataFrameColumn, IEnumerable<VBuffer<T>>
     {
-        //The maximum size in any single dimension for array containing other types than byte or single byte structure is 0X7FEFFFFF - 2146435071
-        //See https://learn.microsoft.com/en-us/dotnet/framework/configure-apps/file-schema/runtime/gcallowverylargeobjects-element
-        public static int MaxCapacity = 2146435071 / Unsafe.SizeOf<VBuffer<T>>();
+
+        public static int MaxCapacity = ArrayUtility.ArrayMaxSize / Unsafe.SizeOf<VBuffer<T>>();
 
         private readonly List<List<VBuffer<T>>> _vBuffers = new List<List<VBuffer<T>>>(); // To store more than intMax number of vbuffers
 

test/Microsoft.Data.Analysis.Tests/BufferTests.cs

@@ -457,7 +457,7 @@ public void TestAppend_SizeMoreThanMaxBufferCapacity()
         [X64Fact("32-bit dosn't allow to allocate more than 2 Gb")]
         public void TestAppendMany_SizeMoreThanMaxBufferCapacity()
         {
-            const int MaxCapacityInBytes = 2147483591;
+            const int MaxCapacityInBytes = 0X7FEFFFFF;
 
             //Check appending values with extending column size over MaxCapacity of ReadOnlyDataFrameBuffer
             PrimitiveDataFrameColumn<byte> intColumn = new PrimitiveDataFrameColumn<byte>("Byte1", MaxCapacityInBytes - 5);