* Enable analysis on all files

* Disable analysis for generated code
* Fix found issues

Author: TomFinley

src/Directory.Build.props

@@ -14,4 +14,12 @@
 
   </PropertyGroup>
 
+  <ItemGroup>
+    <ProjectReference Include="$(MSBuildThisFileDirectory)\..\tools-local\Microsoft.ML.CodeAnalyzer\Microsoft.ML.CodeAnalyzer.csproj">
+      <ReferenceOutputAssembly>false</ReferenceOutputAssembly>
+      <OutputItemType>Analyzer</OutputItemType>
+    </ProjectReference>
+    
+  </ItemGroup>
+
 </Project>

src/Microsoft.ML.Api/SchemaDefinition.cs

@@ -287,9 +287,9 @@ public IEnumerable<KeyValuePair<string, ColumnType>> GetMetadataTypes
         /// </summary>
         public Column this[string columnName]
         {
-#pragma warning disable TLC_NoThis // Do not use 'this' keyword for member access
+#pragma warning disable MSML_NoThis // Do not use 'this' keyword for member access
             get => this.FirstOrDefault(x => x.ColumnName == columnName);
-#pragma warning restore TLC_NoThis // Do not use 'this' keyword for member access
+#pragma warning restore MSML_NoThis // Do not use 'this' keyword for member access
             set
             {
                 Contracts.CheckValue(value, nameof(value));

src/Microsoft.ML.Core/Microsoft.ML.Core.csproj

@@ -11,13 +11,4 @@
     <Folder Include="Properties\" />
   </ItemGroup>
 
-  <ItemGroup>
-    <!-- Once we validate this, we ought to move this to one of the higher level directory files. -->
-    <ProjectReference Include="..\..\tools-local\Microsoft.ML.CodeAnalyzer\Microsoft.ML.CodeAnalyzer.csproj">
-      <ReferenceOutputAssembly>false</ReferenceOutputAssembly>
-      <OutputItemType>Analyzer</OutputItemType>
-    </ProjectReference>
-    
-  </ItemGroup>
-
 </Project>

src/Microsoft.ML.Data/Commands/TrainCommand.cs

@@ -222,9 +222,9 @@ public static string MatchNameOrDefaultOrNull(IExceptionContext ectx, ISchema sc
                 return userName;
             if (userName == defaultName)
                 return null;
-#pragma warning disable TLC_ContractsNameUsesNameof
+#pragma warning disable MSML_ContractsNameUsesNameof
             throw ectx.ExceptUserArg(argName, $"Could not find column '{userName}'");
-#pragma warning restore TLC_ContractsNameUsesNameof
+#pragma warning restore MSML_ContractsNameUsesNameof
         }
 
         public static IPredictor Train(IHostEnvironment env, IChannel ch, RoleMappedData data, ITrainer trainer, string name,

src/Microsoft.ML.Data/Data/DataViewUtils.cs

@@ -286,9 +286,9 @@ private sealed class Splitter
             private enum ExtraIndex
             {
                 Id,
-#pragma warning disable TLC_GeneralName // Allow for this private enum.
+#pragma warning disable MSML_GeneralName // Allow for this private enum.
                 _Lim
-#pragma warning restore TLC_GeneralName
+#pragma warning restore MSML_GeneralName
             }
 
             private Splitter(ISchema schema)

src/Microsoft.ML.Data/DataLoadSave/PartitionedFileLoader.cs

@@ -682,13 +682,12 @@ private bool TryTruncatePath(int dirCount, string path, out string truncPath)
                     Ch.Warning($"Path {path} did not have {dirCount} directories necessary for parsing.");
                     return false;
                 }
-                
+
                 // Rejoin segments to create a valid path.
                 truncPath = String.Join(Path.DirectorySeparatorChar.ToString(), segments);
                 return true;
             }
 
-
             /// <summary>
             /// Parse all column values from the directory path.
             /// </summary>

src/Microsoft.ML.Data/Depricated/TGUIAttribute.cs

@@ -7,12 +7,12 @@
 
 namespace Microsoft.ML.Runtime.Internal.Internallearn
 {
-#pragma warning disable TLC_GeneralName // This structure should be deprecated anyway.
+#pragma warning disable MSML_GeneralName // This structure should be deprecated anyway.
     // REVIEW: Get rid of this. Everything should be in the ArgumentAttribute (or a class
     // derived from ArgumentAttribute).
     [AttributeUsage(AttributeTargets.Field)]
     public class TGUIAttribute : Attribute
-#pragma warning restore TLC_GeneralName
+#pragma warning restore MSML_GeneralName
     {
         // Display parameters
         public string Label { get; set; }

src/Microsoft.ML.Data/Dirty/PredictorBase.cs

@@ -41,9 +41,9 @@ protected PredictorBase(IHostEnvironment env, string name, ModelLoadContext ctx)
 
             // Verify that the Float type matches.
             int cbFloat = ctx.Reader.ReadInt32();
-#pragma warning disable TLC_NoMessagesForLoadContext // This one is actually useful.
+#pragma warning disable MSML_NoMessagesForLoadContext // This one is actually useful.
             Host.CheckDecode(cbFloat == sizeof(Float), "This file was saved by an incompatible version");
-#pragma warning restore TLC_NoMessagesForLoadContext
+#pragma warning restore MSML_NoMessagesForLoadContext
         }
 
         public virtual void Save(ModelSaveContext ctx)

src/Microsoft.ML.Data/EntryPoints/InputBuilder.cs

@@ -791,7 +791,7 @@ public static class Range
         /// </summary>
         public static class Deprecated
         {
-            public new static string ToString() => "Deprecated";
+            new public static string ToString() => "Deprecated";
             public const string Message = "Message";
         }
 
@@ -800,7 +800,7 @@ public static class Deprecated
         /// </summary>
         public static class SweepableLongParam
         {
-            public new static string ToString() => "SweepRange";
+            new public static string ToString() => "SweepRange";
             public const string RangeType = "RangeType";
             public const string Max = "Max";
             public const string Min = "Min";
@@ -814,7 +814,7 @@ public static class SweepableLongParam
         /// </summary>
         public static class SweepableFloatParam
         {
-            public new static string ToString() => "SweepRange";
+            new public static string ToString() => "SweepRange";
             public const string RangeType = "RangeType";
             public const string Max = "Max";
             public const string Min = "Min";
@@ -828,14 +828,14 @@ public static class SweepableFloatParam
         /// </summary>
         public static class SweepableDiscreteParam
         {
-            public new static string ToString() => "SweepRange";
+            new public static string ToString() => "SweepRange";
             public const string RangeType = "RangeType";
             public const string Options = "Values";
         }
 
         public static class PipelineSweeperSupportedMetrics
         {
-            public new static string ToString() => "SupportedMetric";
+            new public static string ToString() => "SupportedMetric";
             public const string Auc = BinaryClassifierEvaluator.Auc;
             public const string AccuracyMicro = Data.MultiClassClassifierEvaluator.AccuracyMicro;
             public const string AccuracyMacro = MultiClassClassifierEvaluator.AccuracyMacro;

src/Microsoft.ML.Data/Evaluators/EvaluatorUtils.cs

@@ -115,10 +115,10 @@ public static ColumnInfo GetScoreColumnInfo(IExceptionContext ectx, ISchema sche
             ColumnInfo info;
             if (!string.IsNullOrWhiteSpace(name))
             {
-#pragma warning disable TLC_ContractsNameUsesNameof
+#pragma warning disable MSML_ContractsNameUsesNameof
                 if (!ColumnInfo.TryCreateFromName(schema, name, out info))
                     throw ectx.ExceptUserArg(argName, "Score column is missing");
-#pragma warning restore TLC_ContractsNameUsesNameof
+#pragma warning restore MSML_ContractsNameUsesNameof
                 return info;
             }
 
@@ -145,9 +145,9 @@ public static ColumnInfo GetScoreColumnInfo(IExceptionContext ectx, ISchema sche
             if (!string.IsNullOrWhiteSpace(defName) && ColumnInfo.TryCreateFromName(schema, defName, out info))
                 return info;
 
-#pragma warning disable TLC_ContractsNameUsesNameof
+#pragma warning disable MSML_ContractsNameUsesNameof
             throw ectx.ExceptUserArg(argName, "Score column is missing");
-#pragma warning restore TLC_ContractsNameUsesNameof
+#pragma warning restore MSML_ContractsNameUsesNameof
         }
 
         /// <summary>
@@ -168,12 +168,12 @@ public static ColumnInfo GetOptAuxScoreColumnInfo(IExceptionContext ectx, ISchem
             if (!string.IsNullOrWhiteSpace(name))
             {
                 ColumnInfo info;
-#pragma warning disable TLC_ContractsNameUsesNameof
+#pragma warning disable MSML_ContractsNameUsesNameof
                 if (!ColumnInfo.TryCreateFromName(schema, name, out info))
                     throw ectx.ExceptUserArg(argName, "{0} column is missing", valueKind);
                 if (!testType(info.Type))
                     throw ectx.ExceptUserArg(argName, "{0} column has incompatible type", valueKind);
-#pragma warning restore TLC_ContractsNameUsesNameof
+#pragma warning restore MSML_ContractsNameUsesNameof
                 return info;
             }